From: MyungJoo Ham <myungjoo.ham@samsung.com>
To: "dirk.brandewie@gmail.com" <dirk.brandewie@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "cbouatmailru@gmail.com" <cbouatmailru@gmail.com>,
김동근 <dg77.kim@samsung.com>, 박경민 <kyungmin.park@samsung.com>,
"Jason.Wortham@maxim-ic.com" <Jason.Wortham@maxim-ic.com>,
"alan@linux.intel.com" <alan@linux.intel.com>
Subject: Re: [PATCH 2/4] max17042: Align register definitions with data sheet and init appnote
Date: Tue, 29 Nov 2011 01:26:44 +0000 (GMT) [thread overview]
Message-ID: <29933944.99561322530003472.JavaMail.weblogic@epml27> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 3096 bytes --]
Sender : dirk.brandewie@gmail.com<dirk.brandewie@gmail.com>
Date : 2011-11-29 04:49 (GMT+09:00)
Title : [PATCH 2/4] max17042: Align register definitions with data sheet and init appnote
>
> From: Dirk Brandewie <dirk.brandewie@gmail.com>
>
> align the register names with max17042 data sheet removing
> registers that are marked reserved that are not used.
>
> Add register definitions defined in the maxim initialization appnote
>
> Signed-off-by: Dirk Brandewie <dirk.brandewie@gmail.com>
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
> ---
> include/linux/power/max17042_battery.h | 37 ++++++++++++++++++++++++-------
> 1 files changed, 28 insertions(+), 9 deletions(-)
>
> diff --git a/include/linux/power/max17042_battery.h b/include/linux/power/max17042_battery.h
> index fe99211..67eeada 100644
> --- a/include/linux/power/max17042_battery.h
> +++ b/include/linux/power/max17042_battery.h
> @@ -40,11 +40,11 @@ enum max17042_register {
> MAX17042_VCELL = 0x09,
> MAX17042_Current = 0x0A,
> MAX17042_AvgCurrent = 0x0B,
> - MAX17042_Qresidual = 0x0C,
> +
> MAX17042_SOC = 0x0D,
> MAX17042_AvSOC = 0x0E,
> MAX17042_RemCap = 0x0F,
> - MAX17402_FullCAP = 0x10,
> + MAX17042_FullCAP = 0x10,
> MAX17042_TTE = 0x11,
> MAX17042_V_empty = 0x12,
>
> @@ -62,14 +62,14 @@ enum max17042_register {
> MAX17042_AvCap = 0x1F,
> MAX17042_ManName = 0x20,
> MAX17042_DevName = 0x21,
> - MAX17042_DevChem = 0x22,
>
> + MAX17042_FullCAPNom = 0x23,
> MAX17042_TempNom = 0x24,
> - MAX17042_TempCold = 0x25,
> + MAX17042_TempLim = 0x25,
> MAX17042_TempHot = 0x26,
> MAX17042_AIN = 0x27,
> MAX17042_LearnCFG = 0x28,
> - MAX17042_SHFTCFG = 0x29,
> + MAX17042_FilterCFG = 0x29,
> MAX17042_RelaxCFG = 0x2A,
> MAX17042_MiscCFG = 0x2B,
> MAX17042_TGAIN = 0x2C,
> @@ -77,22 +77,41 @@ enum max17042_register {
> MAX17042_CGAIN = 0x2E,
> MAX17042_COFF = 0x2F,
>
> - MAX17042_Q_empty = 0x33,
> + MAX17042_MaskSOC = 0x32,
> + MAX17042_SOC_empty = 0x33,
> MAX17042_T_empty = 0x34,
>
> + MAX17042_FullCAP0 = 0x35,
> + MAX17042_LAvg_empty = 0x36,
> + MAX17042_FCTC = 0x37,
> MAX17042_RCOMP0 = 0x38,
> MAX17042_TempCo = 0x39,
> - MAX17042_Rx = 0x3A,
> - MAX17042_T_empty0 = 0x3B,
> + MAX17042_EmptyTempCo = 0x3A,
> + MAX17042_K_empty0 = 0x3B,
> MAX17042_TaskPeriod = 0x3C,
> MAX17042_FSTAT = 0x3D,
>
> MAX17042_SHDNTIMER = 0x3F,
>
> - MAX17042_VFRemCap = 0x4A,
> + MAX17042_dQacc = 0x45,
> + MAX17042_dPacc = 0x46,
> +
> + MAX17042_VFSOC0 = 0x48,
>
> MAX17042_QH = 0x4D,
> MAX17042_QL = 0x4E,
> +
> + MAX17042_VFSOC0Enable = 0x60,
> + MAX17042_MLOCKReg1 = 0x62,
> + MAX17042_MLOCKReg2 = 0x63,
> +
> + MAX17042_MODELChrTbl = 0x80,
> +
> + MAX17042_OCV = 0xEE,
> +
> + MAX17042_OCVInternal = 0xFB,
> +
> + MAX17042_VFSOC = 0xFF,
> };
>
> /*
> --
> 1.7.7.3
>
>
MyungJoo Ham (ÇÔ¸íÁÖ)
Mobile Software Platform Lab,
Digital Media and Communications (DMC) Business
Samsung Electronics
cell: +82-10-6714-2858 / office: +82-31-279-8033
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next reply other threads:[~2011-11-29 1:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 1:26 MyungJoo Ham [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-11-28 19:49 [PATCH 0/4] MAX17042 add support for maxim POR procedure dirk.brandewie
2011-11-28 19:49 ` [PATCH 2/4] max17042: Align register definitions with data sheet and init appnote dirk.brandewie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29933944.99561322530003472.JavaMail.weblogic@epml27 \
--to=myungjoo.ham@samsung.com \
--cc=Jason.Wortham@maxim-ic.com \
--cc=alan@linux.intel.com \
--cc=cbouatmailru@gmail.com \
--cc=dg77.kim@samsung.com \
--cc=dirk.brandewie@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.