From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Olivier MATZ <olivier.matz@6wind.com>
Cc: dev@dpdk.org, pablo.de.lara.guarch@intel.com
Subject: Re: [PATCH] app/testpmd: log mbuf pool creation
Date: Tue, 31 May 2016 10:39:33 +0200 [thread overview]
Message-ID: <2996941.2Z82H6L4i5@xps13> (raw)
In-Reply-To: <574D3FA2.10301@6wind.com>
2016-05-31 09:39, Olivier MATZ:
> Hi Thomas,
>
> On 05/30/2016 09:44 PM, Thomas Monjalon wrote:
> > 2016-05-30 14:04, Olivier Matz:
> >> Enhance the logs related to mbuf pool creation. Display an info level
> >> log when creating the mbuf, and display the error as a string on failure.
> >>
> >> After the patch, we have:
> >>
> >> [...]
> >> EAL: probe driver: 8086:10fb rte_ixgbe_pmd
> >> USER1: create a new mbuf pool <mbuf_pool_socket_0>: n=331456, \
> >> size=2176, socket=0
> >> EAL: Error - exiting with code: 1
> >> Cause: Creation of mbuf pool for socket 0 failed: Cannot allocate \
> >> memory
> >
> > Yes printing the error reason is a good improvement.
> > But why the previous line is at INFO level? It looks to be a debug.
> >
>
> Using INFO instead of DEBUG was done on purpose. I think the mbuf
> pool parameters is a valuable information for the user running testpmd,
> especially to ensure it's compatible with best performance.
OK, seems reasonnable.
next prev parent reply other threads:[~2016-05-31 8:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 12:04 [PATCH] app/testpmd: log mbuf pool creation Olivier Matz
2016-05-30 19:44 ` Thomas Monjalon
2016-05-31 7:39 ` Olivier MATZ
2016-05-31 8:39 ` Thomas Monjalon [this message]
2016-06-02 14:49 ` De Lara Guarch, Pablo
2016-06-08 15:21 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2996941.2Z82H6L4i5@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.