From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Kees Cook <keescook@chromium.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-hardening@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Joe Perches <joe@perches.com>
Subject: Re: [PATCH RESEND] gcc-plugins: avoid errors with -std=gnu++11 on old gcc
Date: Thu, 18 Mar 2021 07:47:06 -0400 [thread overview]
Message-ID: <299822.1616068026@turing-police> (raw)
In-Reply-To: <CAK7LNAT_hp0PmhWpb2=fScw6Q9DQsBztykis=xN0QCH==AVY6g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 963 bytes --]
On Thu, 18 Mar 2021 18:07:28 +0900, Masahiro Yamada said:
> We can require GCC 6+ for building GCC plugins.
> + depends on CC_IS_GCC && GCC_VERSION >= 60000
I'd be OK with that personally, but the question is whether
any gcc 4.9 or 5.x users are using plugins. That's a bit above
my pay grade. Kees? Do we have any data on that? (All I know
is that there is at least one, because they tripped over the GCC bug
that prompted the second patch)
> BTW, the commit message mentions that
> the issues only happen on GCC 4 and 5,
> but the added code was:
>
> GCC_FLAVOR = $(call cc-ifversion, -ge, 1100, 11, 98)
>
> instead of
>
> GCC_FLAVOR = $(call cc-ifversion, -ge, 600, 11, 98)
>
> So, this patch is also requiring to cover two standards:
>
> GCC_VERSION >= 11 : -std=gnu++11
> GCC_VERSION < 11 : -std=gnu++98
I chose 1100 so that everything from 4.9 to 10 would keep getting
handed gnu++98 the way they had been, and only change it for
gcc11.
[-- Attachment #2: Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2021-03-18 11:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 8:40 [PATCH RESEND] gcc-plugins: avoid errors with -std=gnu++11 on old gcc Valdis Klētnieks
2021-03-18 5:52 ` Kees Cook
2021-03-18 6:02 ` Valdis Klētnieks
2021-03-18 6:26 ` Miguel Ojeda
2021-03-18 9:07 ` Masahiro Yamada
2021-03-18 11:47 ` Valdis Klētnieks [this message]
2021-03-18 11:41 ` David Laight
2021-03-18 11:55 ` Valdis Klētnieks
2021-03-18 13:38 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=299822.1616068026@turing-police \
--to=valdis.kletnieks@vt.edu \
--cc=geert@linux-m68k.org \
--cc=joe@perches.com \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.