Re: [meta-mingw] [PATCH v2 1/3] protobuf: static link tools when generating sdk

["Joshua Watt" <JPEWhacker@gmail.com>]

These 3 recipes are in meta-oe, not OE-core which means that the 
bbappends are going to cause a dangling appends error/warning. Please 
add a dynamic BBFILES pattern[1] so that these are conditionally applied 
only if meta-oe is present, something like:

  BBFILES_DYNAMIC += "\
openembedded-layer:${LAYERDIR}/dynamic-layers/openembedded-layer/recipes-*/*/*.bb 
\
openembedded-layer:${LAYERDIR}/dynamic-layers/openembedded-layer/recipes-*/*/*.bbappend 
\
  "

[1]: 
https://docs.yoctoproject.org/ref-manual/variables.html#term-BBFILES_DYNAMIC

On 8/17/21 9:33 AM, Joshua Watt wrote:
>
> On 8/17/21 9:07 AM, Sinan Kaya wrote:
>> Dynamically linked protoc.exe is failing as follows:
>>
>> [libprotobuf ERROR google/protobuf/descriptor_database.cc:641]
>> File already exists in database: google/protobuf/descriptor.proto
>> [libprotobuf FATAL google/protobuf/descriptor.cc:1371] CHECK failed:
>> GeneratedDatabase()->Add(encoded_file_descriptor, size):
>>
>> Switch to static linkage per upstream recommendation.
>>
>> Signed-off-by: Sinan Kaya <okaya@kernel.org>
>> ---
>>   recipes-devtools/protobuf/protobuf_%.bbappend | 1 +
>>   1 file changed, 1 insertion(+)
>>   create mode 100644 recipes-devtools/protobuf/protobuf_%.bbappend
>>
>> diff --git a/recipes-devtools/protobuf/protobuf_%.bbappend 
>> b/recipes-devtools/protobuf/protobuf_%.bbappend
>> new file mode 100644
>> index 0000000..b53b22d
>> --- /dev/null
>> +++ b/recipes-devtools/protobuf/protobuf_%.bbappend
>> @@ -0,0 +1 @@
>> +EXTRA_OECONF:append:sdkmingw32 = " --disable-shared"
>
> Apologies, this should use the :mingw32 override, since it's not 
> *specific* to the SDK, but MinGW in general. Anyway, I fixed this up 
> for you since I wasn't clear; this is in master-next and I'll get it 
> tested shortly
>
>