From: Markus Elfring <Markus.Elfring@web.de>
To: Stanley Chu <yschu@nuvoton.com>,
linux-i3c@lists.infradead.org, devicetree@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Conor Dooley <conor+dt@kernel.org>, Frank Li <Frank.Li@nxp.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Rob Herring <robh@kernel.org>
Cc: Stanley Chu <stanley.chuys@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Joseph Liu <KWLIU@nuvoton.com>,
Tomer Maimon <tomer.maimon@nuvoton.com>
Subject: Re: [PATCH v4 5/5] i3c: master: svc: Fix npcm845 DAA process corruption
Date: Tue, 25 Feb 2025 10:43:38 +0100 [thread overview]
Message-ID: <29a06fff-1fa2-49bd-aa72-e1eff1634b84@web.de> (raw)
In-Reply-To: <20250224083908.1880383-6-yschu@nuvoton.com>
…
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -1162,7 +1162,16 @@ static int svc_i3c_master_do_daa(struct i3c_master_controller *m)
> }
>
> spin_lock_irqsave(&master->xferqueue.lock, flags);
…
> spin_unlock_irqrestore(&master->xferqueue.lock, flags);
>
> svc_i3c_master_clear_merrwarn(master);
…
Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irqsave)(&master->xferqueue.lock);”?
https://elixir.bootlin.com/linux/v6.14-rc4/source/include/linux/spinlock.h#L572
Regards,
Markus
prev parent reply other threads:[~2025-02-25 9:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 8:39 [PATCH v4 0/5] Add support for Nuvoton npcm845 i3c controller Stanley Chu
2025-02-24 8:39 ` Stanley Chu
2025-02-24 8:39 ` [PATCH v4 1/5] dt-bindings: i3c: silvaco: Add npcm845 compatible string Stanley Chu
2025-02-24 8:39 ` Stanley Chu
2025-02-24 16:18 ` Frank Li
2025-02-24 16:18 ` Frank Li
2025-02-24 8:39 ` [PATCH v4 2/5] i3c: master: svc: Add support for Nuvoton npcm845 i3c Stanley Chu
2025-02-24 8:39 ` Stanley Chu
2025-02-24 16:23 ` Frank Li
2025-02-24 16:23 ` Frank Li
2025-02-24 8:39 ` [PATCH v4 3/5] i3c: master: svc: Fix npcm845 FIFO empty issue Stanley Chu
2025-02-24 8:39 ` Stanley Chu
2025-02-24 16:32 ` Frank Li
2025-02-24 16:32 ` Frank Li
2025-02-25 9:28 ` Stanley Chu
2025-02-25 9:28 ` Stanley Chu
2025-02-25 16:32 ` Frank Li
2025-02-25 16:32 ` Frank Li
2025-02-26 3:26 ` Stanley Chu
2025-02-26 3:26 ` Stanley Chu
2025-02-26 16:53 ` Frank Li
2025-02-26 16:53 ` Frank Li
2025-02-24 8:39 ` [PATCH v4 4/5] i3c: master: svc: Fix npcm845 invalid slvstart event Stanley Chu
2025-02-24 8:39 ` Stanley Chu
2025-02-24 8:39 ` [PATCH v4 5/5] i3c: master: svc: Fix npcm845 DAA process corruption Stanley Chu
2025-02-24 8:39 ` Stanley Chu
2025-02-24 16:35 ` Frank Li
2025-02-24 16:35 ` Frank Li
2025-02-25 9:43 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29a06fff-1fa2-49bd-aa72-e1eff1634b84@web.de \
--to=markus.elfring@web.de \
--cc=Frank.Li@nxp.com \
--cc=KWLIU@nuvoton.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=robh@kernel.org \
--cc=stanley.chuys@gmail.com \
--cc=tomer.maimon@nuvoton.com \
--cc=yschu@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.