From: Leon Hwang <leon.hwang@linux.dev>
To: Masoud Aghasi <maghasi@disroot.org>, bpf@vger.kernel.org
Cc: andrii@kernel.org, eddyz87@gmail.com, ast@kernel.org,
daniel@iogearbox.net, memxor@gmail.com, martin.lau@linux.dev,
song@kernel.org, yonghong.song@linux.dev, jolsa@kernel.org,
emil@etsalapatis.com, ihor.solodrai@linux.dev
Subject: Re: [PATCH bpf v4 3/3] selftests/bpf: add tests for percpu map flags combination
Date: Tue, 6 Oct 2026 10:12:05 +0800 [thread overview]
Message-ID: <29ad3e60-1404-4240-8167-222cc0c684f2@linux.dev> (raw)
In-Reply-To: <2c50da80-5c48-4bcc-a497-64d6a1a80b1c@disroot.org>
On 5/10/26 23:19, Masoud Aghasi wrote:
> On 05/10/2026 04:12, Leon Hwang wrote:
>> On 4/10/26 19:10, Masoud Aghasi wrote:
[...]
>>
>> After reading test_percpu_map_flags_combination(), two helpers are
>> needed to verify the updated values. One for updating with BPF_F_CPU,
>> another one for updating with BPF_F_ALL_CPUS.
>>
>> Thanks,
>> Leon
>
> Thanks, I will apply your comments to the v5.
> just regarding the is_hash_map, isn't it better to keep it as an
> implementation detail inside the function and avoid introducing an
> unnecessary invariant for callers to maintain?
I think either way is fine in this selftest.
Thanks,
Leon
prev parent reply other threads:[~2026-10-06 2:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-04 11:10 [PATCH bpf v4 0/3] bpf: Fix incorrect handling of user flags by percpu map updates Masoud Aghasi
2026-10-04 11:10 ` [PATCH bpf v4 1/3] bpf: Fix incorrect handling of user flags in bpf_percpu_array_update Masoud Aghasi
2026-10-05 3:10 ` Leon Hwang
2026-10-05 14:58 ` Masoud Aghasi
2026-10-04 11:10 ` [PATCH bpf v4 2/3] bpf: Fix incorrect handling of user flags by percpu hash map updates Masoud Aghasi
2026-10-04 11:10 ` [PATCH bpf v4 3/3] selftests/bpf: add tests for percpu map flags combination Masoud Aghasi
2026-10-05 3:12 ` Leon Hwang
2026-10-05 15:19 ` Masoud Aghasi
2026-10-06 2:12 ` Leon Hwang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29ad3e60-1404-4240-8167-222cc0c684f2@linux.dev \
--to=leon.hwang@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=ihor.solodrai@linux.dev \
--cc=jolsa@kernel.org \
--cc=maghasi@disroot.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.