From: Ganesh <ganeshgr@linux.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
Sachin Sant <sachinp@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Cc: mahesh@linux.ibm.com
Subject: Re: [6.0-rc1] Kernel crash while running MCE tests
Date: Mon, 22 Aug 2022 11:40:47 +0530 [thread overview]
Message-ID: <29cc4bc6-d952-b23e-e4fd-f56a78bc88fd@linux.ibm.com> (raw)
In-Reply-To: <87lergltej.fsf@mpe.ellerman.id.au>
[-- Attachment #1: Type: text/plain, Size: 708 bytes --]
On 8/22/22 11:19, Michael Ellerman wrote:
>>> So I guess the compiler has decided not to inline it (why?!), and it is
>>> not marked noinstr, so it gets KASAN instrumentation which crashes in
>>> real mode.
>>>
>>> We'll have to make sure everything get_pseries_errorlog() is either
>>> forced inline, or marked noinstr.
>> Making the following functions always_inline and noinstr is fixing the issue.
>> __always_inline pseries_errorlog_id()
>> __always_inline pseries_errorlog_length()
>> __always_inline do_enter_rtas()
>> __always_inline srr_regs_clobbered()
>> noinstr va_rtas_call_unlocked()
> Why do we need it? Because of fwnmi_release_errinfo()?
Yes.
>> Shall I post the patch?
> Yeah.
>
> cheers
[-- Attachment #2: Type: text/html, Size: 1479 bytes --]
prev parent reply other threads:[~2022-08-22 7:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 16:01 [6.0-rc1] Kernel crash while running MCE tests Sachin Sant
2022-08-17 5:58 ` Michael Ellerman
2022-08-19 4:42 ` Ganesh
2022-08-22 5:31 ` Sachin Sant
2022-08-22 6:12 ` Ganesh
2022-08-22 5:49 ` Michael Ellerman
2022-08-22 6:10 ` Ganesh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29cc4bc6-d952-b23e-e4fd-f56a78bc88fd@linux.ibm.com \
--to=ganeshgr@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=sachinp@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.