From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1g3DgJ-0002DM-1x for ath10k@lists.infradead.org; Fri, 21 Sep 2018 05:08:44 +0000 MIME-Version: 1.0 Date: Fri, 21 Sep 2018 10:38:31 +0530 From: Anilkumar Kolli Subject: Re: [RFCv3 1/2] mac80211: implement ieee80211_tx_rate_update to update rate In-Reply-To: <87va706tfz.fsf@toke.dk> References: <1537445116-10780-1-git-send-email-akolli@codeaurora.org> <1537445116-10780-2-git-send-email-akolli@codeaurora.org> <87va706tfz.fsf@toke.dk> Message-ID: <29efd8dc90c7ea75f6cd0d7e3787b463@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: linux-wireless-owner@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org T24gMjAxOC0wOS0yMCAyMTo0MCwgVG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIHdyb3RlOgo+IEFu aWxrdW1hciBLb2xsaSA8YWtvbGxpQGNvZGVhdXJvcmEub3JnPiB3cml0ZXM6Cj4gCj4+IEN1cnJl bnQgbWFjODAyMTEgaGFzIHByb3Zpc2lvbiB0byB1cGRhdGUgdHggc3RhdHVzIHRocm91Z2gKPj4g aWVlZTgwMjExX3R4X3N0YXR1cygpIGFuZCBpZWVlODAyMTFfdHhfc3RhdHVzX2V4dCgpLiBCdXQK Pj4gZHJpdmVycyBsaWtlIGF0aDEwayB1cGRhdGVzIHRoZSB0eCBzdGF0dXMgZnJvbSB0aGUgc2ti IGV4Y2VwdAo+PiB0eHJhdGUsIHR4cmF0ZSB3aWxsIGJlIHVwZGF0ZWQgZnJvbSBhIGRpZmZlcmVu dCBwYXRoLCBwZWVyIHN0YXRzLgo+PiAKPj4gVXNpbmcgaWVlZTgwMjExX3R4X3N0YXR1c19leHQo KSBpbiB0d28gZGlmZmVyZW50IHBhdGhzCj4+ICAgLSAob25lIGZvciB0aGUgc3RhdHMsIG9uZSBm b3IgdGhlIHR4IHJhdGUpIHdpbGwgZHVwbGljYXRlIHRoZSBzdGF0cy4KPj4gCj4+IFRvIGF2b2lk IHRoaXMgc3RhdHMgZHVwbGljYXRpb24sIGllZWU4MDIxMV90eF9yYXRlX3VwZGF0ZSgpIGlzIAo+ PiBpbXBsZW1lbnRlZC4KPj4gCj4+IFNpZ25lZC1vZmYtYnk6IEFuaWxrdW1hciBLb2xsaSA8YWtv bGxpQGNvZGVhdXJvcmEub3JnPgo+PiAtLS0KPj4gVjM6Cj4+ICAgLSBBZGRlZCBuZXcgQVBJIGlu IG1hYzgwMjExIHRvIHVwZGF0ZSB0eCByYXRlKEpvaGFubmVzKQo+PiAKPj4gIGluY2x1ZGUvbmV0 L21hYzgwMjExLmggfCAgIDE0ICsrKysrKysrKysrKysrCj4+ICBuZXQvbWFjODAyMTEvc3RhdHVz LmMgIHwgICAyNCArKysrKysrKysrKysrKysrKysrKysrKysKPj4gIDIgZmlsZXMgY2hhbmdlZCwg MzggaW5zZXJ0aW9ucygrKQo+PiAKPj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbmV0L21hYzgwMjEx LmggYi9pbmNsdWRlL25ldC9tYWM4MDIxMS5oCj4+IGluZGV4IDhjMjZkMmQzNmNiZS4uMDQyMTg2 YTIxNzcwIDEwMDY0NAo+PiAtLS0gYS9pbmNsdWRlL25ldC9tYWM4MDIxMS5oCj4+ICsrKyBiL2lu Y2x1ZGUvbmV0L21hYzgwMjExLmgKPj4gQEAgLTQzMzEsNiArNDMzMSwyMCBAQCB2b2lkIAo+PiBp ZWVlODAyMTFfc3RhX3NldF9leHBlY3RlZF90aHJvdWdocHV0KHN0cnVjdCBpZWVlODAyMTFfc3Rh ICpwdWJzdGEsCj4+ICAJCQkJCSAgIHUzMiB0aHIpOwo+PiAKPj4gIC8qKgo+PiArICogaWVlZTgw MjExX3R4X3JhdGVfdXBkYXRlIC0gdHJhbnNtaXQgcmF0ZSB1cGRhdGUgY2FsbGJhY2sKPj4gKyAq Cj4+ICsgKiBUaGlzIGZ1bmN0aW9uIGNhbiBiZSB1c2VkIGluIGRyaXZlcnMgdGhhdCBkb2VzIG5v dCBoYXZlIHByb3Zpc2lvbgo+PiArICogaW4gdXBkYXRpbmcgdGhlIHR4IHJhdGUgaW4gZGF0YSBw YXRoLgo+PiArICoKPj4gKyAqIEBodzogdGhlIGhhcmR3YXJlIHRoZSBmcmFtZSB3YXMgdHJhbnNt aXR0ZWQgYnkKPj4gKyAqIEBzdGF0dXM6IHR4IHN0YXR1cyBpbmZvcm1hdGlvbgo+PiArICogQHB1 YnN0YTogdGhlIHN0YXRpb24gdG8gdXBkYXRlIHRoZSB0eCByYXRlIGZvci4KPj4gKyAqLwo+PiAr dm9pZCBpZWVlODAyMTFfdHhfcmF0ZV91cGRhdGUoc3RydWN0IGllZWU4MDIxMV9odyAqaHcsCj4+ ICsJCQkgICAgICBzdHJ1Y3QgaWVlZTgwMjExX3N0YSAqcHVic3RhLAo+PiArCQkJICAgICAgc3Ry dWN0IGllZWU4MDIxMV90eF9pbmZvICppbmZvKTsKPj4gKwo+PiArLyoqCj4+ICAgKiBpZWVlODAy MTFfdHhfc3RhdHVzIC0gdHJhbnNtaXQgc3RhdHVzIGNhbGxiYWNrCj4+ICAgKgo+PiAgICogQ2Fs bCB0aGlzIGZ1bmN0aW9uIGZvciBhbGwgdHJhbnNtaXR0ZWQgZnJhbWVzIGFmdGVyIHRoZXkgaGF2 ZSBiZWVuCj4+IGRpZmYgLS1naXQgYS9uZXQvbWFjODAyMTEvc3RhdHVzLmMgYi9uZXQvbWFjODAy MTEvc3RhdHVzLmMKPj4gaW5kZXggOWE2ZDcyMDhiZjRmLi4yMzIyOTdkZGFhMDIgMTAwNjQ0Cj4+ IC0tLSBhL25ldC9tYWM4MDIxMS9zdGF0dXMuYwo+PiArKysgYi9uZXQvbWFjODAyMTEvc3RhdHVz LmMKPj4gQEAgLTk4OCw2ICs5ODgsMzAgQEAgdm9pZCBpZWVlODAyMTFfdHhfc3RhdHVzX2V4dChz dHJ1Y3QgaWVlZTgwMjExX2h3IAo+PiAqaHcsCj4+ICB9Cj4+ICBFWFBPUlRfU1lNQk9MKGllZWU4 MDIxMV90eF9zdGF0dXNfZXh0KTsKPj4gCj4+ICt2b2lkIGllZWU4MDIxMV90eF9yYXRlX3VwZGF0 ZShzdHJ1Y3QgaWVlZTgwMjExX2h3ICpodywKPj4gKwkJCSAgICAgIHN0cnVjdCBpZWVlODAyMTFf c3RhICpwdWJzdGEsCj4+ICsJCQkgICAgICBzdHJ1Y3QgaWVlZTgwMjExX3R4X2luZm8gKmluZm8p Cj4+ICt7Cj4+ICsJc3RydWN0IGllZWU4MDIxMV9sb2NhbCAqbG9jYWwgPSBod190b19sb2NhbCho dyk7Cj4+ICsJc3RydWN0IGllZWU4MDIxMV9zdXBwb3J0ZWRfYmFuZCAqc2JhbmQ7Cj4+ICsJc3Ry dWN0IHN0YV9pbmZvICpzdGE7Cj4+ICsJc3RydWN0IGllZWU4MDIxMV90eF9zdGF0dXMgc3RhdHVz Owo+PiArCj4+ICsJc2JhbmQgPSBody0+d2lwaHktPmJhbmRzW2luZm8tPmJhbmRdOwo+PiArCj4+ ICsJaWYgKHB1YnN0YSkgewo+IAo+IFRoZSBmdW5jdGlvbiBkb2VzIG5vdGhpbmcgaWYgcHVic3Rh IGlzIE5VTEw7IHdvdWxkbid0IGl0IG1ha2UgbW9yZSAKPiBzZW5zZQo+IHRvIGp1c3QgbWFuZGF0 ZSB0aGF0IGl0IGlzbid0IE5VTEwgcmF0aGVyIHRoYW4gaGF2ZSB0aGlzIGNoZWNrPwo+IAoKQVRI MTBLIGRyaXZlciBhbHdheXMgY2FsbHMgdGhpcyBmdW5jdGlvbiB3aXRoIGEgdmFsaWQgU1RBIFtu b3QgTlVMTF0uCgpUaGFua3MKQW5pbC4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5nIGxpc3QKYXRoMTBrQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9hdGgxMGsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:60184 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725887AbeIUKzj (ORCPT ); Fri, 21 Sep 2018 06:55:39 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Date: Fri, 21 Sep 2018 10:38:31 +0530 From: Anilkumar Kolli To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-wireless-owner@vger.kernel.org Subject: Re: [RFCv3 1/2] mac80211: implement ieee80211_tx_rate_update to update rate In-Reply-To: <87va706tfz.fsf@toke.dk> References: <1537445116-10780-1-git-send-email-akolli@codeaurora.org> <1537445116-10780-2-git-send-email-akolli@codeaurora.org> <87va706tfz.fsf@toke.dk> Message-ID: <29efd8dc90c7ea75f6cd0d7e3787b463@codeaurora.org> (sfid-20180921_070902_207745_3886BBCB) Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2018-09-20 21:40, Toke Høiland-Jørgensen wrote: > Anilkumar Kolli writes: > >> Current mac80211 has provision to update tx status through >> ieee80211_tx_status() and ieee80211_tx_status_ext(). But >> drivers like ath10k updates the tx status from the skb except >> txrate, txrate will be updated from a different path, peer stats. >> >> Using ieee80211_tx_status_ext() in two different paths >> - (one for the stats, one for the tx rate) will duplicate the stats. >> >> To avoid this stats duplication, ieee80211_tx_rate_update() is >> implemented. >> >> Signed-off-by: Anilkumar Kolli >> --- >> V3: >> - Added new API in mac80211 to update tx rate(Johannes) >> >> include/net/mac80211.h | 14 ++++++++++++++ >> net/mac80211/status.c | 24 ++++++++++++++++++++++++ >> 2 files changed, 38 insertions(+) >> >> diff --git a/include/net/mac80211.h b/include/net/mac80211.h >> index 8c26d2d36cbe..042186a21770 100644 >> --- a/include/net/mac80211.h >> +++ b/include/net/mac80211.h >> @@ -4331,6 +4331,20 @@ void >> ieee80211_sta_set_expected_throughput(struct ieee80211_sta *pubsta, >> u32 thr); >> >> /** >> + * ieee80211_tx_rate_update - transmit rate update callback >> + * >> + * This function can be used in drivers that does not have provision >> + * in updating the tx rate in data path. >> + * >> + * @hw: the hardware the frame was transmitted by >> + * @status: tx status information >> + * @pubsta: the station to update the tx rate for. >> + */ >> +void ieee80211_tx_rate_update(struct ieee80211_hw *hw, >> + struct ieee80211_sta *pubsta, >> + struct ieee80211_tx_info *info); >> + >> +/** >> * ieee80211_tx_status - transmit status callback >> * >> * Call this function for all transmitted frames after they have been >> diff --git a/net/mac80211/status.c b/net/mac80211/status.c >> index 9a6d7208bf4f..232297ddaa02 100644 >> --- a/net/mac80211/status.c >> +++ b/net/mac80211/status.c >> @@ -988,6 +988,30 @@ void ieee80211_tx_status_ext(struct ieee80211_hw >> *hw, >> } >> EXPORT_SYMBOL(ieee80211_tx_status_ext); >> >> +void ieee80211_tx_rate_update(struct ieee80211_hw *hw, >> + struct ieee80211_sta *pubsta, >> + struct ieee80211_tx_info *info) >> +{ >> + struct ieee80211_local *local = hw_to_local(hw); >> + struct ieee80211_supported_band *sband; >> + struct sta_info *sta; >> + struct ieee80211_tx_status status; >> + >> + sband = hw->wiphy->bands[info->band]; >> + >> + if (pubsta) { > > The function does nothing if pubsta is NULL; wouldn't it make more > sense > to just mandate that it isn't NULL rather than have this check? > ATH10K driver always calls this function with a valid STA [not NULL]. Thanks Anil.