From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F289BC4345F for ; Wed, 17 Apr 2024 08:24:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hadMS8tJbpbIwjyEmv5/DdBNZKMQwpdDA15cK0P/18Y=; b=SMc+LWTZGpcMbB lSvJH7Sce9B0nRlYiRj3tDEOhbwUAAlogXTdrY8dTt+NOc+YKHp7Vwe/DqCz+wwKbjZZkmIpYK96W 0+U0I1AC5XmQi0njr2LU5dSSy08wGtBEwv8m9rYKu7PrFHcKDrwHul28TaYzOEHttSVQcIT2VkULy PPi80ZczTzIsdnm0NZwLl4ygGJHrR9ty6lsnLj1Ateimoh5RHS2sQDtoT6H0tLxhUft8p2RA5Fxbd Lf+uvKTpIzYuz+hs9ZXCozTGFMr+ec9aoj8XI/jVL4PXmfsKCfdnlDdSzH/YC0BoNSdWInpiBnhiM w4fOGpQ1iVUsf1nLD+bg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx0aa-0000000FCC6-1wFA; Wed, 17 Apr 2024 08:24:20 +0000 Received: from relay8-d.mail.gandi.net ([2001:4b98:dc4:8::228]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx0aW-0000000FCBO-1mdk for linux-arm-kernel@lists.infradead.org; Wed, 17 Apr 2024 08:24:18 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 70A831BF20C; Wed, 17 Apr 2024 08:24:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arinc9.com; s=gm1; t=1713342251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eNl2kpmyXA4EHz7sEmeC1SnU4Qf3LOV2W8Qe8fDoaho=; b=dlprTLWJZaB2rIyPzBM8ThbSYbelvbq/IxjTNJ7L+SPus8J681T/AATFX5fEGJ0nZlYiKu DCDAJecOWm5735clknwrECBHmbnsrtvhA85W4/eKi7hFufQHcVtHao+XPVuauI/tF8T2dZ qXFgtbJ9aH5q1IHc7RFkZiBTjmPD0MfeaHBEraCbd5hmCOBMh469nKcoMKMhG/5fWzTMq3 XYLf9fkW6kkUW9bk/3cYcM/eaDF7yoH/+G18OkFAaIKl0MNXU42IGswTB+xarf99oJnTFk QUC3qaqO6aKgcgBoQ+7TZXuE1XhiLaRZXrFJYqhwXmUGTOuSxIRK6E0UmRJhvw== Message-ID: <29f098cb-db41-4d4f-9033-a88d70ebdd0f@arinc9.com> Date: Wed, 17 Apr 2024 11:24:06 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] ARM: dts: BCM5301X: Add DT for ASUS RT-AC3200 To: Florian Fainelli , Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Hauke Mehrtens , Rafal Milecki , Broadcom internal kernel review list Cc: Tom Brautaset , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20240414-for-soc-asus-rt-ac3200-ac5300-v1-0-118c90bae6e5@arinc9.com> <20240414-for-soc-asus-rt-ac3200-ac5300-v1-3-118c90bae6e5@arinc9.com> <85261d11-d6cb-4718-88d9-95a7efe5c0ab@arinc9.com> <335cdd4b-7309-4633-9b4f-6487c72c395c@arinc9.com> <07c9c5f5-c4b9-44d6-b909-5aa306f56898@kernel.org> <00ba4593-d720-419a-a97d-37c402c91e44@arinc9.com> <7b465ddb-2b18-4e7f-8b03-d4e51006e1cb@broadcom.com> Content-Language: en-US From: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= In-Reply-To: <7b465ddb-2b18-4e7f-8b03-d4e51006e1cb@broadcom.com> X-GND-Sasl: arinc.unal@arinc9.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240417_012417_014091_3C7BB184 X-CRM114-Status: GOOD ( 18.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTcvMDQvMjAyNCAwNjoxNSwgRmxvcmlhbiBGYWluZWxsaSB3cm90ZToKPiAKPiAKPiBPbiA0 LzE1LzIwMjQgMjoxMCBBTSwgQXLEsW7DpyDDnE5BTCB3cm90ZToKPj4gT24gMTUuMDQuMjAyNCAx MDo1NywgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToKPj4+IE9uIDE0LzA0LzIwMjQgMjI6MjEs IEFyxLFuw6cgw5xOQUwgd3JvdGU6Cj4+Pj4gTlZSQU0gaXMgZGVzY3JpYmVkIGFzIGJvdGggZmxh c2ggZGV2aWNlIHBhcnRpdGlvbiBhbmQgbWVtb3J5IG1hcHBlZCBOVk1FTS4KPj4+PiBUaGlzIHBs YXRmb3JtIHN0b3JlcyBOVlJBTSBvbiBmbGFzaCBidXQgbWFrZXMgaXQgYWxzbyBtZW1vcnkgYWNj ZXNzaWJsZS4KPj4+Pgo+Pj4+IEFzIGRldmljZSBwYXJ0aXRpb25zIGFyZSBkZXNjcmliZWQgaW4g Ym9hcmQgRFRTLCB0aGUgbnZyYW0gbm9kZSBtdXN0IGFsc28KPj4+Cj4+PiBTb3JyeSwgYnV0IHdl IGRvIG5vdCB0YWxrIGFib3V0IHBhcnRpdGlvbnMuIFBhcnRpdGlvbnMgYXJlIGluZGVlZCBib2Fy ZAo+Pj4gcHJvcGVydHkuIEJ1dCB0aGUgcGllY2Ugb2YgaGFyZHdhcmUsIHNvIE5WTUVNLCBpcyBw cm92aWRlZCBieSBTb0MuCj4+Pgo+Pj4+IGJlIGRlZmluZWQgdGhlcmUgYXMgaXRzIGFkZHJlc3Mg YW5kIHNpemUgd2lsbCBiZSBkaWZmZXJlbnQgYnkgYm9hcmQuIEl0IGhhcwo+Pj4+IGJlZW4gd2lk ZWx5IGRlc2NyaWJlZCBvbiBhdCBsZWFzdCBiY200NzA5IGFuZCBiY200NzA5NCBTb0MgYm9hcmQg RFRTIGZpbGVzCj4+Pj4gaGVyZS4KPj4+Cj4+PiBUaGVzZSBub3QgcHJvcGVyIGFyZ3VtZW50cy4g V2hhdCB5b3UgYXJlIHNheWluZyBoZXJlIGlzIHRoYXQgU29DIGRvZXMgbm8KPj4+IGhhdmUgbnZy YW0gYXQgYWRkcmVzcyAweDFjMDgwMDAuIEluc3RlYWQgeW91IGFyZSBzYXlpbmcgdGhlcmUgc29t ZSBzb3J0Cj4+PiBvZiBidXMgZ29pbmcgb3V0IG9mIFNvQyB0byB0aGUgYm9hcmQgYW5kIG9uIHRo ZSBib2FyZCBwaHlzaWNhbGx5IHRoZXJlCj4+PiBpcyBzb21lIE5WUkFNIHNvcnQgb2YgbWVtb3J5 IGF0dGFjaGVkIHRvIHRoaXMgYnVzLgo+Pgo+PiBZZXMgdGhhdCBpcyB0aGUgY2FzZS4gTlZSQU0g aXMgc3RvcmVkIG9uIGEgcGFydGl0aW9uIG9uIHRoZSBmbGFzaC4gT24gdGhlCj4+IEJyb2FkY29t IE5vcnRoU3RhciBwbGF0Zm9ybSwgdGhlIE5BTkQgZmxhc2ggYmFzZSBpcyAweDFjMDAwMDAwLCB0 aGUgTk9SCj4+IGZsYXNoIGJhc2UgaXMgMHgxZTAwMDAwMC4KPj4KPj4gRm9yIHRoZSBib2FyZCBp biB0aGlzIHBhdGNoLCB0aGUgZmxhc2ggaXMgYSBOQU5EIGZsYXNoLiBUaGUgTlZSQU0gcGFydGl0 aW9uCj4+IHN0YXJ0cyBhdCBhZGRyZXNzIDB4MDAwODAwMDAuIFRoZXJlZm9yZSwgdGhlIE5WUkFN IGNvbXBvbmVudCdzIGFkZHJlc3MgaXMKPj4gMHgxYzA4MDAwMC4KPiAKPiBCZWNhdXNlIHRoZSBm bGFzaCBpcyBtZW1vcnkgbWFwcGVkIGludG8gdGhlIENQVSdzIGFkZHJlc3Mgc3BhY2UsIGEgc2Vw YXJhdGUgbm9kZSB3YXMgZGVmaW5lZCBzaW5jZSBpdCBpcyBub3QgcGFydCBvZiB0aGUgInNvYyIg bm9kZSB3aGljaCBkZXNjcmliZXMgdGhlIGJyaWRnZSB0aGF0IGNvbm5lY3RzIGFsbCBvZiB0aGUg cGVyaXBoZXJhbHMuCj4gCj4gV2hldGhlciB3ZSBzaG91bGQgY3JlYXRlIGFuIGFkZGl0aW9uYWwg YnVzIG5vZGUgd2hpY2ggZGVzY3JpYmVzIHRoZSBicmlkZ2UgYmVpbmcgdXNlZCB0byBhY2Nlc3Mg dGhlIGZsYXNoIGRldmljZXMgdXNpbmcgdGhlIE1NSU8gd2luZG93cyBpcyBkZWJhdGFibGUuIFJh ZmFsLCB3aGF0IGRvIHlvdSB0aGluaz8KCldpbGwgdGhpcyBibG9jayB0aGlzIHBhdGNoIHNlcmll cz8gSWYgbm90LCBJJ2QgbGlrZSB0byBzdWJtaXQgdGhlIG5leHQKdmVyc2lvbiB3aXRoIEtyenlz enRvZidzIGNvbW1lbnRzIG9uIGVhcmx5Y29uIGFuZCBzdGRvdXQtcGF0aCBhZGRyZXNzZWQuCgpB csSxbsOnCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56E3A5D8F6; Wed, 17 Apr 2024 08:24:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713342257; cv=none; b=CIpgM48ueXl7NE9TyydCKTxz4PgIl9YLha2B7eiujthqGWvqNu2+h9f8uR62d/q0dkcnIrjqW4Uh4O5s8uU6b7I3tXKA6zUSgbDFb8v9ib6CuiWYoNWa8zP0lB2wAJPgf0qYjIAf6m3gex/ogm3MkW/z2IQt4O5DeNaXt7Wdin8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713342257; c=relaxed/simple; bh=UnJDeGW6hTOWzM5xTq9iID1BjEcevOyGCrGHXGGwe+c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Twx1wq540uT9a2MR/CKnQL1KG5KdIJWek5jxf3KyNP67l+qY5Ac/TAwVJRRARomSpfPT/eb0qwcuIFXZg41277ZVj+fjMT286Inph3hKfsPlXzPllqpxWoq4jJi1w298NLt8O2GuAR5/z5qpveGi1AeFTw+VJw92I07djqBFZ+Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arinc9.com; spf=pass smtp.mailfrom=arinc9.com; dkim=pass (2048-bit key) header.d=arinc9.com header.i=@arinc9.com header.b=dlprTLWJ; arc=none smtp.client-ip=217.70.183.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arinc9.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arinc9.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arinc9.com header.i=@arinc9.com header.b="dlprTLWJ" Received: by mail.gandi.net (Postfix) with ESMTPSA id 70A831BF20C; Wed, 17 Apr 2024 08:24:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arinc9.com; s=gm1; t=1713342251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eNl2kpmyXA4EHz7sEmeC1SnU4Qf3LOV2W8Qe8fDoaho=; b=dlprTLWJZaB2rIyPzBM8ThbSYbelvbq/IxjTNJ7L+SPus8J681T/AATFX5fEGJ0nZlYiKu DCDAJecOWm5735clknwrECBHmbnsrtvhA85W4/eKi7hFufQHcVtHao+XPVuauI/tF8T2dZ qXFgtbJ9aH5q1IHc7RFkZiBTjmPD0MfeaHBEraCbd5hmCOBMh469nKcoMKMhG/5fWzTMq3 XYLf9fkW6kkUW9bk/3cYcM/eaDF7yoH/+G18OkFAaIKl0MNXU42IGswTB+xarf99oJnTFk QUC3qaqO6aKgcgBoQ+7TZXuE1XhiLaRZXrFJYqhwXmUGTOuSxIRK6E0UmRJhvw== Message-ID: <29f098cb-db41-4d4f-9033-a88d70ebdd0f@arinc9.com> Date: Wed, 17 Apr 2024 11:24:06 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] ARM: dts: BCM5301X: Add DT for ASUS RT-AC3200 To: Florian Fainelli , Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Hauke Mehrtens , Rafal Milecki , Broadcom internal kernel review list Cc: Tom Brautaset , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20240414-for-soc-asus-rt-ac3200-ac5300-v1-0-118c90bae6e5@arinc9.com> <20240414-for-soc-asus-rt-ac3200-ac5300-v1-3-118c90bae6e5@arinc9.com> <85261d11-d6cb-4718-88d9-95a7efe5c0ab@arinc9.com> <335cdd4b-7309-4633-9b4f-6487c72c395c@arinc9.com> <07c9c5f5-c4b9-44d6-b909-5aa306f56898@kernel.org> <00ba4593-d720-419a-a97d-37c402c91e44@arinc9.com> <7b465ddb-2b18-4e7f-8b03-d4e51006e1cb@broadcom.com> Content-Language: en-US From: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= In-Reply-To: <7b465ddb-2b18-4e7f-8b03-d4e51006e1cb@broadcom.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Sasl: arinc.unal@arinc9.com On 17/04/2024 06:15, Florian Fainelli wrote: > > > On 4/15/2024 2:10 AM, Arınç ÜNAL wrote: >> On 15.04.2024 10:57, Krzysztof Kozlowski wrote: >>> On 14/04/2024 22:21, Arınç ÜNAL wrote: >>>> NVRAM is described as both flash device partition and memory mapped NVMEM. >>>> This platform stores NVRAM on flash but makes it also memory accessible. >>>> >>>> As device partitions are described in board DTS, the nvram node must also >>> >>> Sorry, but we do not talk about partitions. Partitions are indeed board >>> property. But the piece of hardware, so NVMEM, is provided by SoC. >>> >>>> be defined there as its address and size will be different by board. It has >>>> been widely described on at least bcm4709 and bcm47094 SoC board DTS files >>>> here. >>> >>> These not proper arguments. What you are saying here is that SoC does no >>> have nvram at address 0x1c08000. Instead you are saying there some sort >>> of bus going out of SoC to the board and on the board physically there >>> is some NVRAM sort of memory attached to this bus. >> >> Yes that is the case. NVRAM is stored on a partition on the flash. On the >> Broadcom NorthStar platform, the NAND flash base is 0x1c000000, the NOR >> flash base is 0x1e000000. >> >> For the board in this patch, the flash is a NAND flash. The NVRAM partition >> starts at address 0x00080000. Therefore, the NVRAM component's address is >> 0x1c080000. > > Because the flash is memory mapped into the CPU's address space, a separate node was defined since it is not part of the "soc" node which describes the bridge that connects all of the peripherals. > > Whether we should create an additional bus node which describes the bridge being used to access the flash devices using the MMIO windows is debatable. Rafal, what do you think? Will this block this patch series? If not, I'd like to submit the next version with Krzysztof's comments on earlycon and stdout-path addressed. Arınç