From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57AA8C4332F for ; Tue, 15 Nov 2022 01:24:17 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1oukgQ-0003ki-PS; Tue, 15 Nov 2022 01:24:14 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oukgQ-0003kc-2V for linux-f2fs-devel@lists.sourceforge.net; Tue, 15 Nov 2022 01:24:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tsonFvOS6RS1LC5pv3D8m58KLVJTIE3DCLY7yqwKmo8=; b=Ii/ihL+ogI3tSKVOxXb/Gsav+D JnPlMGEs08t7eDQx5kLPq3t9aKpIJ5IxZM4dItI9qzlSBu+tGhr8TxNwrT0OO5xbHYyUh3pt0L61b 1YdHbjDJiqVumVhjCLP+DrBq5exCQSaojWt4U8bSH2Z1pnhDFDJGbIl11v3gOQaFbBm8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=tsonFvOS6RS1LC5pv3D8m58KLVJTIE3DCLY7yqwKmo8=; b=a6F5Zbu05b4HFx1kHy+uBsR8Mn rZMlyN8Z5o9BcNaOnUPmQ9aqUj5TmQSpDTSVEC+LlrSW73clbOVsuNd+WlGPUi9u0VhBG4aZGFR5B nNtZgWMj4+hCW/r+Zn/dVDo5da5vDNOtJKErz7gnb8s1Z5p5zcDdqKw+dqgBVsreo1xY=; Received: from ams.source.kernel.org ([145.40.68.75]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1oukgP-008ZNR-21 for linux-f2fs-devel@lists.sourceforge.net; Tue, 15 Nov 2022 01:24:14 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EA96BB8163C; Tue, 15 Nov 2022 01:24:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 628AAC433D6; Tue, 15 Nov 2022 01:24:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668475443; bh=OkqUrzgA922jHYY9nyFD/fx/9c8hDaSCvzWETiK5mt8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=DL/FrX1UGUXe2nntIRUqsW4lY7h560UlQoioX1sAkLQuzDvVVP77mgBJ0CFIY2lrx pYHCVGunnhC4RV6dCnJW7OVCJIbaMw2QdetawxLW6CBlh0YFOgkaM6n5fNjtVigki5 b0Z0GNOvLsdWJCPj3PCmcAOPQ926zuV48GkSL5rC9U9altzGCnTe1VOguRU9+n3YMY ReKESOO3FZU/eUwHdS1adEikkS2XcQHBK1swf06klj7cqxQ129dWV3xcGpW4/m7Ncv jx1rqoi/qrklCMS+0hRassoKSUP0+hQQ4yLmtoIz9ULWFpjRiCO4Swaye6LkqX3BYb xHfYnbKYdMfwg== Message-ID: <29fa9df4-dc5f-a944-a150-68d34904cc91@kernel.org> Date: Tue, 15 Nov 2022 09:23:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Content-Language: en-US To: Yuwei Guan , jaegeuk@kernel.org References: <20221112083250.295700-1-Yuwei.Guan@zeekrlife.com> <20221112083250.295700-2-Yuwei.Guan@zeekrlife.com> <983de611-a9e7-56d0-d375-f2b54e1f4d05@kernel.org> <7f221206-a29c-08ee-dfae-d4875bf7205d@gmail.com> From: Chao Yu In-Reply-To: <7f221206-a29c-08ee-dfae-d4875bf7205d@gmail.com> X-Headers-End: 1oukgP-008ZNR-21 Subject: Re: [f2fs-dev] [PATCH 1/3] f2fs: fix to alloc_mode changed after remount on a small volume device X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gMjAyMi8xMS8xNSAwOjEzLCBZdXdlaSBHdWFuIHdyb3RlOgo+IAo+IE9uIDIwMjIvMTEvMTQg MjI6NDIsIENoYW8gWXUgd3JvdGU6Cj4+IE9uIDIwMjIvMTEvMTIgMTY6MzIsIFl1d2VpIEd1YW4g d3JvdGU6Cj4+PiBUaGUgY29tbWl0IDg0Yjg5ZTVkOTQzZDggKCJmMmZzOiBhZGQgYXV0byB0dW5p bmcgZm9yIHNtYWxsIGRldmljZXMiKSBhZGQKPj4+IHR1bmluZyBmb3Igc21hbGwgdm9sdW1lIGRl dmljZSwgbm93IHN1cHBvcnQgdG8gdHVuZSBhbGxvY2VfbW9kZSB0byAncmV1c2UnCj4+PiBpZiBp dCdzIHNtYWxsIHNpemUuIEJ1dCB0aGUgYWxsb2NfbW9kZSB3aWxsIGNoYW5nZSB0byAnZGVmYXVs dCcgd2hlbiBkbwo+Pj4gcmVtb3VudCBvbiB0aGlzIHNtYWxsIHNpemUgZGlldmNlLgo+Pj4KPj4+ IFRoZSBjb21taXQgNGNhYzkwZDU0OTFjOSAoImYyZnM6IHJlbG9jYXRlIHJlYWRkaXJfcmEgY29u ZmlndXJlCj4+PiBpbml0aWFsaXphdGlvbiIpIHJlbG9jYXRlcyByZWFkZGlyX3JhIHZhcmlhYmxl IHRvIHR1bmluZyBwcm9jZXNzLgo+Pj4KPj4+IFRoaXMgcGF0Y2ggZm8gZml4IGFsbG9jX21vZGUg Y2hhbmdlZCB3aGVuIGRvIHJlbW91bnQgZm9yIGEgc21hbGwgdm9sdW1lCj4+PiBkZXZpY2UuCj4+ Pgo+Pj4gRm9yIGEgc21hbGwgZGV2aWNlLAo+Pj4gLSBhbGxvY19tb2RlIHdpbGwga2VlcCAncmV1 c2UnLCBpZiBubyBhbGxvY19tb2RlIG9wdGlvbiBpbiByZW1vdW50Cj4+PiDCoMKgIGNvbW1hbmQs Cj4+PiAtIGFsbG9jX21vZGUgd2lsbCBiZSBzZXQgYXMgcmVtb3VudCBjb21tYW5kLCBpZiBpdCBo YXMgJ2FsbG9jX21vZGU9Jy4KPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBZdXdlaSBHdWFuIDxZdXdl aS5HdWFuQHplZWtybGlmZS5jb20+Cj4+PiAtLS0KPj4+IMKgIGZzL2YyZnMvc3VwZXIuYyB8IDM3 ICsrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0KPj4+IMKgIDEgZmlsZSBjaGFu Z2VkLCAyMCBpbnNlcnRpb25zKCspLCAxNyBkZWxldGlvbnMoLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0 IGEvZnMvZjJmcy9zdXBlci5jIGIvZnMvZjJmcy9zdXBlci5jCj4+PiBpbmRleCAzODM0ZWFkMDQ2 MjAuLjJmMzY4MjRmZjg0YiAxMDA2NDQKPj4+IC0tLSBhL2ZzL2YyZnMvc3VwZXIuYwo+Pj4gKysr IGIvZnMvZjJmcy9zdXBlci5jCj4+PiBAQCAtMjE5MCw2ICsyMTkwLDIzIEBAIHN0YXRpYyB2b2lk IGYyZnNfZW5hYmxlX2NoZWNrcG9pbnQoc3RydWN0IGYyZnNfc2JfaW5mbyAqc2JpKQo+Pj4gwqDC oMKgwqDCoCBmMmZzX2ZsdXNoX2NrcHRfdGhyZWFkKHNiaSk7Cj4+PiDCoCB9Cj4+PiDCoCArc3Rh dGljIHZvaWQgZjJmc190dW5pbmdfcGFyYW1ldGVycyhzdHJ1Y3QgZjJmc19zYl9pbmZvICpzYmks IGJvb2wgaXNfcmVtb3VudCkKPj4+ICt7Cj4+PiArwqDCoMKgIHN0cnVjdCBmMmZzX3NtX2luZm8g KnNtX2kgPSBTTV9JKHNiaSk7Cj4+PiArCj4+PiArwqDCoMKgIC8qIGFkanVzdCBwYXJhbWV0ZXJz IGFjY29yZGluZyB0byB0aGUgdm9sdW1lIHNpemUgKi8KPj4+ICvCoMKgwqAgaWYgKHNtX2ktPm1h aW5fc2VnbWVudHMgPD0gU01BTExfVk9MVU1FX1NFR01FTlRTKSB7Cj4+PiArwqDCoMKgwqDCoMKg wqAgRjJGU19PUFRJT04oc2JpKS5hbGxvY19tb2RlID0gQUxMT0NfTU9ERV9SRVVTRTsKPj4KPj4g SG93IGFib3V0IG1vdmluZyBhYm92ZSBsb2dpYyBpbnRvIGRlZmF1bHRfb3B0aW9ucygpPwo+Pgo+ IEhpIENoYW8sCj4gCj4gJ3NtX2ktPm1haW5fc2VnbWVudHMnIGluaXQgaW4gZnVuYyAnZjJmc19i dWlsZF9zZWdtZW50X21hbmFnZXIoKScsCj4gCj4gd2hlbiBkbyBmaWxsIHN1cGVyIHByb2Nlc3Ms IHNvIGl0IGNhbm5vdCBtb3ZlIGludG8gZGVmYXVsdF9vcHRpb25zKCkuCgpIb3cgYWJvdXQgY2hl Y2tpbmcgbGUzMl90b19jcHUocmF3X3N1cGVyLT5zZWdtZW50X2NvdW50X21haW4pIGRpcmVjdGx5 PwoKVGhhbmtzLAoKPiAKPj4gVGhhbmtzLAo+Pgo+Pj4gK8KgwqDCoMKgwqDCoMKgIGlmIChmMmZz X2Jsb2NrX3VuaXRfZGlzY2FyZChzYmkpKQo+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc21f aS0+ZGNjX2luZm8tPmRpc2NhcmRfZ3JhbnVsYXJpdHkgPSAxOwo+Pj4gK8KgwqDCoMKgwqDCoMKg IHNtX2ktPmlwdV9wb2xpY3kgPSAxIDw8IEYyRlNfSVBVX0ZPUkNFIHwKPj4+ICvCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAxIDw8IEYyRlNfSVBVX0hPTk9SX09QVV9XUklU RTsKPj4+ICvCoMKgwqAgfQo+Pj4gKwo+Pj4gK8KgwqDCoCBpZiAoIWlzX3JlbW91bnQpCj4+PiAr wqDCoMKgwqDCoMKgwqAgc2JpLT5yZWFkZGlyX3JhID0gMTsKPj4+ICt9Cj4+PiArCj4+PiDCoCBz dGF0aWMgaW50IGYyZnNfcmVtb3VudChzdHJ1Y3Qgc3VwZXJfYmxvY2sgKnNiLCBpbnQgKmZsYWdz LCBjaGFyICpkYXRhKQo+Pj4gwqAgewo+Pj4gwqDCoMKgwqDCoCBzdHJ1Y3QgZjJmc19zYl9pbmZv ICpzYmkgPSBGMkZTX1NCKHNiKTsKPj4+IEBAIC0yMjQ4LDYgKzIyNjUsOCBAQCBzdGF0aWMgaW50 IGYyZnNfcmVtb3VudChzdHJ1Y3Qgc3VwZXJfYmxvY2sgKnNiLCBpbnQgKmZsYWdzLCBjaGFyICpk YXRhKQo+Pj4gwqAgwqDCoMKgwqDCoCBkZWZhdWx0X29wdGlvbnMoc2JpKTsKPj4+IMKgICvCoMKg wqAgZjJmc190dW5pbmdfcGFyYW1ldGVycyhzYmksIHRydWUpOwo+Pj4gKwo+Pj4gwqDCoMKgwqDC oCAvKiBwYXJzZSBtb3VudCBvcHRpb25zICovCj4+PiDCoMKgwqDCoMKgIGVyciA9IHBhcnNlX29w dGlvbnMoc2IsIGRhdGEsIHRydWUpOwo+Pj4gwqDCoMKgwqDCoCBpZiAoZXJyKQo+Pj4gQEAgLTQw NTQsMjIgKzQwNzMsNiBAQCBzdGF0aWMgaW50IGYyZnNfc2V0dXBfY2FzZWZvbGQoc3RydWN0IGYy ZnNfc2JfaW5mbyAqc2JpKQo+Pj4gwqDCoMKgwqDCoCByZXR1cm4gMDsKPj4+IMKgIH0KPj4+IMKg IC1zdGF0aWMgdm9pZCBmMmZzX3R1bmluZ19wYXJhbWV0ZXJzKHN0cnVjdCBmMmZzX3NiX2luZm8g KnNiaSkKPj4+IC17Cj4+PiAtwqDCoMKgIHN0cnVjdCBmMmZzX3NtX2luZm8gKnNtX2kgPSBTTV9J KHNiaSk7Cj4+PiAtCj4+PiAtwqDCoMKgIC8qIGFkanVzdCBwYXJhbWV0ZXJzIGFjY29yZGluZyB0 byB0aGUgdm9sdW1lIHNpemUgKi8KPj4+IC3CoMKgwqAgaWYgKHNtX2ktPm1haW5fc2VnbWVudHMg PD0gU01BTExfVk9MVU1FX1NFR01FTlRTKSB7Cj4+PiAtwqDCoMKgwqDCoMKgwqAgRjJGU19PUFRJ T04oc2JpKS5hbGxvY19tb2RlID0gQUxMT0NfTU9ERV9SRVVTRTsKPj4+IC3CoMKgwqDCoMKgwqDC oCBpZiAoZjJmc19ibG9ja191bml0X2Rpc2NhcmQoc2JpKSkKPj4+IC3CoMKgwqDCoMKgwqDCoMKg wqDCoMKgIHNtX2ktPmRjY19pbmZvLT5kaXNjYXJkX2dyYW51bGFyaXR5ID0gMTsKPj4+IC3CoMKg wqDCoMKgwqDCoCBzbV9pLT5pcHVfcG9saWN5ID0gMSA8PCBGMkZTX0lQVV9GT1JDRSB8Cj4+PiAt wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgMSA8PCBGMkZTX0lQVV9IT05P Ul9PUFVfV1JJVEU7Cj4+PiAtwqDCoMKgIH0KPj4+IC0KPj4+IC3CoMKgwqAgc2JpLT5yZWFkZGly X3JhID0gMTsKPj4+IC19Cj4+PiAtCj4+PiDCoCBzdGF0aWMgaW50IGYyZnNfZmlsbF9zdXBlcihz dHJ1Y3Qgc3VwZXJfYmxvY2sgKnNiLCB2b2lkICpkYXRhLCBpbnQgc2lsZW50KQo+Pj4gwqAgewo+ Pj4gwqDCoMKgwqDCoCBzdHJ1Y3QgZjJmc19zYl9pbmZvICpzYmk7Cj4+PiBAQCAtNDQ3NSw3ICs0 NDc4LDcgQEAgc3RhdGljIGludCBmMmZzX2ZpbGxfc3VwZXIoc3RydWN0IHN1cGVyX2Jsb2NrICpz Yiwgdm9pZCAqZGF0YSwgaW50IHNpbGVudCkKPj4+IMKgIMKgwqDCoMKgwqAgZjJmc19qb2luX3No cmlua2VyKHNiaSk7Cj4+PiDCoCAtwqDCoMKgIGYyZnNfdHVuaW5nX3BhcmFtZXRlcnMoc2JpKTsK Pj4+ICvCoMKgwqAgZjJmc190dW5pbmdfcGFyYW1ldGVycyhzYmksIGZhbHNlKTsKPj4+IMKgIMKg wqDCoMKgwqAgZjJmc19ub3RpY2Uoc2JpLCAiTW91bnRlZCB3aXRoIGNoZWNrcG9pbnQgdmVyc2lv biA9ICVsbHgiLAo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgY3VyX2NwX3ZlcnNpb24o RjJGU19DS1BUKHNiaSkpKTsKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpMaW51eC1mMmZzLWRldmVsIG1haWxpbmcgbGlzdApMaW51eC1mMmZzLWRldmVs QGxpc3RzLnNvdXJjZWZvcmdlLm5ldApodHRwczovL2xpc3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0 cy9saXN0aW5mby9saW51eC1mMmZzLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A088C4332F for ; Tue, 15 Nov 2022 01:24:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231351AbiKOBYL (ORCPT ); Mon, 14 Nov 2022 20:24:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229865AbiKOBYI (ORCPT ); Mon, 14 Nov 2022 20:24:08 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EBF41B1E4 for ; Mon, 14 Nov 2022 17:24:06 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 068B4B8164E for ; Tue, 15 Nov 2022 01:24:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 628AAC433D6; Tue, 15 Nov 2022 01:24:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668475443; bh=OkqUrzgA922jHYY9nyFD/fx/9c8hDaSCvzWETiK5mt8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=DL/FrX1UGUXe2nntIRUqsW4lY7h560UlQoioX1sAkLQuzDvVVP77mgBJ0CFIY2lrx pYHCVGunnhC4RV6dCnJW7OVCJIbaMw2QdetawxLW6CBlh0YFOgkaM6n5fNjtVigki5 b0Z0GNOvLsdWJCPj3PCmcAOPQ926zuV48GkSL5rC9U9altzGCnTe1VOguRU9+n3YMY ReKESOO3FZU/eUwHdS1adEikkS2XcQHBK1swf06klj7cqxQ129dWV3xcGpW4/m7Ncv jx1rqoi/qrklCMS+0hRassoKSUP0+hQQ4yLmtoIz9ULWFpjRiCO4Swaye6LkqX3BYb xHfYnbKYdMfwg== Message-ID: <29fa9df4-dc5f-a944-a150-68d34904cc91@kernel.org> Date: Tue, 15 Nov 2022 09:23:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH 1/3] f2fs: fix to alloc_mode changed after remount on a small volume device Content-Language: en-US To: Yuwei Guan , jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Yuwei.Guan@zeekrlife.com References: <20221112083250.295700-1-Yuwei.Guan@zeekrlife.com> <20221112083250.295700-2-Yuwei.Guan@zeekrlife.com> <983de611-a9e7-56d0-d375-f2b54e1f4d05@kernel.org> <7f221206-a29c-08ee-dfae-d4875bf7205d@gmail.com> From: Chao Yu In-Reply-To: <7f221206-a29c-08ee-dfae-d4875bf7205d@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/11/15 0:13, Yuwei Guan wrote: > > On 2022/11/14 22:42, Chao Yu wrote: >> On 2022/11/12 16:32, Yuwei Guan wrote: >>> The commit 84b89e5d943d8 ("f2fs: add auto tuning for small devices") add >>> tuning for small volume device, now support to tune alloce_mode to 'reuse' >>> if it's small size. But the alloc_mode will change to 'default' when do >>> remount on this small size dievce. >>> >>> The commit 4cac90d5491c9 ("f2fs: relocate readdir_ra configure >>> initialization") relocates readdir_ra variable to tuning process. >>> >>> This patch fo fix alloc_mode changed when do remount for a small volume >>> device. >>> >>> For a small device, >>> - alloc_mode will keep 'reuse', if no alloc_mode option in remount >>>    command, >>> - alloc_mode will be set as remount command, if it has 'alloc_mode='. >>> >>> Signed-off-by: Yuwei Guan >>> --- >>>   fs/f2fs/super.c | 37 ++++++++++++++++++++----------------- >>>   1 file changed, 20 insertions(+), 17 deletions(-) >>> >>> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c >>> index 3834ead04620..2f36824ff84b 100644 >>> --- a/fs/f2fs/super.c >>> +++ b/fs/f2fs/super.c >>> @@ -2190,6 +2190,23 @@ static void f2fs_enable_checkpoint(struct f2fs_sb_info *sbi) >>>       f2fs_flush_ckpt_thread(sbi); >>>   } >>>   +static void f2fs_tuning_parameters(struct f2fs_sb_info *sbi, bool is_remount) >>> +{ >>> +    struct f2fs_sm_info *sm_i = SM_I(sbi); >>> + >>> +    /* adjust parameters according to the volume size */ >>> +    if (sm_i->main_segments <= SMALL_VOLUME_SEGMENTS) { >>> +        F2FS_OPTION(sbi).alloc_mode = ALLOC_MODE_REUSE; >> >> How about moving above logic into default_options()? >> > Hi Chao, > > 'sm_i->main_segments' init in func 'f2fs_build_segment_manager()', > > when do fill super process, so it cannot move into default_options(). How about checking le32_to_cpu(raw_super->segment_count_main) directly? Thanks, > >> Thanks, >> >>> +        if (f2fs_block_unit_discard(sbi)) >>> +            sm_i->dcc_info->discard_granularity = 1; >>> +        sm_i->ipu_policy = 1 << F2FS_IPU_FORCE | >>> +                    1 << F2FS_IPU_HONOR_OPU_WRITE; >>> +    } >>> + >>> +    if (!is_remount) >>> +        sbi->readdir_ra = 1; >>> +} >>> + >>>   static int f2fs_remount(struct super_block *sb, int *flags, char *data) >>>   { >>>       struct f2fs_sb_info *sbi = F2FS_SB(sb); >>> @@ -2248,6 +2265,8 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data) >>>         default_options(sbi); >>>   +    f2fs_tuning_parameters(sbi, true); >>> + >>>       /* parse mount options */ >>>       err = parse_options(sb, data, true); >>>       if (err) >>> @@ -4054,22 +4073,6 @@ static int f2fs_setup_casefold(struct f2fs_sb_info *sbi) >>>       return 0; >>>   } >>>   -static void f2fs_tuning_parameters(struct f2fs_sb_info *sbi) >>> -{ >>> -    struct f2fs_sm_info *sm_i = SM_I(sbi); >>> - >>> -    /* adjust parameters according to the volume size */ >>> -    if (sm_i->main_segments <= SMALL_VOLUME_SEGMENTS) { >>> -        F2FS_OPTION(sbi).alloc_mode = ALLOC_MODE_REUSE; >>> -        if (f2fs_block_unit_discard(sbi)) >>> -            sm_i->dcc_info->discard_granularity = 1; >>> -        sm_i->ipu_policy = 1 << F2FS_IPU_FORCE | >>> -                    1 << F2FS_IPU_HONOR_OPU_WRITE; >>> -    } >>> - >>> -    sbi->readdir_ra = 1; >>> -} >>> - >>>   static int f2fs_fill_super(struct super_block *sb, void *data, int silent) >>>   { >>>       struct f2fs_sb_info *sbi; >>> @@ -4475,7 +4478,7 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent) >>>         f2fs_join_shrinker(sbi); >>>   -    f2fs_tuning_parameters(sbi); >>> +    f2fs_tuning_parameters(sbi, false); >>>         f2fs_notice(sbi, "Mounted with checkpoint version = %llx", >>>               cur_cp_version(F2FS_CKPT(sbi)));