From mboxrd@z Thu Jan  1 00:00:00 1970
From: Akio Takebe <takebe_akio@jp.fujitsu.com>
Subject: [Patch] cleanup pciback_reset_device
Date: Mon, 18 Dec 2006 18:21:05 +0900
Message-ID: <2AC72285D84C8Dtakebe_akio@jp.fujitsu.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="Boundary-Twz9NOco7jrMRICrCKCwN"
Return-path: <xen-devel-bounces@lists.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

--Boundary-Twz9NOco7jrMRICrCKCwN
Content-Type: text/plain; charset=iso-2022-jp
Content-Transfer-Encoding: 7bit
Content-Description: Mail message body

Hi,

This patch is for cleanup of pciback_reset_device.
is_enabled=0 and is_busmaster=0 are not necessary
because pci_disable_device() do them.

Signed-off-by: Akio Takebe <takebe_akio@jp.fujitsu.com>

diff -r c6f637694b85 linux-2.6-xen-sparse/drivers/xen/pciback/pciback_ops.c
--- a/linux-2.6-xen-sparse/drivers/xen/pciback/pciback_ops.c	Fri Dec 15 11:
53:45 2006 +0000
+++ b/linux-2.6-xen-sparse/drivers/xen/pciback/pciback_ops.c	Mon Dec 18 08:
58:43 2006 +0900
@@ -22,11 +22,7 @@ void pciback_reset_device(struct pci_dev
 	/* Disable devices (but not bridges) */
 	if (dev->hdr_type == PCI_HEADER_TYPE_NORMAL) {
 		pci_disable_device(dev);
-
 		pci_write_config_word(dev, PCI_COMMAND, 0);
-
-		dev->is_enabled = 0;
-		dev->is_busmaster = 0;
 	} else {
 		pci_read_config_word(dev, PCI_COMMAND, &cmd);
 		if (cmd & (PCI_COMMAND_INVALIDATE)) {


Best Regards,

Akio Takebe
--Boundary-Twz9NOco7jrMRICrCKCwN
Content-Type: application/octet-stream;
	name="cleanup_pciback_reset_device.patch"
Content-Disposition: attachment; filename="cleanup_pciback_reset_device.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtciBjNmY2Mzc2OTRiODUgbGludXgtMi42LXhlbi1zcGFyc2UvZHJpdmVycy94ZW4v
cGNpYmFjay9wY2liYWNrX29wcy5jCi0tLSBhL2xpbnV4LTIuNi14ZW4tc3BhcnNlL2RyaXZl
cnMveGVuL3BjaWJhY2svcGNpYmFja19vcHMuYwlGcmkgRGVjIDE1IDExOjUzOjQ1IDIwMDYg
KzAwMDAKKysrIGIvbGludXgtMi42LXhlbi1zcGFyc2UvZHJpdmVycy94ZW4vcGNpYmFjay9w
Y2liYWNrX29wcy5jCU1vbiBEZWMgMTggMDg6NTg6NDMgMjAwNiArMDkwMApAQCAtMjIsMTEg
KzIyLDcgQEAgdm9pZCBwY2liYWNrX3Jlc2V0X2RldmljZShzdHJ1Y3QgcGNpX2RldgogCS8q
IERpc2FibGUgZGV2aWNlcyAoYnV0IG5vdCBicmlkZ2VzKSAqLwogCWlmIChkZXYtPmhkcl90
eXBlID09IFBDSV9IRUFERVJfVFlQRV9OT1JNQUwpIHsKIAkJcGNpX2Rpc2FibGVfZGV2aWNl
KGRldik7Ci0KIAkJcGNpX3dyaXRlX2NvbmZpZ193b3JkKGRldiwgUENJX0NPTU1BTkQsIDAp
OwotCi0JCWRldi0+aXNfZW5hYmxlZCA9IDA7Ci0JCWRldi0+aXNfYnVzbWFzdGVyID0gMDsK
IAl9IGVsc2UgewogCQlwY2lfcmVhZF9jb25maWdfd29yZChkZXYsIFBDSV9DT01NQU5ELCAm
Y21kKTsKIAkJaWYgKGNtZCAmIChQQ0lfQ09NTUFORF9JTlZBTElEQVRFKSkgewo=

--Boundary-Twz9NOco7jrMRICrCKCwN
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--Boundary-Twz9NOco7jrMRICrCKCwN--