RE: [[PATCH v1] 4/8] net/rnp: add mbx basic api feature

["11" <caowenbo@mucse.com>]

Hi Stephen,

Thanks for your comment, as your advice that I need to define the virtual
function pointers
As the below type ?
const struct rnp_mbx_api {
..
}
If It will protect the virtual function address ,won't be remove by mistake?

Regards Wenbo
-----Original Message-----
From: Stephen Hemminger <stephen@networkplumber.org> 
Sent: 2023年8月1日 23:26
To: Wenbo Cao <caowenbo@mucse.com>
Cc: dev@dpdk.org
Subject: Re: [[PATCH v1] 4/8] net/rnp: add mbx basic api feature

On Tue,  1 Aug 2023 07:22:07 +0000
Wenbo Cao <caowenbo@mucse.com> wrote:

> +struct rnp_mbx_api {
> +	void (*init_mbx)(struct rnp_hw *hw);
> +	int32_t (*read)(struct rnp_hw *hw,
> +			uint32_t *msg,
> +			uint16_t size,
> +			enum MBX_ID);
> +	int32_t (*write)(struct rnp_hw *hw,
> +			uint32_t *msg,
> +			uint16_t size,
> +			enum MBX_ID);
> +	int32_t (*read_posted)(struct rte_eth_dev *dev,
> +			uint32_t *msg,
> +			uint16_t size,
> +			enum MBX_ID);
> +	int32_t (*write_posted)(struct rte_eth_dev *dev,
> +			uint32_t *msg,
> +			uint16_t size,
> +			enum MBX_ID);
> +	int32_t (*check_for_msg)(struct rnp_hw *hw, enum MBX_ID);
> +	int32_t (*check_for_ack)(struct rnp_hw *hw, enum MBX_ID);
> +	int32_t (*check_for_rst)(struct rnp_hw *hw, enum MBX_ID);
> +	int32_t (*configure)(struct rnp_hw *hw, int nr_vec, bool enable); };

Since this data structure only has virtual function pointers; many types of
bugs can be avoided if it can be made const.
If it const, then compiler can put the initialized table in r/o text
section.