From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F3FBC87FCA for ; Thu, 7 Aug 2025 18:08:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AB5A310E193; Thu, 7 Aug 2025 18:08:07 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="LF9TDFPl"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7016A10E193 for ; Thu, 7 Aug 2025 18:08:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1754590087; x=1786126087; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=7H1rVpWbf3l5tKQbNYZlhGFORV7o9SDgT/R+Vfl2LkU=; b=LF9TDFPlukzqPr4Pdn/coeD9l1zviwk0fXlVIaqm65K5ZF3falm3yHdW 2HqAZ2wIGCdEAEssdcVOTMHfi4hK1O45FVcOgCM801WhdPkHE1dMbtt/D ThNVrSdqwLxNdthtZjUoCd+abRtuEBK3MJ8TIqMD0sHnkic+i2CDi9uVy 8OKHP+SoZUaO4MdCjhE/d++mhVMPcQ1B6Bod1vwh0v+pY5yK6msSWJ0Mm tMCFzyoO6XGRcM6hgyk6qxBfwtpcKCnUvu1xCrAlL4QnRabGJHtxic40Y IY5OwfGYRQKTm4HdlVT0kvDJ60Rha3mlXIqzEo8c0ATR+JpFMYE2VnnR3 A==; X-CSE-ConnectionGUID: 7tUu8bX8RFS4H0jsOS9O0Q== X-CSE-MsgGUID: 4cCobkb9Q4yAKXmyhmhTCQ== X-IronPort-AV: E=McAfee;i="6800,10657,11514"; a="60784454" X-IronPort-AV: E=Sophos;i="6.17,271,1747724400"; d="scan'208";a="60784454" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2025 11:08:06 -0700 X-CSE-ConnectionGUID: d0THkmcPS0GzEri5UiCvYw== X-CSE-MsgGUID: nL/tGmBzRGCk/KzsqNUFpQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.17,271,1747724400"; d="scan'208";a="170381101" Received: from fdefranc-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.246.96]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2025 11:08:02 -0700 From: Jani Nikula To: Qianfeng Rong , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , "open list:DRM DRIVERS" , open list Cc: willy@infradead.org, Qianfeng Rong Subject: Re: [PATCH v2 1/2] drm/locking: remove redundant __GFP_NOWARN In-Reply-To: <20250807143919.575439-2-rongqianfeng@vivo.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20250807143919.575439-1-rongqianfeng@vivo.com> <20250807143919.575439-2-rongqianfeng@vivo.com> Date: Thu, 07 Aug 2025 21:07:59 +0300 Message-ID: <2a0a178a0929dc76cd88ec840d52043cd367451d@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 07 Aug 2025, Qianfeng Rong wrote: > GFP_NOWAIT already includes __GFP_NOWARN, so let's remove the redundant > __GFP_NOWARN. > > Signed-off-by: Qianfeng Rong Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/drm_modeset_lock.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_modeset_lock.c b/drivers/gpu/drm/drm_modeset_lock.c > index beb91a13a312..58eac20a8138 100644 > --- a/drivers/gpu/drm/drm_modeset_lock.c > +++ b/drivers/gpu/drm/drm_modeset_lock.c > @@ -88,7 +88,7 @@ static noinline depot_stack_handle_t __drm_stack_depot_save(void) > > n = stack_trace_save(entries, ARRAY_SIZE(entries), 1); > > - return stack_depot_save(entries, n, GFP_NOWAIT | __GFP_NOWARN); > + return stack_depot_save(entries, n, GFP_NOWAIT); > } > > static void __drm_stack_depot_print(depot_stack_handle_t stack_depot) > @@ -98,7 +98,7 @@ static void __drm_stack_depot_print(depot_stack_handle_t stack_depot) > unsigned int nr_entries; > char *buf; > > - buf = kmalloc(PAGE_SIZE, GFP_NOWAIT | __GFP_NOWARN); > + buf = kmalloc(PAGE_SIZE, GFP_NOWAIT); > if (!buf) > return; -- Jani Nikula, Intel