All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jing Liu <jing2.liu@linux.intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, jing2.liu@intel.com
Subject: Re: [PATCH RFC] kvm: x86: Expose AVX512_BF16 feature to guest
Date: Mon, 24 Jun 2019 20:06:34 +0800	[thread overview]
Message-ID: <2a2b395b-0bad-5022-9698-9beb87f55ec6@linux.intel.com> (raw)
In-Reply-To: <7d304ae7-73c0-d2a9-cd3e-975941a91266@redhat.com>

Hi Paolo,

On 6/24/2019 4:33 PM, Paolo Bonzini wrote:
> On 24/06/19 05:10, Jing Liu wrote:
>>> What do you think about @index in current function? Does it mean, we
>>> need put cpuid from index to max subleaf to @entry[i]? If so, the logic
>>> seems as follows,
>>>
>>> if (index == 0) {
>>>       // Put subleaf 0 into @entry
>>>       // Put subleaf 1 into @entry[1]
>>> } else if (index < entry->eax) {
>>>       // Put subleaf 1 into @entry
>>> } else {
>>>       // Put all zero into @entry
>>> }
>>>
>>> But this seems not identical with other cases, for current caller
>>> function. Or we can simply ignore @index in 0x07 and just put all
>>> possible subleaf info back?
> 
> There are indeed quite some cleanups to be made there.  Let me post a
> series as soon as possible, and you can base your work on it.
> 

Thanks. I just had another mail (replying you in this serial) appending
some codes to deal with case 7. If you prefer to firstly cleanup, I can
wait for the patch then. :)

Thanks,
Jing

> Paolo
> 

      reply	other threads:[~2019-06-24 12:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-20 11:21 [PATCH RFC] kvm: x86: AVX512_BF16 feature support Jing Liu
2019-06-20 11:21 ` [PATCH RFC] kvm: x86: Expose AVX512_BF16 feature to guest Jing Liu
2019-06-20 12:16   ` Paolo Bonzini
2019-06-20 15:09     ` Liu, Jing2
2019-06-24  3:10       ` Jing Liu
2019-06-24  8:33         ` Paolo Bonzini
2019-06-24 12:06           ` Jing Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a2b395b-0bad-5022-9698-9beb87f55ec6@linux.intel.com \
    --to=jing2.liu@linux.intel.com \
    --cc=jing2.liu@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.