From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82D26C4332F for ; Mon, 7 Nov 2022 17:55:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D167E806D8; Mon, 7 Nov 2022 18:55:41 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=gmx.de header.i=@gmx.de header.b="D7DkT8sb"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0AD1E84F2C; Mon, 7 Nov 2022 18:55:40 +0100 (CET) Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A9CE480079 for ; Mon, 7 Nov 2022 18:55:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1667843733; bh=ocWqThWnKUi2tECtAte2bk2Zf5aLofCrNIc5Up+P/kc=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=D7DkT8sbdj/mffBv3ygdp/23Kz6MAM93jVEE1v5km84lcbPlQiIZMCZ2CUjvY2+yh PRcr08a9l+PmsO0A5N7ReaPRM01tl5c/loSYCljpeoUGHui0CKeZwiPX81BSjhbsJh +PNtqYza6pxUg/Jdwez1mvLRqXg0TSE157xD4eZRwBRNyp0e4g0DSQ0SfULCnxbG16 8EdpYBfWor29mNSIbe6NgTXgmeUCYtSG/294K3uiItIkAhdp/G2NAdlxm9/SzAo1JU WTv3fVP3H9lFbYhHib4NucUtpnlI+fXoMWYzf2lG9cthG6cOpRfMiCvEKvO1TUPvZ3 Z7i/K+N2tcLHQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.123.67] ([84.118.157.2]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mv2xO-1p9lif2cwi-00qzaj; Mon, 07 Nov 2022 18:55:33 +0100 Message-ID: <2a363d9f-2c95-ba9c-bbc5-e9e7c66f014e@gmx.de> Date: Mon, 7 Nov 2022 18:55:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v3 1/3] efi_loader: Avoid overwriting previous outputs on console screen clearing Content-Language: en-US To: Simon Glass Cc: U-Boot Mailing List , Jan Kiszka , Ilias Apalodimas References: <4d7b7acff70af5aa5f356eac78c78addccafc787.1667549199.git.jan.kiszka@siemens.com> From: Heinrich Schuchardt In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:93uJeJ5zmd39l4c8Aw1+F7OJfBNea5lrOAQYHltDsKRPC83TfAu v3mh0C1Nvr1SCB0EYhPzujuQmAhOMfEMBnh8zYw5ggJun1xY75pR8Wqir74wcQ1TRkaBtM8 ZwwEbSsmxjmBbPc8a7AlZMpRBVHxHBDWabuvWdRV5bWGWF+BQYE0gOXnbgfzJJnm+oDXk7i uslyHhQXRswx2N0kcR6kQ== UI-OutboundReport: notjunk:1;M01:P0:Stp1R9kU3a0=;MmhgdvxpiVHnI1LweLTKymqPivS 261GRuT7pT+SbscKZ4tEA2GLoy3zsawkiNwlu9WX++o5OnniZQcxpPTuHcdgGXcBA5iyLRosh ZjfVxvYWDrpxnn2TCxXvpKloNpCQ6/eHzx8ro79tQEDKXeZVlVIXtem2kgUj8GS8yZakTvCW7 hMS5BtjlfK1wZnYxlQw79TZDtnRNqX9yPuXQ1ypssbIFcQKN+BOxBj/DLmvQkN/vhRGGphWnd bRxsHnzDofSz5GIKzemNVi77fDzpqMp7O8rQQgUwgi5cIbc7AtKoeoaOTG+XX/z0PpiH6GGHI mUniBktAYXqO8SxF46mSYHF5JbKIZLUqQOKEPeqemY/HhNMVTLLAJNXpukKEccKwQkHTlIPP/ TobzH38WliATlB9XRDpl6Dykp4Ooo5UcD/tmQsZi2FvDMXqB1mlWTXYdTteS0ipmonY142lbq eyoUN0uNczobo+w3PVfxUCXV/53J4CVAFvT7cQl7bGC1aUm/DFpbxq5mr/RqUPjFWgqJNm76w lkyeE/mBwoonCeuRR9JT+KzyErrnkgNWZyib46oDRXZ99BDzwTMlptfvuX+f6ADDlCxuD8JgK yMEXKaiMgTO6idjcUCEUeNgOObiXTGYZ/iXm3JE9T6VF45JpWyISyomBIBFl1YhfzbtXwls6v J1O6b7l0yRuqySqSOV3TosXMw3P7P+VWvEfVoyy7V6Hg03B3f0TTVZi0qEpQkeGaDj0yfspez XW6xt9JtJC+Y2LwX8nYh/QQ3m2vnGwRBIkWyAH8Ye4wO3L9R/U99IzLUkJX0fMw3JshFYA0t2 M/3kAAiKfM6GvatWV48fkv0WF1ONSNB093oIBvKZZvftVMOYyZZATvdS4wdIZswznBj+XGTvY aoQHxv4aXqKZrfTh3PkmqLJZo1MXdDfVsPdi1fR5gZDbbITDGFMXW7smNjaoLwrxZ7aWDlH31 ysdC+u4YI2pUnpt8qbbaeHxssmQ= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 11/7/22 18:32, Simon Glass wrote: > Hi Heinrich, > > On Mon, 7 Nov 2022 at 09:18, Heinrich Schuchardt wr= ote: >> >> On 11/7/22 16:28, Simon Glass wrote: >>> Hi Jan, >>> >>> On Mon, 7 Nov 2022 at 06:50, Jan Kiszka wrote= : >>>> >>>> On 04.11.22 20:08, Simon Glass wrote: >>>>> Hi, >>>>> >>>>> On Fri, 4 Nov 2022 at 02:07, Jan Kiszka wro= te: >>>>>> >>>>>> From: Jan Kiszka >>>>>> >>>>>> Before clearing the screen, ensure that no previous output of firmw= are >>>>>> or UEFI programs will be overwritten on serial devices or other >>>>>> streaming consoles. This helps generating complete boot logs. >>>>>> >>>>>> Tested regarding multi-output against qemu-x86_defconfig. >>>>>> >>>>>> Signed-off-by: Jan Kiszka >>>>>> --- >>>>>> lib/efi_loader/efi_console.c | 8 +++++++- >>>>>> 1 file changed, 7 insertions(+), 1 deletion(-) >>>>> >>>>> Please see this thread...some things need to be improved in this are= a. >>>>> >>>>> https://patchwork.ozlabs.org/project/uboot/patch/20221022092058.1060= 52-1-heinrich.schuchardt@canonical.com/ >>>>> >>>> >>>> Is there a conclusion already? Is there something that I can attach t= o >>>> to resolve this issue here? >>> >>> So far as I am concerned, there is a conclusion :) I provided a lot of >>> detail in the thread linked above. >> >> Simon, if you want to filter output on the sandbox you may do so in the >> serial driver of the sandbox. It is not related to the UEFI code. > >>>From what I can tell this problem also affects the qemu CI tests. It > seems that UEFI needs ANSI so this appears to be a UEFI thing. I > haven't actually noticed any other use of ANSI sequences in some years > of using U-Boot. Yes, you reviewed patch a085aa1f2737 ("dm: video: Add basic ANSI escape sequence support") exactly for this purpose. Both CI tests on QEMU and sandbox pass. It is good that the CI sees exactly the same output as a productive system. We should not change that. Best regards Heinrich