From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2C0EC3ABA5 for ; Tue, 29 Apr 2025 17:25:01 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u9ogs-0007cL-EQ; Tue, 29 Apr 2025 13:24:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9ogb-0007DQ-Vp for qemu-riscv@nongnu.org; Tue, 29 Apr 2025 13:24:04 -0400 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u9oga-0001ci-2g for qemu-riscv@nongnu.org; Tue, 29 Apr 2025 13:24:01 -0400 Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-afc857702d1so5960808a12.3 for ; Tue, 29 Apr 2025 10:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1745947439; x=1746552239; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cvMoAJS+2KJSxqqDURFqQVHEbL5B6ttMWi5mUtOdYqc=; b=nxbt9ECQCRyM+a9cMjKeOJIFTnJJoka6G50BoP9XaIkR6aU6HqA3Ca6TvDsQXzs+4E 1GvfJqWQ9t8cfhVIZCl8sMYG2etyCKzgvHAUsXaeHWegvgSyVAXmoF2lDoUux+mLOI5a fB/VdPywbLPEjs+/KreSPI8TiVJf8U7ZLwYNrdf/sqgF73/4ElJLRymqOAP/kexonylb 4IWoeW42rsDnjgHCzyZaPaw04ORuMe7C8gAIoPO0f5WsyrkaBXW3FTzicV5KHFK6iwUU 21FkeeNYBcC15sK6PBhRxKQ5ZBMscfhy4pGN5x/L2F/hkqKbXpMXIg7rZENqIQUOfkVj Tpkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745947439; x=1746552239; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cvMoAJS+2KJSxqqDURFqQVHEbL5B6ttMWi5mUtOdYqc=; b=iTW80LDS9PgtwDUVV0o+fsgpu2cKLPh/DbFvEgA1vnNAvCHVFwbD0kLSI9ZPF0XIzt KI+xjpk1CaBJq8OJNPr4O2CCM5u36DqWcpNyPufBJNpL4dYGng6O1tiacy2MuctcWQ84 JnRd90uZa8oB4CTuamXqm08um8aa7GQjWWlCw2k2InIwAne6hyPm6p68soF4a/VRpd1V d4wAMNqDyS1nX4UYuZYSThcPFSE/lXfuAnz/Y7zLg5mGbbgZ7CUKEXakhRu7MJsY1oAh eCYEkesQkRWXzBD4pnNICQS9kvUb/t5fjaqMiGxvNBoLlbvxfemUd2761WSWd/OJwzcQ uNQw== X-Gm-Message-State: AOJu0YwV3yKiQUGmfa1sf8StmZyoLMq440VvjEXQJO83ISsVihG16L3/ AYuZRuujHrHvlU3JE2WBm24Wxxz23d5Z+TUKu+nntMeZjbVOLVweT17hnVBtQQk= X-Gm-Gg: ASbGncuTjH6C0pL/i+H7Y7vSxq0XdGzwlmvlIcowgS6dI1pqN/8JV+TbjyQ1+ekB3gd NTZUxmXJiGAmk2cfHbN7VY3VR/+/c63r1JfKRGyNtztDv569DSCQnmh+uq4p3Cgrvx06Dhd09R5 mkHgiKuuNP7J/djxsQjD0O1s9axmRnk78XL5UskKWcO6EN0PveULraxU7M5Oy8JOkk9t3IWrrtU Rm0gpJLEHbWE7dRlzWEbWwkQt7O0xeQiLCWm4KPPwUSheV25iCWIffs2i2a5oJ1711iOZ4nvOnj HB0VUcXlTc69xLMOcJ1N49RhBwWE9OrYLECKpIxttGBjWrHtZK5iEGHToPbF02jzJA== X-Google-Smtp-Source: AGHT+IG6xyCP2ZrdV2r+5ZZCM9dkQrh7IfDMMWSiU72jFOn8AW0fNJ+CD5MLCzo4Ja2bmtNmuz3L7w== X-Received: by 2002:a17:90b:2fcb:b0:309:d115:b5f7 with SMTP id 98e67ed59e1d1-30a23e2a68dmr5585418a91.24.1745947438777; Tue, 29 Apr 2025 10:23:58 -0700 (PDT) Received: from [192.168.68.110] ([152.234.125.33]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-309f7737c88sm9694077a91.1.2025.04.29.10.23.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Apr 2025 10:23:58 -0700 (PDT) Message-ID: <2a3af577-7a82-4210-ae41-66841a47dead@ventanamicro.com> Date: Tue, 29 Apr 2025 14:23:55 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/13] hw/riscv/virt: Use setprop_sized_cells for reset To: Joel Stanley Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org References: <20250429061223.1457166-1-joel@jms.id.au> <20250429061223.1457166-10-joel@jms.id.au> Content-Language: en-US From: Daniel Henrique Barboza In-Reply-To: <20250429061223.1457166-10-joel@jms.id.au> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::52e; envelope-from=dbarboza@ventanamicro.com; helo=mail-pg1-x52e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org On 4/29/25 3:12 AM, Joel Stanley wrote: > The current device tree property uses two cells for the address (and for > the size), but assumes the they are less than 32 bits by hard coding the > high cell to zero. > > Use qemu_fdt_setprop_sized_cells to do the job of splitting the upper > and lower 32 bits across cells. > > Signed-off-by: Joel Stanley > --- Reviewed-by: Daniel Henrique Barboza > hw/riscv/virt.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c > index cf7e16cc6678..baa894b11aa6 100644 > --- a/hw/riscv/virt.c > +++ b/hw/riscv/virt.c > @@ -932,8 +932,9 @@ static void create_fdt_reset(RISCVVirtState *s, uint32_t *phandle) > qemu_fdt_setprop_string_array(ms->fdt, name, "compatible", > (char **)&compat, ARRAY_SIZE(compat)); > } > - qemu_fdt_setprop_cells(ms->fdt, name, "reg", > - 0x0, s->memmap[VIRT_TEST].base, 0x0, s->memmap[VIRT_TEST].size); > + qemu_fdt_setprop_sized_cells(ms->fdt, name, "reg", > + 2, s->memmap[VIRT_TEST].base, > + 2, s->memmap[VIRT_TEST].size); > qemu_fdt_setprop_cell(ms->fdt, name, "phandle", test_phandle); > test_phandle = qemu_fdt_get_phandle(ms->fdt, name); > g_free(name);