All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, "Jonathan Tan" <jonathantanmy@google.com>,
	"Christopher Diaz Riveros" <christopher.diaz.riv@gmail.com>,
	"Jean-Noël Avila" <jn.avila@free.fr>,
	"Daniel Santos" <hello@brighterdan.com>
Subject: Re: [PATCH] fetch-pack: add TRANSLATORS notice for packfile ready messages
Date: Mon, 15 Nov 2021 12:41:57 +0700	[thread overview]
Message-ID: <2a4428a5-91d9-a0a5-39cd-eefa1c92024e@gmail.com> (raw)
In-Reply-To: <211114.86czn3t676.gmgdl@evledraar.gmail.com>

On 14/11/21 16.50, Ævar Arnfjörð Bjarmason wrote:
> If something isn't meant to be translated do this instead:
> 
>      die(_("expected no other sections to be sent after no '%s"), "ready");
> 
> I.e. pass it as a parameter.
> 
> There can then be a "TRANSLATORS" comment that explains that it's the
> string "ready", in reference to that protocol keyword. We do it that way
> in various other places, and it completely avoids the potential problem
> of a should not be translated string being translated.
> 

Something like:
/* TRANSLATORS: The 'ready' string is the protocol keyword. Leave it
    as is. */ ?

But I have admitted that I lean to your suggestion.

-- 
An old man doll... just what I always wanted! - Clara

  reply	other threads:[~2021-11-15  5:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-14  7:31 [PATCH] fetch-pack: add TRANSLATORS notice for packfile ready messages Bagas Sanjaya
2021-11-14  9:50 ` Ævar Arnfjörð Bjarmason
2021-11-15  5:41   ` Bagas Sanjaya [this message]
2021-11-15 15:21     ` Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a4428a5-91d9-a0a5-39cd-eefa1c92024e@gmail.com \
    --to=bagasdotme@gmail.com \
    --cc=avarab@gmail.com \
    --cc=christopher.diaz.riv@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=hello@brighterdan.com \
    --cc=jn.avila@free.fr \
    --cc=jonathantanmy@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.