From: Mimi Zohar <zohar@linux.ibm.com>
To: Bradley Morgan <brads@mainlining.org>
Cc: linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
syzbot+5ebeb3089ea6439c37be@syzkaller.appspotmail.com
Subject: Re: [PATCH] ima: Check for ERR_PTR from dentry_path() in validate_hash_algo()
Date: Wed, 02 Sep 2026 08:21:36 -0400 [thread overview]
Message-ID: <2a4b80e4e1912183ba4a5d1046d718b4f455720f.camel@linux.ibm.com> (raw)
In-Reply-To: <20260827174339.1729-1-brads@mainlining.org>
On Thu, 2026-08-27 at 17:43 +0000, Bradley Morgan wrote:
> dentry_path() returns ERR_PTR(-ENAMETOOLONG) when the path exceeds the
> buffer. validate_hash_algo() passes the result straight to
> integrity_audit_msg() without checking. ERR_PTR is not NULL, so
> integrity_audit_message() sees a valid pointer and calls strlen() on
> it, which faults:
>
> BUG: unable to handle page fault for address: ffffffffffffffdc
> RIP: 0010:strlen+0x30/0xa0
> Call Trace:
> audit_log_untrustedstring+0x19/0x30
> integrity_audit_message+0x366/0x4f0
> ima_inode_setxattr+0x512/0x5f0
>
> Check for IS_ERR() and use NULL instead, which makes the audit message
> skip the name= field instead of crashing.
>
> Fixes: 4f2946aa0c45 ("IMA: introduce a new policy option func=SETXATTR_CHECK")
> Cc: stable@vger.kernel.org
> Reported-by: syzbot+5ebeb3089ea6439c37be@syzkaller.appspotmail.com
> Link: https://lore.kernel.org/all/6a8f89e5.1d9ded08.62e62.00bf.GAE@google.com/
> Signed-off-by: Bradley Morgan <brads@mainlining.org>
Thanks, Bradley. The patch is now queued in next-integrity.
Mimi
next prev parent reply other threads:[~2026-09-02 12:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 17:43 [PATCH] ima: Check for ERR_PTR from dentry_path() in validate_hash_algo() Bradley Morgan
2026-09-02 12:21 ` Mimi Zohar [this message]
2026-09-02 12:27 ` Bradley Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a4b80e4e1912183ba4a5d1046d718b4f455720f.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=brads@mainlining.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+5ebeb3089ea6439c37be@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.