From: "ismail dönmez" <ismail.donmez@gmail.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Tim Fairchild <tim@bcs4me.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: K3b and 2.6.9?
Date: Tue, 31 Aug 2004 23:16:30 +0300 [thread overview]
Message-ID: <2a4f155d04083113162c2759ea@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0408301917360.2295@ppc970.osdl.org>
On Mon, 30 Aug 2004 19:29:53 -0700 (PDT), Linus Torvalds
<torvalds@osdl.org> wrote:
> Which implies that the only way to fix it sanely is literally to have K3b
> open the device for writing, and then everything will be happy.
>
> As far as I can tell, the fix should be a simple one-liner: make sure that
> K3b opens the device with O_RDWR | O_NONBLOCK instead of using O_RDONLY |
> O_NONBLOCK. The fix looks trivial, it's in
>
> src/device/k3bdevice.cpp:
> int K3bCdDevice::openDevice( const char* name );
>
> (two places).
>
Checked k3b on CVS and it does this now :
int flags = O_NONBLOCK;
if( write )
flags |= O_RDWR;
else
flags |= O_RDONLY;
.....
fd = ::open( name, flags );
which already fixes the issue. Right?
Cheers,
ismail
--
Time is what you make of it
next prev parent reply other threads:[~2004-08-31 20:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-30 0:47 K3b and 2.6.9? Tim Fairchild
2004-08-30 13:07 ` Alan Cox
2004-08-31 1:51 ` Tim Fairchild
2004-08-31 2:29 ` Linus Torvalds
2004-08-31 6:26 ` Frank Steiner
2004-08-31 16:29 ` Linus Torvalds
2004-08-31 10:37 ` Tim Fairchild
2004-08-31 17:05 ` Linus Torvalds
2004-09-01 8:37 ` Tim Fairchild
2004-08-31 20:16 ` ismail dönmez [this message]
2004-08-31 20:33 ` Linus Torvalds
2004-08-31 22:01 ` Tim Fairchild
2004-09-01 8:27 ` Tim Fairchild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a4f155d04083113162c2759ea@mail.gmail.com \
--to=ismail.donmez@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=tim@bcs4me.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.