From: Johan Jonker <jbx6244-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/3] ARM: dts: rockchip: add missing @0 to memory nodenames
Date: Thu, 5 Mar 2020 23:21:52 +0100 [thread overview]
Message-ID: <2a5ef6fc-2487-91ef-24ce-97dd47b0a137@gmail.com> (raw)
In-Reply-To: <1784340.9KJLpVao5L@phil>
Hi Heiko,
Goal was to reduce the error output of existing code a little bit,
so that we can use it for the review of new patches.
Some questions:
As I don't have the hardware, where else is coreboot used?
Is this a rk3288-veyron.dtsi problem only?
ie. Is it a option to produce a patch serie v2 without veyron?
Can someone help testing?
Johan
On 3/5/20 10:31 PM, Heiko Stuebner wrote:
> Hi Johan,
>
> Am Mittwoch, 4. März 2020, 08:40:50 CET schrieb Johan Jonker:
>> A test with the command below gives for example this error:
>>
>> arch/arm/boot/dts/rk3288-tinker.dt.yaml: /: memory:
>> False schema does not allow
>> {'device_type': ['memory'], 'reg': [[0, 0, 0, 2147483648]]}
>>
>> The memory nodes all have a reg property that requires '@' in
>> the nodename. Fix this error by adding the missing '@0' to
>> the involved memory nodenames.
>>
>> make ARCH=arm dtbs_check
>> DT_SCHEMA_FILES=~/.local/lib/python3.5/site-packages/dtschema/
>> schemas/root-node.yaml
>
> changes to memory nodes you sadly cannot do in such an automated fashion.
> If you read the comment in rk3288-veyron.dtsi you'll see that a previous
> similar iteration broke all of those machines as their coreboot doesn't
> copy with memory@0 and would insert another memory node without @0
>
> In the past iteration the consensus then was that memory without @0
> is also ok (as it isn't changeable anyway).
>
> As I don't really want to repeat that, I'd like actual hardware tests
> before touching memory nodes.
Any suggestion/feedback rapport welcome.
>
> Heiko
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Johan Jonker <jbx6244@gmail.com>
To: Heiko Stuebner <heiko@sntech.de>, robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 2/3] ARM: dts: rockchip: add missing @0 to memory nodenames
Date: Thu, 5 Mar 2020 23:21:52 +0100 [thread overview]
Message-ID: <2a5ef6fc-2487-91ef-24ce-97dd47b0a137@gmail.com> (raw)
In-Reply-To: <1784340.9KJLpVao5L@phil>
Hi Heiko,
Goal was to reduce the error output of existing code a little bit,
so that we can use it for the review of new patches.
Some questions:
As I don't have the hardware, where else is coreboot used?
Is this a rk3288-veyron.dtsi problem only?
ie. Is it a option to produce a patch serie v2 without veyron?
Can someone help testing?
Johan
On 3/5/20 10:31 PM, Heiko Stuebner wrote:
> Hi Johan,
>
> Am Mittwoch, 4. März 2020, 08:40:50 CET schrieb Johan Jonker:
>> A test with the command below gives for example this error:
>>
>> arch/arm/boot/dts/rk3288-tinker.dt.yaml: /: memory:
>> False schema does not allow
>> {'device_type': ['memory'], 'reg': [[0, 0, 0, 2147483648]]}
>>
>> The memory nodes all have a reg property that requires '@' in
>> the nodename. Fix this error by adding the missing '@0' to
>> the involved memory nodenames.
>>
>> make ARCH=arm dtbs_check
>> DT_SCHEMA_FILES=~/.local/lib/python3.5/site-packages/dtschema/
>> schemas/root-node.yaml
>
> changes to memory nodes you sadly cannot do in such an automated fashion.
> If you read the comment in rk3288-veyron.dtsi you'll see that a previous
> similar iteration broke all of those machines as their coreboot doesn't
> copy with memory@0 and would insert another memory node without @0
>
> In the past iteration the consensus then was that memory without @0
> is also ok (as it isn't changeable anyway).
>
> As I don't really want to repeat that, I'd like actual hardware tests
> before touching memory nodes.
Any suggestion/feedback rapport welcome.
>
> Heiko
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Johan Jonker <jbx6244@gmail.com>
To: Heiko Stuebner <heiko@sntech.de>, robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ARM: dts: rockchip: add missing @0 to memory nodenames
Date: Thu, 5 Mar 2020 23:21:52 +0100 [thread overview]
Message-ID: <2a5ef6fc-2487-91ef-24ce-97dd47b0a137@gmail.com> (raw)
In-Reply-To: <1784340.9KJLpVao5L@phil>
Hi Heiko,
Goal was to reduce the error output of existing code a little bit,
so that we can use it for the review of new patches.
Some questions:
As I don't have the hardware, where else is coreboot used?
Is this a rk3288-veyron.dtsi problem only?
ie. Is it a option to produce a patch serie v2 without veyron?
Can someone help testing?
Johan
On 3/5/20 10:31 PM, Heiko Stuebner wrote:
> Hi Johan,
>
> Am Mittwoch, 4. März 2020, 08:40:50 CET schrieb Johan Jonker:
>> A test with the command below gives for example this error:
>>
>> arch/arm/boot/dts/rk3288-tinker.dt.yaml: /: memory:
>> False schema does not allow
>> {'device_type': ['memory'], 'reg': [[0, 0, 0, 2147483648]]}
>>
>> The memory nodes all have a reg property that requires '@' in
>> the nodename. Fix this error by adding the missing '@0' to
>> the involved memory nodenames.
>>
>> make ARCH=arm dtbs_check
>> DT_SCHEMA_FILES=~/.local/lib/python3.5/site-packages/dtschema/
>> schemas/root-node.yaml
>
> changes to memory nodes you sadly cannot do in such an automated fashion.
> If you read the comment in rk3288-veyron.dtsi you'll see that a previous
> similar iteration broke all of those machines as their coreboot doesn't
> copy with memory@0 and would insert another memory node without @0
>
> In the past iteration the consensus then was that memory without @0
> is also ok (as it isn't changeable anyway).
>
> As I don't really want to repeat that, I'd like actual hardware tests
> before touching memory nodes.
Any suggestion/feedback rapport welcome.
>
> Heiko
>
>
next prev parent reply other threads:[~2020-03-05 22:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 7:40 [PATCH 1/3] ARM: dts: rockchip: add missing model properties Johan Jonker
2020-03-04 7:40 ` Johan Jonker
2020-03-04 7:40 ` Johan Jonker
2020-03-04 7:40 ` [PATCH 2/3] ARM: dts: rockchip: add missing @0 to memory nodenames Johan Jonker
2020-03-04 7:40 ` Johan Jonker
[not found] ` <20200304074051.8742-2-jbx6244-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-03-05 21:31 ` Heiko Stuebner
2020-03-05 21:31 ` Heiko Stuebner
2020-03-05 21:31 ` Heiko Stuebner
2020-03-05 22:21 ` Johan Jonker [this message]
2020-03-05 22:21 ` Johan Jonker
2020-03-05 22:21 ` Johan Jonker
[not found] ` <2a5ef6fc-2487-91ef-24ce-97dd47b0a137-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-03-05 23:58 ` Heiko Stuebner
2020-03-05 23:58 ` Heiko Stuebner
2020-03-05 23:58 ` Heiko Stuebner
2020-03-13 9:47 ` Johan Jonker
2020-03-13 9:47 ` Johan Jonker
2020-03-13 9:47 ` Johan Jonker
2020-03-04 7:40 ` [PATCH 3/3] arm64: " Johan Jonker
2020-03-04 7:40 ` Johan Jonker
[not found] ` <20200304074051.8742-1-jbx6244-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-03-05 21:35 ` [PATCH 1/3] ARM: dts: rockchip: add missing model properties Heiko Stuebner
2020-03-05 21:35 ` Heiko Stuebner
2020-03-05 21:35 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a5ef6fc-2487-91ef-24ce-97dd47b0a137@gmail.com \
--to=jbx6244-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.