From: Dave Hansen <dave.hansen@intel.com>
To: Ricardo Ribalda <ribalda@chromium.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>,
Neeraj Upadhyay <neeraj.upadhyay@kernel.org>,
Joel Fernandes <joelagnelf@nvidia.com>,
Josh Triplett <josh@joshtriplett.org>,
Boqun Feng <boqun@kernel.org>,
Uladzislau Rezki <urezki@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Zqiang <qiang.zhang@linux.dev>, Thomas Gleixner <tglx@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Dan Carpenter <error27@gmail.com>
Cc: rcu@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] x86/uaccess: Fix casting in put_user
Date: Tue, 25 Aug 2026 14:06:36 -0700 [thread overview]
Message-ID: <2a772433-b0b7-44ff-a655-f8c26ee54d0e@intel.com> (raw)
In-Reply-To: <20260825-unqual-v1-2-7024fb81b4f9@chromium.org>
On 8/25/26 13:02, Ricardo Ribalda wrote:
> Recent versions of smatch preserved the address space qualifiers with
> typeof()[1].
>
> This fix has discovered an invalid casting in put_user.
>
> This patch fixes tens of smatch errors like the following:
> drivers/media/usb/uvc/uvc_v4l2.c:1112:13: warning: incorrect type in argument 2 (different address spaces)
> drivers/media/usb/uvc/uvc_v4l2.c:1112:13: expected void const *from
> drivers/media/usb/uvc/uvc_v4l2.c:1112:13: got unsigned int __user *
Could we beef up the changelog here a bit, please?
What _is_ the invalid casting?
What is the fix?
Why does it work?
next prev parent reply other threads:[~2026-08-25 21:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 20:02 [PATCH 0/2] Fix warnings with recent smatch Ricardo Ribalda
2026-08-25 20:02 ` [PATCH 1/2] rcu: Fix casting while dereferencing rcu pointers Ricardo Ribalda
2026-08-26 9:55 ` David Laight
2026-08-26 11:28 ` Ricardo Ribalda
2026-08-26 13:22 ` David Laight
2026-08-26 14:03 ` Ricardo Ribalda
2026-09-09 20:35 ` Paul E. McKenney
2026-08-25 20:02 ` [PATCH 2/2] x86/uaccess: Fix casting in put_user Ricardo Ribalda
2026-08-25 21:06 ` Dave Hansen [this message]
2026-08-25 21:15 ` Ricardo Ribalda
2026-08-25 22:38 ` Dave Hansen
2026-08-26 9:58 ` David Laight
2026-08-26 11:11 ` Ricardo Ribalda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a772433-b0b7-44ff-a655-f8c26ee54d0e@intel.com \
--to=dave.hansen@intel.com \
--cc=boqun@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=error27@gmail.com \
--cc=frederic@kernel.org \
--cc=hpa@zytor.com \
--cc=jiangshanlai@gmail.com \
--cc=joelagnelf@nvidia.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@redhat.com \
--cc=neeraj.upadhyay@kernel.org \
--cc=paulmck@kernel.org \
--cc=qiang.zhang@linux.dev \
--cc=rcu@vger.kernel.org \
--cc=ribalda@chromium.org \
--cc=rostedt@goodmis.org \
--cc=tglx@kernel.org \
--cc=urezki@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.