From: Jon Hunter <jonathanh@nvidia.com>
To: Aaron Kling <webgeek1234@gmail.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH v4 2/2] cpufreq: tegra124: Allow building as a module
Date: Wed, 14 May 2025 11:31:04 +0100 [thread overview]
Message-ID: <2acf370d-a36f-463e-87dc-2198195cc81a@nvidia.com> (raw)
In-Reply-To: <CALHNRZ_9tMi5iihyTsEuU4T72=oTQM6-rVhqozzLf9DiB_TpcA@mail.gmail.com>
On 13/05/2025 05:26, Aaron Kling wrote:
...
>>> +static void __exit tegra_cpufreq_module_exit(void)
>>> +{
>>> + if (platform_device && !IS_ERR(platform_device))
>>> + platform_device_unregister(platform_device);
>>
>> The device is unregistered in the remove. Why do we need this?
>
> These are separate things, aren't they? What's unregistered in the
> remove is the cpufreq-dt device. And what's unregistered here is the
> tegra124-cpufreq device. Not the same thing, unless I'm really missing
> something.
Thanks for the correction. OK, but I am still not sure about patch 1/2.
Jon
--
nvpublic
next prev parent reply other threads:[~2025-05-14 10:31 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-09 0:04 [PATCH v4 0/2] Support building tegra124-cpufreq as a module Aaron Kling
2025-05-09 0:04 ` Aaron Kling via B4 Relay
2025-05-09 0:04 ` [PATCH v4 1/2] cpufreq: tegra124: Remove use of disable_cpufreq Aaron Kling
2025-05-09 0:04 ` Aaron Kling via B4 Relay
2025-05-09 11:04 ` Jon Hunter
2025-05-09 16:57 ` Aaron Kling
2025-05-14 16:26 ` Aaron Kling
2025-05-19 10:17 ` Viresh Kumar
2025-05-20 9:53 ` Jon Hunter
2025-05-20 10:02 ` Viresh Kumar
2025-05-28 17:29 ` Aaron Kling
2025-05-29 5:16 ` Viresh Kumar
2025-06-05 10:34 ` Jon Hunter
2025-06-05 10:51 ` Viresh Kumar
2025-06-30 18:43 ` Aaron Kling
2025-07-01 6:23 ` Viresh Kumar
2025-05-09 0:04 ` [PATCH v4 2/2] cpufreq: tegra124: Allow building as a module Aaron Kling
2025-05-09 0:04 ` Aaron Kling via B4 Relay
2025-05-09 13:37 ` Jon Hunter
2025-05-13 4:26 ` Aaron Kling
2025-05-14 10:31 ` Jon Hunter [this message]
2025-05-14 16:43 ` Aaron Kling
2025-05-15 6:41 ` Jon Hunter
2025-05-19 10:37 ` Viresh Kumar
2025-05-20 9:57 ` Jon Hunter
2025-05-20 10:33 ` Viresh Kumar
2025-05-20 15:38 ` Aaron Kling
2025-05-14 10:31 ` Jon Hunter
2025-05-14 16:30 ` Aaron Kling
2025-05-15 6:21 ` Jon Hunter
2025-05-19 10:26 ` Viresh Kumar
2025-05-20 10:03 ` Jon Hunter
2025-05-20 10:30 ` Viresh Kumar
2025-05-20 11:46 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2acf370d-a36f-463e-87dc-2198195cc81a@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=viresh.kumar@linaro.org \
--cc=webgeek1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.