From: Rusty Bird <rustybird@openmailbox.org>
To: xen-devel@lists.xen.org
Cc: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH] tools/hotplug: Add native systemd xendriverdomain.service
Date: Thu, 07 Jul 2016 14:19:00 +0000 [thread overview]
Message-ID: <2adeb0de-a2b4-e85e-e826-0f91c075fb4b@openmailbox.org> (raw)
In-Reply-To: <20160707120436.GL416@citrix.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 775 bytes --]
Wei Liu:
> While I understand it might be necessary to have a dedicated service
> file for xendriverdomain, I can't seem to be able to figure out the
> rationale from the commit message.
>
> After thinking a bit harder, may I suggest commit message like this (and
> please correct me if I'm wrong):
>
> We need to have a dedicated service for xendriverdoamin in driver
> domain. This patch creates a service file for it. This service is only
> relevant to DomU.
>
> The service file uses ConditionVirtualization=xen becuase that evaluates
> to false in Dom0 while true in DomU, so that we only starts this service
> in DomU.
Thanks for the feedback! I've sent a v2 patch with a less cryptic commit
message that incorporates this information.
Rusty
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 931 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-07-07 14:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-03 3:33 [PATCH] tools/hotplug: Add native systemd xendriverdomain.service Rusty Bird
2016-07-07 12:04 ` Wei Liu
2016-07-07 14:19 ` Rusty Bird [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2adeb0de-a2b4-e85e-e826-0f91c075fb4b@openmailbox.org \
--to=rustybird@openmailbox.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.