From: Segher Boessenkool <segher@kernel.crashing.org>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Subject: Re: [PATCH 1/7] Implement arch disable/enable irq hooks.
Date: Wed, 30 Apr 2008 23:01:47 +0200 [thread overview]
Message-ID: <2af4cf23ed3fc48c87b50a5f63d868d7@kernel.crashing.org> (raw)
In-Reply-To: <20080430172254.GA28169@ld0162-tx32.am.freescale.net>
>> 3. The style in all the assembly code is not to have spaces after
>> commas separating instruction operands.
>
> I'll do that if that's what is prefered, but how did that come about as
> the style used? It's different from what we do in C,
But this isn't C code, it's assembler code. PowerPC assembler code
(and most other assembler code) doesn't use spaces here usually.
> and adding the
> space helps readability in asm as well...
Many people disagree ;-)
Anyway, it's better to keep a consistent style, whatever that style
is, don't you agree?
Segher
next prev parent reply other threads:[~2008-04-30 21:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-23 21:24 [PATCH 1/7] Implement arch disable/enable irq hooks Scott Wood
2007-10-23 21:24 ` [PATCH 2/7] pm: Add TLF_SLEEPING hack to delay interrupt delivery when waking from sleep Scott Wood
2007-10-23 21:24 ` [PATCH 3/7] Add 6xx-style HID0_SLEEP support Scott Wood
2007-10-23 21:24 ` [PATCH 4/7] fsl_soc: Factor fsl_get_sys_freq() out of the wdt init Scott Wood
2007-10-23 21:25 ` [PATCH 5/7] mpc83xx: Power Management support Scott Wood
2007-10-23 21:25 ` [PATCH 6/7] mpc83xx: timer driver for PM wakeup Scott Wood
2007-10-27 10:46 ` Anton Vorontsov
2007-10-23 21:25 ` [PATCH 7/7] gianfar: Add flags for magic packet and MDIO Scott Wood
2007-10-23 21:33 ` [PATCH 1/7] Implement arch disable/enable irq hooks Josh Boyer
2007-10-23 21:34 ` Scott Wood
2007-10-23 22:45 ` Josh Boyer
2007-10-25 18:01 ` Scott Wood
2008-04-25 12:57 ` Guennadi Liakhovetski
2008-04-28 20:33 ` Scott Wood
2008-04-29 4:44 ` Paul Mackerras
2008-04-29 5:04 ` Paul Mackerras
2008-04-30 10:33 ` Guennadi Liakhovetski
2008-04-30 22:17 ` Paul Mackerras
2008-04-30 17:22 ` Scott Wood
2008-04-30 21:01 ` Segher Boessenkool [this message]
2008-04-30 21:07 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2af4cf23ed3fc48c87b50a5f63d868d7@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=g.liakhovetski@gmx.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.