From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 07/10 v3] support/download: cleanup svn backend
Date: Tue, 5 Jan 2021 23:33:52 +0100 [thread overview]
Message-ID: <2b02fd2e-c977-809e-1a99-b663f061a5ee@mind.be> (raw)
In-Reply-To: <7077b14d19b9d645fa45dcc39f8c62212216c4af.1609239666.git.yann.morin.1998@free.fr>
On 29/12/2020 12:01, Yann E. MORIN wrote:
> Commit 89f5e9893 (support/download/svn: generate reproducible svn
> archives) did what it said, but can be siplified a bit.
simplified
>
> Indeed, we are doing an svn export, so we won't have any of the .svn
> directories, neither at the root of the extract, nor in any of the
> sub-directories.
>
> As such, we do not need to filter them out when we generate the list
> of files to include in the archive.
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Heiko Thiery <heiko.thiery@gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Cc: Vincent Fazio <vfazio@xes-inc.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
> ---
> support/download/svn | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/support/download/svn b/support/download/svn
> index 012f286dd9..b7a6ac7443 100755
> --- a/support/download/svn
> +++ b/support/download/svn
> @@ -46,10 +46,9 @@ _svn export ${verbose} "${@}" "'${uri}@${rev}'" "'${basename}'"
> date="$( _svn info --show-item last-changed-date "'${uri}@${rev}'" |tail -n 1 )"
>
> # Generate the archive, sort with the C locale so that it is reproducible.
> -# We do not want the .svn dir; we keep other .svn files, in case they are the
> -# only files in their directory.
> -find "${basename}" -not -type d \
> - -and -not -path "./.svn/*" >"${output}.list"
> +# We did a 'svn export' above, so it's not a working copy (there is no .svn
> +# directory or file to ignore).
> +find "${basename}" -not -type d >"${output}.list"
> LC_ALL=C sort <"${output}.list" >"${output}.list.sorted"
>
> # Create GNU-format tarballs, since that's the format of the tarballs on
>
next prev parent reply other threads:[~2021-01-05 22:33 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 11:01 [Buildroot] [PATCH 00/10 v3] support/download: reproducible archives whatever tar version (branch yem/dl-git-tar-pax-2) Yann E. MORIN
2020-12-29 11:01 ` [Buildroot] [PATCH 01/10 v3] core/pkg-infra: prepare for alternate default source archives Yann E. MORIN
2021-01-05 21:54 ` Arnout Vandecappelle
2021-01-07 19:52 ` Vincent Fazio
2020-12-29 11:01 ` [Buildroot] [PATCH 02/10 v3] core/pkg-infra: allow per site-method sub-version strings Yann E. MORIN
2021-01-05 21:58 ` Arnout Vandecappelle
2021-01-07 19:52 ` Vincent Fazio
2020-12-29 11:01 ` [Buildroot] [PATCH 03/10 v3] support/download: add helper to generate a reproducible archive Yann E. MORIN
2020-12-29 14:26 ` Vincent Fazio
2020-12-29 14:37 ` Yann E. MORIN
2021-01-05 22:05 ` Arnout Vandecappelle
2021-01-07 19:50 ` Vincent Fazio
2020-12-29 11:01 ` [Buildroot] [PATCH 04/10 v3] WIP: support/download: change format of archives generated from git Yann E. MORIN
2021-01-05 22:13 ` Arnout Vandecappelle
2021-01-09 13:45 ` Yann E. MORIN
2021-01-07 19:50 ` Vincent Fazio
2020-12-29 11:01 ` [Buildroot] [PATCH 05/10 v3] WIP: boot+packages: update hash to new git-tarballs format Yann E. MORIN
2021-01-05 22:30 ` Arnout Vandecappelle
2021-01-09 13:46 ` Yann E. MORIN
2021-01-07 19:47 ` Vincent Fazio
2020-12-29 11:01 ` [Buildroot] [PATCH 06/10 v3] WIP: support/testing: update git-hash checks with new archive format Yann E. MORIN
2021-01-05 22:32 ` Arnout Vandecappelle
2021-01-09 11:16 ` Yann E. MORIN
2021-01-07 19:46 ` Vincent Fazio
2020-12-29 11:01 ` [Buildroot] [PATCH 07/10 v3] support/download: cleanup svn backend Yann E. MORIN
2021-01-05 22:33 ` Arnout Vandecappelle [this message]
2021-01-07 19:42 ` Vincent Fazio
2020-12-29 11:01 ` [Buildroot] [PATCH 08/10 v3] support/download: change format of archives generated from svn Yann E. MORIN
2021-01-05 22:38 ` Arnout Vandecappelle
2021-01-07 19:44 ` Vincent Fazio
2020-12-29 11:01 ` [Buildroot] [PATCH 09/10 v3] support/dependencies: drop check for maximal tar version Yann E. MORIN
2021-01-05 22:41 ` Arnout Vandecappelle
2021-01-07 19:40 ` Vincent Fazio
2020-12-29 11:01 ` [Buildroot] [PATCH 10/10 v3] package/tar: drop specific version for host variant Yann E. MORIN
2021-01-05 22:46 ` Arnout Vandecappelle
2021-01-07 19:40 ` Vincent Fazio
2020-12-29 13:09 ` [Buildroot] [PATCH 00/10 v3] support/download: reproducible archives whatever tar version (branch yem/dl-git-tar-pax-2) Thomas Petazzoni
2020-12-29 13:46 ` Yann E. MORIN
2020-12-29 14:15 ` Thomas Petazzoni
2020-12-29 14:25 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b02fd2e-c977-809e-1a99-b663f061a5ee@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.