All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Li,Rongqing" <lirongqing@baidu.com>
To: Markus Elfring <Markus.Elfring@web.de>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
	"wireguard@lists.zx2c4.com" <wireguard@lists.zx2c4.com>,
	Andrew Jeffery <andrew@codeconstruct.com.au>,
	Andrew Morton <akpm@linux-foundation.org>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Arnd Bergmann <arnd@arndb.de>,
	David Hildenbrand <david@redhat.com>,
	Feng Tang <feng.tang@linux.alibaba.com>,
	Florian Westphal <fw@strlen.de>, Jakub Kicinski <kuba@kernel.org>,
	"Jason A . Donenfeld" <Jason@zx2c4.com>,
	Joel Granados <joel.granados@kernel.org>,
	Joel Stanley <joel@jms.id.au>, Jonathan Corbet <corbet@lwn.net>,
	Kees Cook <kees@kernel.org>, Lance Yang <lance.yang@linux.dev>,
	"Liam R . Howlett" <Liam.Howlett@oracle.com>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	"Paul E . McKenney" <paulmck@kernel.org>,
	Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
	"Petr Mladek" <pmladek@suse.com>, Phil Auld <pauld@redhat.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Russell King <linux@armlinux.org.uk>,
	Shuah Khan <shuah@kernel.org>, Simon Horman <horms@kernel.org>,
	Stanislav Fomichev <sdf@fomichev.me>,
	Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>
Subject: RE: [外部邮件] Re: [PATCH v3] hung_task: Panic after fixed number of hung tasks
Date: Mon, 13 Oct 2025 02:14:58 +0000	[thread overview]
Message-ID: <2b19bac7de174fe6baa07234b88c8156@baidu.com> (raw)
In-Reply-To: <0aea408f-f6d7-4e2d-8cee-1801ad7f3139@web.de>

> …
> > This patch extends the …
> 
> Will another imperative wording approach become more helpful for an
> improved change description?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Docum
> entation/process/submitting-patches.rst?h=v6.17#n94
> 

will fix in next version
> 
> …
> > +++ b/kernel/hung_task.c
> …
> @@ -229,9 +232,11 @@ static void check_hung_task(struct task_struct *t,
> unsigned long timeout) …
> >  	trace_sched_process_hang(t);
> >
> > -	if (sysctl_hung_task_panic) {
> > +	if (sysctl_hung_task_panic &&
> > +			(total_hung_task >= sysctl_hung_task_panic)) {
> …
> 
> I suggest to use the following source code variant instead.
> 
> 	if (sysctl_hung_task_panic && total_hung_task >= sysctl_hung_task_panic)
> {
> 

will fix in next version

thanks

-Li

> 
> Regards,
> Markus


  reply	other threads:[~2025-10-13  2:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-12 11:50 [PATCH][v3] hung_task: Panic after fixed number of hung tasks lirongqing
2025-10-12 13:26 ` [PATCH v3] " Markus Elfring
2025-10-13  2:14   ` Li,Rongqing [this message]
2025-10-14  1:37 ` [PATCH][v3] " Randy Dunlap
2025-10-14  2:03   ` [外部邮件] " Li,Rongqing
2025-10-14  5:23 ` Lance Yang
2025-10-14  5:33   ` [外部邮件] " Li,Rongqing
2025-10-14  9:45   ` Petr Mladek
2025-10-14 10:49     ` [????] " Li,Rongqing
2025-10-14 13:09       ` Petr Mladek
2025-10-15  2:04         ` [????] " Li,Rongqing
2025-10-14 10:59     ` Lance Yang
2025-10-14 11:18       ` [外部邮件] " Li,Rongqing
2025-10-14 11:40         ` Lance Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b19bac7de174fe6baa07234b88c8156@baidu.com \
    --to=lirongqing@baidu.com \
    --cc=Jason@zx2c4.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=Markus.Elfring@web.de \
    --cc=akpm@linux-foundation.org \
    --cc=andrew@codeconstruct.com.au \
    --cc=anshuman.khandual@arm.com \
    --cc=arnd@arndb.de \
    --cc=corbet@lwn.net \
    --cc=david@redhat.com \
    --cc=feng.tang@linux.alibaba.com \
    --cc=fw@strlen.de \
    --cc=horms@kernel.org \
    --cc=joel.granados@kernel.org \
    --cc=joel@jms.id.au \
    --cc=kees@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=lance.yang@linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mhiramat@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pauld@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=pawan.kumar.gupta@linux.intel.com \
    --cc=pmladek@suse.com \
    --cc=rdunlap@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sdf@fomichev.me \
    --cc=shuah@kernel.org \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.