From: Richard Gong <richard.gong@linux.intel.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: stratix10-svc: Drop unnecessary checking for and populating /firmware/ node
Date: Mon, 27 Apr 2020 14:12:56 -0500 [thread overview]
Message-ID: <2b2e29ec-ebbf-3ee6-acc9-3722a2fabbfb@linux.intel.com> (raw)
In-Reply-To: <20200423081149.GB18538@bogus>
Hi Sudeep,
In our dts, firmware is not under root node. You can refer to
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi for details.
This is why we need check and populate firmware node.
Regards,
Richard
On 4/23/20 3:11 AM, Sudeep Holla wrote:
> On Wed, Apr 22, 2020 at 04:50:00PM -0500, Richard Gong wrote:
>> Hi Sudeep,
>>
>> I tried and couldn't load stratix10-svc driver with your patch on kernel
>> 5.6.
>>
>
> What exactly do you mean by not loading stratix10-svc driver ?
> This patch doesn't change that part, the driver should still get loaded.
> The change may affect probing part if for some reason the devices for
> nodes under firmware are not populated which I still can't understand.
>
> Do you see any change under i/sys/devices/platform/firmware\:* with
> and without this change ?
>
> Lots of drivers removed the code similar to this patch after the Commit
> 3aa0582fdb82 ("of: platform: populate /firmware/ node from
> of_platform_default_populate_init()") and continue to work fine. I am
> interested to see what is different in stratix10-svc.
>
> --
> Regards,
> Sudeep
>
next prev parent reply other threads:[~2020-04-27 18:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 17:32 [PATCH] firmware: stratix10-svc: Drop unnecessary checking for and populating /firmware/ node Sudeep Holla
2020-04-22 21:50 ` Richard Gong
2020-04-23 8:11 ` Sudeep Holla
2020-04-27 19:12 ` Richard Gong [this message]
2020-04-28 8:32 ` Sudeep Holla
2020-04-28 14:14 ` Richard Gong
2020-04-28 14:11 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b2e29ec-ebbf-3ee6-acc9-3722a2fabbfb@linux.intel.com \
--to=richard.gong@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.