From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1876AC55174 for ; Sat, 8 Aug 2026 14:29:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aS3zNVPeeRULW1NgF/vDlvl8GPCBfObVxBjOM3ph9bA=; b=oo6l9KFaXQU2ak zZqau0BiuxlAQDAKciwJ4YKH2dtCG6Jtm5cVF4Lp5RC6dWo2bSA18qQ8jI9EN5xyffQAZiByWLGmJ yGSSCkL+XEDQn6AZiHiaU6SP3I3QpNvUeZfes1pByL7I3LzhBEX9Y9Z8vMFhtXjmGEz6I8nd4K74Q vtPH0rSIe1gAUGUA1k8Vy79qJVNdE2HoRDHY/pNttF8u2mgMh0BB+PA9ZtmXkTm6MgawrrNmpOO2b XGVJ4qh/mFvR7poPv/dshlchMTCE/FJwJogastuUpKiqMhe+LWTN2bVMCQCqguuN9fblaSERl33Gv 37S8mNMu+V9Sd8cQu2Ig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wsi3I-00000009S5a-38Rx; Sat, 08 Aug 2026 14:29:32 +0000 Received: from mail-pz2-x00.google.com ([2607:f8b0:4864:3b::]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wsi3F-00000009S4m-4AYT for linux-riscv@lists.infradead.org; Sat, 08 Aug 2026 14:29:31 +0000 Received: by mail-pz2-x00.google.com with SMTP id 41be03b00d2f7-c96739a46acso246391a12.1 for ; Sat, 08 Aug 2026 07:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786199369; x=1786804169; darn=lists.infradead.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:subject:cc:to:from:message-id:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=7CZYGhkXjoLPOZDdCP+ZBeQkJbqW9Nm3A99Ju9rkXbI=; b=iFdfmy3Hv5a1iGrOwZ0N3sqqOZojeHaW+HI/OTgZQ8Y9IPeILYRm1njJmuxFgIsJVq rBEEXTzQosCPftHdPu89k9ZywHAOfjc/nDGy+gQbK2ZXgEyh6R7rO9pfGLoosRX4Oc2T ONxPu4Jg2WTbca42jEUwzByF1DQE98+N1fT8s8AbkPBUAnroTFz00jS81p20MTo1AHga Y79CkoC7gX1RyQipMctoa5CKeK0Ym0wxvG60zSmNXpSaHNhceM4EHak2Sn72POLZ8gq0 gBvYHp4clm2F0KCFi+eMDPzky7Ixi2B+nQOs2xwlqpnMCqY0sAUmVW633OhinJyI68LS aNAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786199369; x=1786804169; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:subject:cc:to:from:message-id:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7CZYGhkXjoLPOZDdCP+ZBeQkJbqW9Nm3A99Ju9rkXbI=; b=pKFV90gJsg3/dSYxoZAQquSRPqFgyZME1I9VAWX2SI10ee+6V4IG7x5V4PLDYcdRyu IgKEIG9pmRW/n2KqyJICrOXcibbbFPUv/3maMaRkrfl/QVI7GpzwOcJSjmNK3xBC0pit ILBWVOhA2CfruL66LXeJktXiqYYdcPZQXAfRJDLU1UoqUq1nrwl7/8kKs+AGfleSB+R3 CNsfjcibv8ceev65K/koKPe8H5ZHsufONPWjowWrnxRpPDia7mJUTnoCokx5W2F/4KDH ku/PnxW6pIidcnv7UpXHx+dxEYHp3dk6p9S2uTu5KJ7achk3ZPvqyn+9Oobx6iMKOdNS BIiQ== X-Forwarded-Encrypted: i=1; AHgh+Rr727sAd1vBw/4uJBQuL27iahuWmlZegOAjIUb7Ge24IPHOt9Of+q0b9KZp1WirgUbgO6vo6d0xPsbPbw==@lists.infradead.org X-Gm-Message-State: AOJu0YwGfxsTadSNydpIUMl/2oBo295CBCYRNxzKxbRVGRE+3FK178C6 twRQuUkU6zao7X3HuTTmZrPtAQ0A/bW0e0G3UtXTXZqalpsqKLsuXyvs X-Gm-Gg: AR+sD132RgSR5pNey1G/5c34SwJGQcDTMdTdHPA8//lBK0r/d6FktmMyRPr6yrLUUGz NwF2hhKJK266t2QJr0yXN16c5rkCGBOBl9BnrvYse4NPuAi/4i6xW7i98M2PH3iL+MgJM7ZFtXC Vlt5ZJP3SlnAwhni77cB8EeuKdLVz6NyNlmjbLS5QALBxC8YYE2WZsPircm+r8H63t55KDJ9siv nvCZCH9+lPIoBMIgKn92Im7EyaSgKKnX2MgVJGDajEDgLgcLMdJAh0jF8qJl8T3wd09/s+BFiIZ +1rRO+BgYfsw++Mr/Syp75LTgXEJ8DKgY2BjPuF7GSyXdr6opkvODZYqa0UDn9zTU1J/LLnIIeo oYcZl3Y55MtPedtmZ5vqm4L/MKsgW4GwaLuVuXqOZaArGYHTukQRc3fKIWz2urP2fPeHtTaiLFN VFWXEoZt7fkphAF2QAUHC6HSiMwLNYsFz4MxJFWWU= X-Received: by 2002:a05:6a00:278b:b0:848:7b92:8e74 with SMTP id d2e1a72fcca58-84f2e0dc994mr36524222b3a.39.1786199369200; Sat, 08 Aug 2026 07:29:29 -0700 (PDT) Received: from localhost ([2403:2c80:17:1e::20db]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f5a3cad9dsm2140077b3a.23.2026.08.08.07.29.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 07:29:28 -0700 (PDT) Date: Sat, 08 Aug 2026 22:29:25 +0800 Message-ID: <2b3c661bf7e1d437f81e4b7da13be25d.codykang.hk@gmail.com> From: Cody Kang To: Rob Herring Cc: David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Vinod Koul , Neil Armstrong , Haylen Chu , Michael Turquette , Stephen Boyd , Brian Masney , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , dri-devel@lists.freedesktop.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH RESEND 04/17] dt-bindings: soc: spacemit: allow eDP/DP PHY PLL pixel clocks on K3 APMU In-Reply-To: <20260807230824.GA2220945-robh@kernel.org> References: <20260725-k3-display-v1-0-6de34d80e86c@gmail.com> <20260725-k3-display-v1-4-6de34d80e86c@gmail.com> <20260807230824.GA2220945-robh@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260808_072930_032701_DD9CA1F4 X-CRM114-Status: GOOD ( 16.90 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi Rob, On Fri, 07 Aug 2026 18:08:24 -0500, Rob Herring wrote: > On Sat, Jul 25, 2026 at 12:51:13AM -0400, Cody Kang wrote: > > The APMU's eDP pixel-clock muxes select the DP PHY PLLs as parents, so the > > K3 syscon takes two clock inputs the other variants do not have. > > > > Gate them behind the K3 compatible instead of widening the shared clock > > list, so a non-K3 syscon cannot silently accept clocks it has no mux for. > > > > Signed-off-by: Cody Kang > > --- > > .../bindings/soc/spacemit/spacemit,k1-syscon.yaml | 30 +++++++++++++++++++++- > > 1 file changed, 29 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml b/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml > > index d3a7c93c3c54..b8fc6632a392 100644 > > --- a/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml > > +++ b/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml > > @@ -31,14 +31,18 @@ properties: > > maxItems: 1 > > > > clocks: > > - maxItems: 4 > > + minItems: 4 > > + maxItems: 6 > > > > clock-names: > > + minItems: 4 > > items: > > - const: osc > > - const: vctcxo_1m > > - const: vctcxo_3m > > - const: vctcxo_24m > > + - const: edp0_pll_pxclk > > + - const: edp1_pll_pxclk > > > > "#clock-cells": > > const: 1 > > @@ -95,6 +99,30 @@ allOf: > > - clocks > > - clock-names > > - "#clock-cells" > > + # Only the K3 APMU exposes the two eDP/DP PHY PLL pixel clocks as extra > > + # inputs (parents of its eDP pixel-clock muxes); every other variant has > > + # the four base oscillator inputs only. > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: spacemit,k3-syscon-apmu > > + then: > > + properties: > > > + clocks: > > + minItems: 4 > > + maxItems: 6 > > + clock-names: > > + minItems: 4 > > + maxItems: 6 > > + else: > > + properties: > > + clocks: > > + minItems: 4 > > + maxItems: 4 > > + clock-names: > > + minItems: 4 > > + maxItems: 4 > > 4 is already the minimum, so it can be dropped on all of these. Thanks for the review. Will drop them in v2. Cody _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pz2-f1.google.com (mail-pz2-f1.google.com [74.125.228.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C20A83CE083 for ; Sat, 8 Aug 2026 14:29:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786199371; cv=none; b=go+PcXe4ALny3SKsA/0WGiJMWu4Orbvy6bqP2bReSG3plqeNFcygCvelWNFEgXdd/BIrkjrMBVaAHRy5dd0JsaxhfcAWufGBPChg2QKWJy3vBAHdAWOvPdMBqR5jXaYgC3PkLFY0YKU5Xq6kLANJmgpWWXqLXdyGMChWASqg5qg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786199371; c=relaxed/simple; bh=bptTALW6R8bnxOtse24KWu7lJf0Yrq1VbtD7l4NArTk=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=ODAND4jUIcOxCaIqCdRQD9judejOlS+LDwRI+vZdCBbQS0drNKlG0FWpALzdgdfMkkfAeazMLfbDz/7KkcXin5Ao5rrFgXAbzGxTH1Wp3YSEcbsNSX2O7h+Vu6nZVMPHKCjRwYO5viK05O5g2o33ZBZgJt18gEbOZl4MV0fPgMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Hgj2YNvZ; arc=none smtp.client-ip=74.125.228.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Hgj2YNvZ" Received: by mail-pz2-f1.google.com with SMTP id 41be03b00d2f7-cbb818e57c9so286510a12.0 for ; Sat, 08 Aug 2026 07:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786199369; x=1786804169; darn=lists.linux.dev; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:subject:cc:to:from:message-id:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=7CZYGhkXjoLPOZDdCP+ZBeQkJbqW9Nm3A99Ju9rkXbI=; b=Hgj2YNvZKRqAHCrt/Xo4KSCmivkBX9ePpR61YRvDM5Rfg2NeaOiWS5Vz41kMUh5s3t fq/hussK6HqJRTKMORZzzU/ll96Cf2CvsyQAGRPVxK0VigRG5F+6zEF1WyO3hyeJN+Gp WkHzS0xK+dkiiQQpcwXUyeIQomlzbj36Vqe/sFFrOhYVOX4KuaIQj+6+jF6xnBmUI/q+ IRGtO4AOzZNoQlnXYpx6PTzCPnD0xFqjy3PGNZsUIUYpwy6GWbqQU9B5VYlS9u0u4549 ybTDGfAakchMcVQ2s3L9gS0hMi07skwgt6bZ2zRBw2MZhzhfiGjeqQIhCHBEYLbTwByH GFUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786199369; x=1786804169; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:subject:cc:to:from:message-id:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7CZYGhkXjoLPOZDdCP+ZBeQkJbqW9Nm3A99Ju9rkXbI=; b=K63774W/KgYdugpoikVopMxG+SzpgyerS6LeLbkB4KOY0nJj00uOXYbm5knHVz/umt KX8ajESlstnoL998okyIKXVRh/L/tiIrgpZxViDkZAg2V0drGpDt4ZonCtX07iQfOUUN ByqqYqZYoQn6jSPjOrwEYhTuyOfZa/XfszC8snjspHYobPsHfEGWfJdgSHTmnGhPdzqB hKdkwkRsK4NUskSjbWk9l+yVjZXKADnZWzKae2IPsnd3jXG9ka+ifLg81F2ypQTzAKA4 0dsH7ktoMWb1KUj6m+/0xnEPQYGaFV/56Fto38PnZQesDuHJXOT9UbeU7P7rshLnMkUB QbJQ== X-Forwarded-Encrypted: i=1; AHgh+RoypmTtNe6g/iEPx6xOxNCmZop1IffbKPGrRhsLPPyttSH5AFyVENk6uXDn8CVMHZPaJi1Cm1GLcw==@lists.linux.dev X-Gm-Message-State: AOJu0YzoOxl066OBxHQ3DV+hWDzAwnqqqvJQAZnK/W3zraF/fXD6NgSz 27ucyb1piWN2xPq+oWKiL7zLD+gNMTyJOziVOo2B19jBR8lzvqdkSk5G X-Gm-Gg: AR+sD12NqZbb/rsBRCdtOAJGO7FmNQmFLhm9ndzLWNq9ZkGkJZSyoY0PdNsJpS+6bjS +KUPBqH57yLCQQ3nCNTYxRbW0fybguWY5pm7fB20HoMcxpAILZZ7GvhK4EJ141+axsf4mhSXLGb r5mHcA+UWJxIl6oZalvbhDfl1sgU+Je1trNwgjVtk7CXoE0oKIpW0ukfdV6UKkYSN2Lksw51lJ0 59D//hwWCUa3YNtWirQOrk6q6AEdP+3s9c/mYJTcNGzQkyUsuW//6ITDfnz9fBMYn2VMGuvy8Ev Gvya2GnfYBxJE6GUAo7oZ6WViRqkCttOnzYqTQjBCxleWX7cdNMkhGUJBV5q6ZXwx1dLuT93322 GQ5qK1vWJBVDscForLdNKlLRDDICwsK32Xsg5nY6CARXSCSx85POHwQ8qIhRGBuVoiYUhQFjFOJ KVb6LJEvIMduQ1Fte6j1Ljwb/OHCromSdnst+cy9M= X-Received: by 2002:a05:6a00:278b:b0:848:7b92:8e74 with SMTP id d2e1a72fcca58-84f2e0dc994mr36524222b3a.39.1786199369200; Sat, 08 Aug 2026 07:29:29 -0700 (PDT) Received: from localhost ([2403:2c80:17:1e::20db]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f5a3cad9dsm2140077b3a.23.2026.08.08.07.29.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 07:29:28 -0700 (PDT) Date: Sat, 08 Aug 2026 22:29:25 +0800 Message-ID: <2b3c661bf7e1d437f81e4b7da13be25d.codykang.hk@gmail.com> From: Cody Kang To: Rob Herring Cc: David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Vinod Koul , Neil Armstrong , Haylen Chu , Michael Turquette , Stephen Boyd , Brian Masney , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , dri-devel@lists.freedesktop.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH RESEND 04/17] dt-bindings: soc: spacemit: allow eDP/DP PHY PLL pixel clocks on K3 APMU In-Reply-To: <20260807230824.GA2220945-robh@kernel.org> References: <20260725-k3-display-v1-0-6de34d80e86c@gmail.com> <20260725-k3-display-v1-4-6de34d80e86c@gmail.com> <20260807230824.GA2220945-robh@kernel.org> Precedence: bulk X-Mailing-List: spacemit@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Hi Rob, On Fri, 07 Aug 2026 18:08:24 -0500, Rob Herring wrote: > On Sat, Jul 25, 2026 at 12:51:13AM -0400, Cody Kang wrote: > > The APMU's eDP pixel-clock muxes select the DP PHY PLLs as parents, so the > > K3 syscon takes two clock inputs the other variants do not have. > > > > Gate them behind the K3 compatible instead of widening the shared clock > > list, so a non-K3 syscon cannot silently accept clocks it has no mux for. > > > > Signed-off-by: Cody Kang > > --- > > .../bindings/soc/spacemit/spacemit,k1-syscon.yaml | 30 +++++++++++++++++++++- > > 1 file changed, 29 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml b/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml > > index d3a7c93c3c54..b8fc6632a392 100644 > > --- a/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml > > +++ b/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml > > @@ -31,14 +31,18 @@ properties: > > maxItems: 1 > > > > clocks: > > - maxItems: 4 > > + minItems: 4 > > + maxItems: 6 > > > > clock-names: > > + minItems: 4 > > items: > > - const: osc > > - const: vctcxo_1m > > - const: vctcxo_3m > > - const: vctcxo_24m > > + - const: edp0_pll_pxclk > > + - const: edp1_pll_pxclk > > > > "#clock-cells": > > const: 1 > > @@ -95,6 +99,30 @@ allOf: > > - clocks > > - clock-names > > - "#clock-cells" > > + # Only the K3 APMU exposes the two eDP/DP PHY PLL pixel clocks as extra > > + # inputs (parents of its eDP pixel-clock muxes); every other variant has > > + # the four base oscillator inputs only. > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: spacemit,k3-syscon-apmu > > + then: > > + properties: > > > + clocks: > > + minItems: 4 > > + maxItems: 6 > > + clock-names: > > + minItems: 4 > > + maxItems: 6 > > + else: > > + properties: > > + clocks: > > + minItems: 4 > > + maxItems: 4 > > + clock-names: > > + minItems: 4 > > + maxItems: 4 > > 4 is already the minimum, so it can be dropped on all of these. Thanks for the review. Will drop them in v2. Cody From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 488B6C55174 for ; Sat, 8 Aug 2026 14:29:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E+8/RZvlQgZLDqS0d5rWx1/QlNY+iuUjxA5dRsTsrXo=; b=uGDKJzX3ciWFF1 KgguiQbNULGAxj20yhpCyhp+kDnHbezc+EkOCEBayLMe7fbaBi9yW5Y9j+G/CkRGqwhLNoe5oF+lv 3elhNm7yTQFW4do/MKrYATOQdKmP+iLKGxyaecYm0Id6CJU9On7nIXlCkfJAG7sUcpl6mc/AfSlCS JVGXgZxLDvmrE67mizKolnuwTG3c9WqINk/lF78qQjJr73DUNAEZln5j1Q5Nm61Yw5XmOEaPOrORv T7U355zx61GCrFN3LO+72tp5I3y52x7l6KGJqDbFsrFg+aBKgyglkxmM/02Jway0v73njbuREs/2L dCl19xAvOJ50wfOOU+kw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wsi3I-00000009S5e-3XRQ; Sat, 08 Aug 2026 14:29:32 +0000 Received: from mail-pz2-x00.google.com ([2607:f8b0:4864:3b::]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wsi3F-00000009S4n-4ALX for linux-phy@lists.infradead.org; Sat, 08 Aug 2026 14:29:31 +0000 Received: by mail-pz2-x00.google.com with SMTP id 41be03b00d2f7-c96739a46acso246393a12.1 for ; Sat, 08 Aug 2026 07:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786199369; x=1786804169; darn=lists.infradead.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:subject:cc:to:from:message-id:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=7CZYGhkXjoLPOZDdCP+ZBeQkJbqW9Nm3A99Ju9rkXbI=; b=iFdfmy3Hv5a1iGrOwZ0N3sqqOZojeHaW+HI/OTgZQ8Y9IPeILYRm1njJmuxFgIsJVq rBEEXTzQosCPftHdPu89k9ZywHAOfjc/nDGy+gQbK2ZXgEyh6R7rO9pfGLoosRX4Oc2T ONxPu4Jg2WTbca42jEUwzByF1DQE98+N1fT8s8AbkPBUAnroTFz00jS81p20MTo1AHga Y79CkoC7gX1RyQipMctoa5CKeK0Ym0wxvG60zSmNXpSaHNhceM4EHak2Sn72POLZ8gq0 gBvYHp4clm2F0KCFi+eMDPzky7Ixi2B+nQOs2xwlqpnMCqY0sAUmVW633OhinJyI68LS aNAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786199369; x=1786804169; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:subject:cc:to:from:message-id:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7CZYGhkXjoLPOZDdCP+ZBeQkJbqW9Nm3A99Ju9rkXbI=; b=kzZu1pXTCpJL0aYOKMTRtZ2nhBbe0qaHvzFZKW1cOMbkh1bc4Fx6PpttVgGhXV5gr5 EivAEhaS41SQ32Z0yfOt9KFCq+/yJDa/gMMvCf6PV8NXnju/6M0APsP2uhJjQBSRxAmy oGmY9F/c2FBrYGmWYaDUcKXOZHLV3MaGA++dZ98u8dvcWd09GPiqbJETIp8GSO/iS8D5 +r2hQSU3/Ivmnb2wxJtua2WiNHudJeTj+sTg/5P0OzgXzpn4/+6WRam7ivWjD4MZQeRp fYSCeaXNSUXh0l6JSFk2PNQqPamYMNZAHt/0Cq9NP90TU2S+fuXb+D28ncxpbPzBqd4c kDXQ== X-Forwarded-Encrypted: i=1; AHgh+RrVfV2WAqdf/lKoWY2xPm29Im0K076C8Ke0P0X1hBcY7EYr6yTTffHjANWfVrM6UzFEzFg3CQwHFJ0=@lists.infradead.org X-Gm-Message-State: AOJu0YyKeV0mZK0Z45UJQl6n+NK685DNfcemZHt5gbCKSKo4XU1Ljt3u jZn8SNx8Z8iV0D2TVtFFkVA0Z6oPojclY6nO7+QxN6It5pb0jpCkWHMD X-Gm-Gg: AR+sD12w4WeYszZjrvkS79CGmPHVYVCAdRAvLA1pGE3w7ypO+i0H4uWodzAGZYkql8n EYKWgg2hszjse5Tb2RpYpAtj3AuI3cLm5tFV3Yxzrv4C+gTwCbcnG4ldovW0AeuB/zu+e3X4NX+ FI9J0frilAbZKkbtY/rw1tU2Y5zv1HX+smyRB3Ey5mgfql3N4YB5Zhhd0qHqiE+g2Wpi1PElLCK lDhpG6lPVSYLLy0vvWQEvPBDsp60xqYCroFzJpzB7Wi3+i/q4gvBsnWSksP3VnzCksD+ZDhShlD Cvcl3jUrT8x3DfQRpbkYb9K5PlRu3EZnez696m1e2dYYeUnlzl0JUGxsu4ZfaPsgGmIErqyYFSc W44YRzl1loMOPETA5mGPegAbt2ddZPWl8b6QhM6Lqkdn1V10k1kobjIsTKdmvZtedJNz0mPggc/ JfQPpNnhFDzR084TtdwFerhrA8RjcZ89vzBKRxLzE= X-Received: by 2002:a05:6a00:278b:b0:848:7b92:8e74 with SMTP id d2e1a72fcca58-84f2e0dc994mr36524222b3a.39.1786199369200; Sat, 08 Aug 2026 07:29:29 -0700 (PDT) Received: from localhost ([2403:2c80:17:1e::20db]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f5a3cad9dsm2140077b3a.23.2026.08.08.07.29.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 07:29:28 -0700 (PDT) Date: Sat, 08 Aug 2026 22:29:25 +0800 Message-ID: <2b3c661bf7e1d437f81e4b7da13be25d.codykang.hk@gmail.com> From: Cody Kang To: Rob Herring Cc: David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Vinod Koul , Neil Armstrong , Haylen Chu , Michael Turquette , Stephen Boyd , Brian Masney , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , dri-devel@lists.freedesktop.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH RESEND 04/17] dt-bindings: soc: spacemit: allow eDP/DP PHY PLL pixel clocks on K3 APMU In-Reply-To: <20260807230824.GA2220945-robh@kernel.org> References: <20260725-k3-display-v1-0-6de34d80e86c@gmail.com> <20260725-k3-display-v1-4-6de34d80e86c@gmail.com> <20260807230824.GA2220945-robh@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260808_072930_032780_A9DF138B X-CRM114-Status: GOOD ( 16.90 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Hi Rob, On Fri, 07 Aug 2026 18:08:24 -0500, Rob Herring wrote: > On Sat, Jul 25, 2026 at 12:51:13AM -0400, Cody Kang wrote: > > The APMU's eDP pixel-clock muxes select the DP PHY PLLs as parents, so the > > K3 syscon takes two clock inputs the other variants do not have. > > > > Gate them behind the K3 compatible instead of widening the shared clock > > list, so a non-K3 syscon cannot silently accept clocks it has no mux for. > > > > Signed-off-by: Cody Kang > > --- > > .../bindings/soc/spacemit/spacemit,k1-syscon.yaml | 30 +++++++++++++++++++++- > > 1 file changed, 29 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml b/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml > > index d3a7c93c3c54..b8fc6632a392 100644 > > --- a/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml > > +++ b/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml > > @@ -31,14 +31,18 @@ properties: > > maxItems: 1 > > > > clocks: > > - maxItems: 4 > > + minItems: 4 > > + maxItems: 6 > > > > clock-names: > > + minItems: 4 > > items: > > - const: osc > > - const: vctcxo_1m > > - const: vctcxo_3m > > - const: vctcxo_24m > > + - const: edp0_pll_pxclk > > + - const: edp1_pll_pxclk > > > > "#clock-cells": > > const: 1 > > @@ -95,6 +99,30 @@ allOf: > > - clocks > > - clock-names > > - "#clock-cells" > > + # Only the K3 APMU exposes the two eDP/DP PHY PLL pixel clocks as extra > > + # inputs (parents of its eDP pixel-clock muxes); every other variant has > > + # the four base oscillator inputs only. > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: spacemit,k3-syscon-apmu > > + then: > > + properties: > > > + clocks: > > + minItems: 4 > > + maxItems: 6 > > + clock-names: > > + minItems: 4 > > + maxItems: 6 > > + else: > > + properties: > > + clocks: > > + minItems: 4 > > + maxItems: 4 > > + clock-names: > > + minItems: 4 > > + maxItems: 4 > > 4 is already the minimum, so it can be dropped on all of these. Thanks for the review. Will drop them in v2. Cody -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy