Re: [oe] [meta-oe][kirkstone][PATCH] rocksdb: remove rocksdb_static from default PACKAGECONFIG

[Gyorgy Sarvari <skandigraun@gmail.com>]

On 4/15/26 20:20, aszh07 via lists.openembedded.org wrote:
> From: Zahir Hussain <zahir.basha@kpit.com>
> 
> In our previous commit
> https://git.openembedded.org/meta-openembedded/commit/?h=kirkstone&id=33822593e5aed47f619a385579a47c366859408a
> 
> While adding the packageconfig knob for static library generation,
> rocksdb_static was mistakenly included in the default PACKAGECONFIG list.


That was left there intentionally. We discussed that we (well, at least
I) don't want to change the default behavior of the recipe so close to
the end of the branch's supported lifetime.


> 
> Remove it from the defaults so that the static library is not built
> unless explicitly enabled by the user.
> 
> Signed-off-by: Zahir Hussain <zahir.basha@kpit.com>
> ---
>  meta-oe/recipes-dbs/rocksdb/rocksdb_6.20.3.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-oe/recipes-dbs/rocksdb/rocksdb_6.20.3.bb b/meta-oe/recipes-dbs/rocksdb/rocksdb_6.20.3.bb
> index 7bfe157c1f..7e39928bec 100644
> --- a/meta-oe/recipes-dbs/rocksdb/rocksdb_6.20.3.bb
> +++ b/meta-oe/recipes-dbs/rocksdb/rocksdb_6.20.3.bb
> @@ -31,7 +31,7 @@ S = "${WORKDIR}/git"
>  
>  inherit cmake ptest
>  
> -PACKAGECONFIG ??= "bzip2 zlib lz4 gflagsi rocksdb_static"
> +PACKAGECONFIG ??= "bzip2 zlib lz4 gflags"
>  PACKAGECONFIG[bzip2] = "-DWITH_BZ2=ON,-DWITH_BZ2=OFF,bzip2"
>  PACKAGECONFIG[lz4] = "-DWITH_LZ4=ON,-DWITH_LZ4=OFF,lz4"
>  PACKAGECONFIG[zlib] = "-DWITH_ZLIB=ON,-DWITH_ZLIB=OFF,zlib"
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#126370): https://lists.openembedded.org/g/openembedded-devel/message/126370
> Mute This Topic: https://lists.openembedded.org/mt/118845876/6084445
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [skandigraun@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>