From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80757C4332F for ; Tue, 14 Nov 2023 12:06:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232773AbjKNMG5 (ORCPT ); Tue, 14 Nov 2023 07:06:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232716AbjKNMGx (ORCPT ); Tue, 14 Nov 2023 07:06:53 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDCC9F0 for ; Tue, 14 Nov 2023 04:06:50 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3941C433C7; Tue, 14 Nov 2023 12:06:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699963610; bh=B/cuiYf3xoa7ZBqITbU7+4yaCtY4LMzTglSLKmmzqPI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Q97ZyIuqZAC5GgJUeQHnC0EOi3hcLKMDPeHFYwujSSyqNf1rawAxNOMRZ/WdL7ULF vMfH9q+PluLnpg2b/BTYVpK2lU0othBWYt8ReI1MptYEyG8cGAqPQSTiKJVdATHtyU l44zT3cgtUqOyQpyDZs97ax3uFYsjn/ybxdJITWu80esVJOI+/T/9A7uhnEeq4k+f3 1KYuNInJwVi5TBLFnMcaE1LITnBgS6CgEgojDc6Saann4TvhbjEVlbIryX8Hbnlifb EwRsE5CjcBnqYG5aWgSNBrd2eYzTbPUmyWXMz0cANIY2LnTRNqvc/GKJTZ/MOveWV9 4J2s91JF+5cww== Message-ID: <2b4c0405-064e-4e3d-8cf8-36fee1dcc687@kernel.org> Date: Tue, 14 Nov 2023 14:06:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 1/3] net: ethernet: am65-cpsw: Add standard Ethernet MAC stats to ethtool Content-Language: en-US To: Simon Horman Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, vladimir.oltean@nxp.com, s-vadapalli@ti.com, r-gunasekaran@ti.com, srk@ti.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231113110708.137379-1-rogerq@kernel.org> <20231113110708.137379-2-rogerq@kernel.org> <20231113164204.GB4482@kernel.org> From: Roger Quadros In-Reply-To: <20231113164204.GB4482@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/11/2023 18:42, Simon Horman wrote: > On Mon, Nov 13, 2023 at 01:07:06PM +0200, Roger Quadros wrote: >> Gets 'ethtool -S eth0 --groups eth-mac' command to work. >> >> Signed-off-by: Roger Quadros >> --- >> drivers/net/ethernet/ti/am65-cpsw-ethtool.c | 26 +++++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> >> diff --git a/drivers/net/ethernet/ti/am65-cpsw-ethtool.c b/drivers/net/ethernet/ti/am65-cpsw-ethtool.c >> index c51e2af91f69..ac7276f0f77a 100644 >> --- a/drivers/net/ethernet/ti/am65-cpsw-ethtool.c >> +++ b/drivers/net/ethernet/ti/am65-cpsw-ethtool.c >> @@ -662,6 +662,31 @@ static void am65_cpsw_get_ethtool_stats(struct net_device *ndev, >> hw_stats[i].offset); >> } >> >> +static void am65_cpsw_get_eth_mac_stats(struct net_device *ndev, >> + struct ethtool_eth_mac_stats *s) >> +{ >> + struct am65_cpsw_port *port = am65_ndev_to_port(ndev); >> + struct am65_cpsw_stats_regs *stats; > > Hi Roger, > > I think that stats needs an __iomem annotation > to address the issues flagged by Sparse. > > drivers/net/ethernet/ti/am65-cpsw-ethtool.c:671:15: warning: incorrect type in assignment (different address spaces) > drivers/net/ethernet/ti/am65-cpsw-ethtool.c:671:15: expected struct am65_cpsw_stats_regs *stats > drivers/net/ethernet/ti/am65-cpsw-ethtool.c:671:15: got void [noderef] __iomem *stat_base > drivers/net/ethernet/ti/am65-cpsw-ethtool.c:673:34: warning: incorrect type in argument 1 (different address spaces) > drivers/net/ethernet/ti/am65-cpsw-ethtool.c:673:34: expected void const volatile [noderef] __iomem *addr > drivers/net/ethernet/ti/am65-cpsw-ethtool.c:673:34: got unsigned int * > ... Thanks for the catch Simon. I'll fix it up. > >> + >> + stats = port->stat_base; >> + >> + s->FramesTransmittedOK = readl_relaxed(&stats->tx_good_frames); >> + s->SingleCollisionFrames = readl_relaxed(&stats->tx_single_coll_frames); >> + s->MultipleCollisionFrames = readl_relaxed(&stats->tx_mult_coll_frames); >> + s->FramesReceivedOK = readl_relaxed(&stats->rx_good_frames); >> + s->FrameCheckSequenceErrors = readl_relaxed(&stats->rx_crc_errors); >> + s->AlignmentErrors = readl_relaxed(&stats->rx_align_code_errors); >> + s->OctetsTransmittedOK = readl_relaxed(&stats->tx_octets); >> + s->FramesWithDeferredXmissions = readl_relaxed(&stats->tx_deferred_frames); >> + s->LateCollisions = readl_relaxed(&stats->tx_late_collisions); >> + s->CarrierSenseErrors = readl_relaxed(&stats->tx_carrier_sense_errors); >> + s->OctetsReceivedOK = readl_relaxed(&stats->rx_octets); >> + s->MulticastFramesXmittedOK = readl_relaxed(&stats->tx_multicast_frames); >> + s->BroadcastFramesXmittedOK = readl_relaxed(&stats->tx_broadcast_frames); >> + s->MulticastFramesReceivedOK = readl_relaxed(&stats->rx_multicast_frames); >> + s->BroadcastFramesReceivedOK = readl_relaxed(&stats->rx_broadcast_frames); >> +}; >> + >> static int am65_cpsw_get_ethtool_ts_info(struct net_device *ndev, >> struct ethtool_ts_info *info) >> { > > ... -- cheers, -roger