All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Olivain via buildroot <buildroot@buildroot.org>
To: Flaviu Nistor <flaviu.nistor@gmail.com>
Cc: James Hilliard <james.hilliard1@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] package/python-snappy: bump version to 0.7.2
Date: Mon, 20 Jul 2026 20:51:20 +0200	[thread overview]
Message-ID: <2b65947d849cb7dfcee512ef2407d2df@free.fr> (raw)
In-Reply-To: <20260720133343.10111-1-flaviu.nistor@gmail.com>

Hi Flaviu,

On 20/07/2026 15:33, Flaviu Nistor wrote:
> Hi Julien
> 
> On 18/07/2026 13:54, Julien Olivain wrote:
>> Hi Flaviu,
>> 
>> Thanks for the update.
>> 
>> On 17/07/2026 08:19, Flaviu Nistor wrote:
>>> Even if there is a 0.7.3 on Pypi, there is no 0.7.3 release
>>> on the project homepage, hence the bump to 0.7.2.
>>> Add also PYTHON_SNAPPY_SOURCE for correct package on Pypi.
>>> 
>>> Signed-off-by: Flaviu Nistor <flaviu.nistor@gmail.com>
>>> ---
>>> Changes in v2:
>>> - Fix error indicated by Julien Olivain when running make
>>> python-snappy-legal-info.
>>> - Link to v1:
>>> https://lore.kernel.org/all/20260409152520.5894-1-flaviu.nistor@gmail.com/
>>> 
>>>  package/python-snappy/python-snappy.hash | 4 ++--
>>>  package/python-snappy/python-snappy.mk   | 5 +++--
>>>  2 files changed, 5 insertions(+), 4 deletions(-)
>>> 
>> [...]
>>> diff --git a/package/python-snappy/python-snappy.mk
>>> b/package/python-snappy/python-snappy.mk
>>> index e80aa861df..b1bd8ca6ca 100644
>>> --- a/package/python-snappy/python-snappy.mk
>>> +++ b/package/python-snappy/python-snappy.mk
>>> @@ -4,8 +4,9 @@
>>>  #
>>> 
>>> ################################################################################
>>> 
>>> -PYTHON_SNAPPY_VERSION = 0.6.1
>>> -PYTHON_SNAPPY_SITE =
>>> https://files.pythonhosted.org/packages/98/7a/44a24bad98335b2c72e4cadcdecf79f50197d1bab9f22f863a274f104b96
>>> +PYTHON_SNAPPY_VERSION = 0.7.2
>> 
>> When building with the commands:
>> 
>> cat >.config <<EOF
>> BR2_aarch64=y
>> BR2_TOOLCHAIN_EXTERNAL=y
>> BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
>> BR2_PACKAGE_PYTHON3=y
>> BR2_PACKAGE_PYTHON_SNAPPY=y
>> EOF
>> make olddefconfig
>> make python-snappy
>> 
>> The build fails with the error:
>> 
>> ERROR Missing dependencies:
>>         cramjam>=2.6.0
>> 
>> It seems python-snappy was updated to switch from the snappy library
>> to cramjam, since v0.7.0:
>> https://github.com/intake/python-snappy/commit/277fb4a4b7e16b771f1ed1addde33feebd96c979
>> 
>> Cramjam is currently not included in Buildroot. So, I believe you will
>> need to add it, and update this python-snappy bump to reflect that
>> library change.
>> 
>> I also suggest you write a Buildroot runtime test to make sure
>> everything works. For the test, you can use the simple sequence
>> such as:
>> https://github.com/intake/python-snappy/blob/0.7.2/README.rst?plain=1#L50-L51
>> 
>> Could you send an updated patch series addressing those issues,
>> please?
> 
> First of all thanks a lot for the great support in guiding me and 
> patience.
> For sure I will send a new patch series addressing the isseu, as soon 
> as I have
> some time available.
> On my side, running the commands you provided fails even at installing
> toolchain-external-bootlin (2025.08-1), where look like a link can't be 
> created.
> I'll have to make this work also on my side.

The error you observe is most likely due to an "unclean" working 
directory.
I believe you will just have to do a "make clean" first, then retry with 
the
sequence I provided.

>>> +PYTHON_SNAPPY_SOURCE = python_snappy-$(PYTHON_SNAPPY_VERSION).tar.gz
>>> +PYTHON_SNAPPY_SITE =
>>> https://files.pythonhosted.org/packages/cb/52/acd87583175fa930e4385f8a6164eb5909acd683c0e62ee01d41de8195a2
>>>  PYTHON_SNAPPY_SETUP_TYPE = setuptools
>>>  PYTHON_SNAPPY_LICENSE = BSD-3-Clause
>>>  PYTHON_SNAPPY_LICENSE_FILES = LICENSE
>>> --
>>> 2.34.1
>> 
>> Best regards,
>> 
>> Julien.
> 
> Best Regards,
> Flaviu

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2026-07-20 18:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17  6:19 [Buildroot] [PATCH v2] package/python-snappy: bump version to 0.7.2 Flaviu Nistor
2026-07-18 10:54 ` Julien Olivain via buildroot
2026-07-20 13:33   ` Flaviu Nistor
2026-07-20 18:51     ` Julien Olivain via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b65947d849cb7dfcee512ef2407d2df@free.fr \
    --to=buildroot@buildroot.org \
    --cc=flaviu.nistor@gmail.com \
    --cc=james.hilliard1@gmail.com \
    --cc=ju.o@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.