On 22/04/25 6:40 pm, Madhavan Srinivasan wrote:
> Patchset handles fixes for some of the sparse
> and shellcheck warnings.
>
> Madhavan Srinivasan (6):
>    powerpc/kvm: Fix sparse warning
>    powerpc/xmon: fix sparse warning "Using plain integer as NULL pointer"
>    powerpc/perf:make isa207_pmu_format_group struct static
>    powerpc: fix sparse warnings
>    powerpc/prom_init: Fix shellcheck warnings
>    powerpc/boot/install.sh: Fix shellcheck warnings
>
>   arch/powerpc/boot/install.sh             | 14 +++++++-------
>   arch/powerpc/kernel/btext.c              |  2 +-
>   arch/powerpc/kernel/kvm.c                |  8 ++++----
>   arch/powerpc/kernel/prom_init_check.sh   | 16 ++++++++--------
>   arch/powerpc/kernel/setup-common.c       |  2 +-
>   arch/powerpc/perf/isa207-common.c        |  2 +-
>   arch/powerpc/platforms/powernv/opal.c    |  2 +-
>   arch/powerpc/platforms/pseries/lparcfg.c |  2 +-
>   arch/powerpc/xmon/ppc-opc.c              | 20 ++++++++++----------
>   9 files changed, 34 insertions(+), 34 deletions(-)
>
Tested this patch set by applying on base: 
b2accfe7ca5bc9f9af28e603b79bdd5ad8df5c0b and all the reported warnings 
are fixed. Hence for the series,


Tested-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>


For Sparse warnings please refer the attachment for before and after the 
fix.


For shellcheck warnings:


Before Patch:

In arch/powerpc/kernel/prom_init_check.sh line 92:
check_section $OBJ .init.data
               ^--^ SC2086 (info): Double quote to prevent globbing and 
word splitting.

Did you mean:
check_section "$OBJ" .init.data

For more information:
   https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent 
globbing ...




In arch/powerpc/boot/install.sh line 37:
cp $3 $4/System.map-$1
    ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
       ^-- SC2086 (info): Double quote to prevent globbing and word 
splitting.
                     ^-- SC2086 (info): Double quote to prevent globbing 
and word splitting.

Did you mean:
cp "$3" "$4"/System.map-"$1"

For more information:
   https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent 
globbing ...
   https://www.shellcheck.net/wiki/SC2006 -- Use $(...) notation instead 
of le...


After Patch:


# shellcheck arch/powerpc/kernel/prom_init_check.sh
#


# shellcheck arch/powerpc/boot/install.sh
#


Regards,

Venkat.