From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>, longli@linuxonhyperv.com
Cc: Stephen Hemminger <sthemmin@microsoft.com>,
dev@dpdk.org, Long Li <longli@microsoft.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/netvsc: fix underflow error when external mbuf are used in the receive path
Date: Thu, 9 Jul 2020 16:28:40 +0100 [thread overview]
Message-ID: <2b8a1651-2ccb-615b-7715-e6db2ee151d5@intel.com> (raw)
In-Reply-To: <20200701170646.0690c90e@hermes.lan>
On 7/2/2020 1:06 AM, Stephen Hemminger wrote:
> On Tue, 23 Jun 2020 18:11:45 -0700
> longli@linuxonhyperv.com wrote:
>
>> From: Long Li <longli@microsoft.com>
>>
>> When rte_pktmbuf_attach_extbuf() is used, the driver should not decrease the
>> reference count in its callback function hn_rx_buf_free_cb, because the
>> reference count is already decreased by rte_pktmbuf. Doing it twice may result
>> in underflow and driver may never send an ack packet over vmbus to host.
>>
>> Also declares rxbuf_outstanding as atomic, because this value is shared
>> among all receive queues.
>>
>> Signed-off-by: Long Li <longli@microsoft.com>
>
> Good catch. DPDK ought to have a real refcnt type like the kernel.
> One that traps on underflow.
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
>
Series applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2020-07-09 15:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 1:11 [dpdk-dev] [PATCH 1/2] net/netvsc: fix underflow error when external mbuf are used in the receive path longli
2020-06-24 1:11 ` [dpdk-dev] [PATCH 2/2] net/netvsc: detach external buffer on failure longli
2020-07-02 0:05 ` Stephen Hemminger
2020-07-02 0:06 ` [dpdk-dev] [PATCH 1/2] net/netvsc: fix underflow error when external mbuf are used in the receive path Stephen Hemminger
2020-07-09 15:28 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b8a1651-2ccb-615b-7715-e6db2ee151d5@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=longli@linuxonhyperv.com \
--cc=longli@microsoft.com \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.