From: Harald Freudenberger <freude@linux.ibm.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Holger Dengler <dengler@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Patrick Steuer <patrick.steuer@de.ibm.com>,
Arnd Bergmann <arnd@arndb.de>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Eric Biggers <ebiggers@kernel.org>,
Ard Biesheuvel <ardb@kernel.org>,
linux-crypto@vger.kernel.org, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390: crypto: add select CRYPTO_AEAD for aes
Date: Wed, 20 May 2026 09:47:10 +0200 [thread overview]
Message-ID: <2b9437e575689047df1624b02e18c545@linux.ibm.com> (raw)
In-Reply-To: <20260520073911.843561-1-arnd@kernel.org>
On 2026-05-20 09:38, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The aes driver registers both skcipher and aead algorithms,
> but when aead is not enabled this causes a link failure:
>
> s390-linux-ld: arch/s390/crypto/aes_s390.o: in function
> `aes_s390_fini':
> arch/s390/crypto/aes_s390.c:969:(.text+0x115e): undefined reference to
> `crypto_unregister_aead'
> s390-linux-ld: arch/s390/crypto/aes_s390.o: in function
> `aes_s390_init':
> arch/s390/crypto/aes_s390.c:1028:(.init.text+0x294): undefined
> reference to `crypto_register_aead'
>
> Add the missing 'select' statement.
>
> Fixes: bf7fa038707c ("s390/crypto: add s390 platform specific aes gcm
> support.")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/s390/crypto/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/s390/crypto/Kconfig b/arch/s390/crypto/Kconfig
> index 00051d27db95..228570a1b233 100644
> --- a/arch/s390/crypto/Kconfig
> +++ b/arch/s390/crypto/Kconfig
> @@ -4,6 +4,7 @@ menu "Accelerated Cryptographic Algorithms for CPU
> (s390)"
>
> config CRYPTO_AES_S390
> tristate "Ciphers: AES, modes: ECB, CBC, CTR, XTS, GCM"
> + select CRYPTO_AEAD
> select CRYPTO_SKCIPHER
> help
> AEAD cipher: AES with GCM
Reviewed-by: Harald Freudenberger <freude@linux.ibm.com>
next prev parent reply other threads:[~2026-05-20 7:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 7:38 [PATCH] s390: crypto: add select CRYPTO_AEAD for aes Arnd Bergmann
2026-05-20 7:47 ` Harald Freudenberger [this message]
2026-05-29 6:02 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b9437e575689047df1624b02e18c545@linux.ibm.com \
--to=freude@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=borntraeger@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=dengler@linux.ibm.com \
--cc=ebiggers@kernel.org \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=patrick.steuer@de.ibm.com \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.