From: Nilay Shroff <nilay@linux.ibm.com>
To: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org
Cc: Yu Kuai <yukuai@fnnas.com>, Guangwu Zhang <guazhang@redhat.com>
Subject: Re: [PATCH V2] block: fix race between wbt_enable_default and IO submission
Date: Fri, 12 Dec 2025 21:27:19 +0530 [thread overview]
Message-ID: <2bb0437e-7610-4da9-86a0-a95e425bb79e@linux.ibm.com> (raw)
In-Reply-To: <20251212143500.485521-1-ming.lei@redhat.com>
On 12/12/25 8:05 PM, Ming Lei wrote:
> When wbt_enable_default() is moved out of queue freezing in elevator_change(),
> it can cause the wbt inflight counter to become negative (-1), leading to hung
> tasks in the writeback path. Tasks get stuck in wbt_wait() because the counter
> is in an inconsistent state.
Looks good to me:
Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>
next prev parent reply other threads:[~2025-12-12 15:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-12 14:35 [PATCH V2] block: fix race between wbt_enable_default and IO submission Ming Lei
2025-12-12 15:57 ` Nilay Shroff [this message]
2025-12-14 9:13 ` Yu Kuai
2025-12-18 3:18 ` Ming Lei
2025-12-18 3:20 ` Jens Axboe
2025-12-18 4:41 ` Caleb Sander Mateos
2025-12-18 15:11 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bb0437e-7610-4da9-86a0-a95e425bb79e@linux.ibm.com \
--to=nilay@linux.ibm.com \
--cc=axboe@kernel.dk \
--cc=guazhang@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=yukuai@fnnas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.