All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-net v2 0/4] mptcp: fix signal endpoint readd
Date: Tue, 9 Jul 2024 11:03:07 +0200	[thread overview]
Message-ID: <2bb11954-04c6-46bf-bfc6-175709cebdd3@kernel.org> (raw)
In-Reply-To: <cover.1720211515.git.pabeni@redhat.com>

Hi Paolo,

On 05/07/2024 22:33, Paolo Abeni wrote:
> Issues/501 showed that the NL PM currently don't add corectly removal
> and re-add of signal endpoint.
> 
> Patches 1 and 2 addresses the issue, patch 3/4 introduce a related
> self-test, and the last patch address a pre-existing buglet in the
> self-test infra.
> 
> v1 -> v2:
>  - splitted the first 2 patches
>  - fixed accounting in mptcp_pm_remove_anno_addr
>  - self-tests depends on subflow_rebuild_header

Thank you for the v2, it looks good to me:

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

I will do a follow-up regarding the re-use of the same ID (if needed --
but I guess yes, because we never mark the ID as available again when we
remove a signal endpoint).

For the issue with Packetdrill, reported by the CI, I think it should be
fixed by this PR:

  https://github.com/multipath-tcp/packetdrill/pull/151

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.


  parent reply	other threads:[~2024-07-09  9:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-05 20:33 [PATCH mptcp-net v2 0/4] mptcp: fix signal endpoint readd Paolo Abeni
2024-07-05 20:33 ` [PATCH mptcp-net v2 1/4] mptcp: fix user-space PM announced address accounting Paolo Abeni
2024-07-05 20:33 ` [PATCH mptcp-net v2 2/4] mptcp: fix NL " Paolo Abeni
2024-07-05 20:33 ` [PATCH mptcp-net v2 3/4] selftests: mptcp: add explicit test case for remove/readd Paolo Abeni
2024-07-05 20:33 ` [PATCH mptcp-net v2 4/4] selftests: mptcp: fix error path Paolo Abeni
2024-07-05 21:25 ` [PATCH mptcp-net v2 0/4] mptcp: fix signal endpoint readd MPTCP CI
2024-07-09  9:03 ` Matthieu Baerts [this message]
2024-07-09  9:14 ` Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bb11954-04c6-46bf-bfc6-175709cebdd3@kernel.org \
    --to=matttbe@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.