From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans Verkuil Subject: Re: [PATCH 03/18] video/hdmi: Constify infoframe passed to the log functions Date: Fri, 21 Sep 2018 10:06:39 +0200 Message-ID: <2bb731e1-e42a-2016-cd66-bd1757ae8489@cisco.com> References: <20180920185145.1912-1-ville.syrjala@linux.intel.com> <20180920185145.1912-4-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180920185145.1912-4-ville.syrjala@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org, Hans Verkuil , linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gMDkvMjAvMTggMjA6NTEsIFZpbGxlIFN5cmphbGEgd3JvdGU6Cj4gRnJvbTogVmlsbGUgU3ly asOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBUaGUgbG9nIGZ1bmN0 aW9ucyBkb24ndCBtb2RpZnkgdGhlIHBhc3NlZCBpbiBpbmZvZnJhbWUgc28gbWFrZSBpdCBjb25z dC4KPiAKPiBDYzogVGhpZXJyeSBSZWRpbmcgPHRoaWVycnkucmVkaW5nQGdtYWlsLmNvbT4KPiBD YzogSGFucyBWZXJrdWlsIDxoYW5zLnZlcmt1aWxAY2lzY28uY29tPgoKQWNrZWQtYnk6IEhhbnMg VmVya3VpbCA8aGFucy52ZXJrdWlsQGNpc2NvLmNvbT4KClRoYW5rcywKCglIYW5zCgoKPiBDYzog bGludXgtbWVkaWFAdmdlci5rZXJuZWwub3JnCj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOk bMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy92aWRl by9oZG1pLmMgfCAyMiArKysrKysrKysrKy0tLS0tLS0tLS0tCj4gIGluY2x1ZGUvbGludXgvaGRt aS5oIHwgIDIgKy0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCAxMiBkZWxl dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy92aWRlby9oZG1pLmMgYi9kcml2ZXJz L3ZpZGVvL2hkbWkuYwo+IGluZGV4IGI1ZDQ5MTAxNGIwYi4uNTNlN2VlMmM4M2ZjIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvdmlkZW8vaGRtaS5jCj4gKysrIGIvZHJpdmVycy92aWRlby9oZG1pLmMK PiBAQCAtNDcxLDcgKzQ3MSw3IEBAIHN0YXRpYyBjb25zdCBjaGFyICpoZG1pX2luZm9mcmFtZV90 eXBlX2dldF9uYW1lKGVudW0gaGRtaV9pbmZvZnJhbWVfdHlwZSB0eXBlKQo+ICAKPiAgc3RhdGlj IHZvaWQgaGRtaV9pbmZvZnJhbWVfbG9nX2hlYWRlcihjb25zdCBjaGFyICpsZXZlbCwKPiAgCQkJ CSAgICAgIHN0cnVjdCBkZXZpY2UgKmRldiwKPiAtCQkJCSAgICAgIHN0cnVjdCBoZG1pX2FueV9p bmZvZnJhbWUgKmZyYW1lKQo+ICsJCQkJICAgICAgY29uc3Qgc3RydWN0IGhkbWlfYW55X2luZm9m cmFtZSAqZnJhbWUpCj4gIHsKPiAgCWhkbWlfbG9nKCJIRE1JIGluZm9mcmFtZTogJXMsIHZlcnNp b24gJXUsIGxlbmd0aCAldVxuIiwKPiAgCQloZG1pX2luZm9mcmFtZV90eXBlX2dldF9uYW1lKGZy YW1lLT50eXBlKSwKPiBAQCAtNjczLDEwICs2NzMsMTAgQEAgaGRtaV9jb250ZW50X3R5cGVfZ2V0 X25hbWUoZW51bSBoZG1pX2NvbnRlbnRfdHlwZSBjb250ZW50X3R5cGUpCj4gICAqLwo+ICBzdGF0 aWMgdm9pZCBoZG1pX2F2aV9pbmZvZnJhbWVfbG9nKGNvbnN0IGNoYXIgKmxldmVsLAo+ICAJCQkJ ICAgc3RydWN0IGRldmljZSAqZGV2LAo+IC0JCQkJICAgc3RydWN0IGhkbWlfYXZpX2luZm9mcmFt ZSAqZnJhbWUpCj4gKwkJCQkgICBjb25zdCBzdHJ1Y3QgaGRtaV9hdmlfaW5mb2ZyYW1lICpmcmFt ZSkKPiAgewo+ICAJaGRtaV9pbmZvZnJhbWVfbG9nX2hlYWRlcihsZXZlbCwgZGV2LAo+IC0JCQkJ ICAoc3RydWN0IGhkbWlfYW55X2luZm9mcmFtZSAqKWZyYW1lKTsKPiArCQkJCSAgKGNvbnN0IHN0 cnVjdCBoZG1pX2FueV9pbmZvZnJhbWUgKilmcmFtZSk7Cj4gIAo+ICAJaGRtaV9sb2coIiAgICBj b2xvcnNwYWNlOiAlc1xuIiwKPiAgCQkJaGRtaV9jb2xvcnNwYWNlX2dldF9uYW1lKGZyYW1lLT5j b2xvcnNwYWNlKSk7Cj4gQEAgLTc1MCwxMiArNzUwLDEyIEBAIHN0YXRpYyBjb25zdCBjaGFyICpo ZG1pX3NwZF9zZGlfZ2V0X25hbWUoZW51bSBoZG1pX3NwZF9zZGkgc2RpKQo+ICAgKi8KPiAgc3Rh dGljIHZvaWQgaGRtaV9zcGRfaW5mb2ZyYW1lX2xvZyhjb25zdCBjaGFyICpsZXZlbCwKPiAgCQkJ CSAgIHN0cnVjdCBkZXZpY2UgKmRldiwKPiAtCQkJCSAgIHN0cnVjdCBoZG1pX3NwZF9pbmZvZnJh bWUgKmZyYW1lKQo+ICsJCQkJICAgY29uc3Qgc3RydWN0IGhkbWlfc3BkX2luZm9mcmFtZSAqZnJh bWUpCj4gIHsKPiAgCXU4IGJ1ZlsxN107Cj4gIAo+ICAJaGRtaV9pbmZvZnJhbWVfbG9nX2hlYWRl cihsZXZlbCwgZGV2LAo+IC0JCQkJICAoc3RydWN0IGhkbWlfYW55X2luZm9mcmFtZSAqKWZyYW1l KTsKPiArCQkJCSAgKGNvbnN0IHN0cnVjdCBoZG1pX2FueV9pbmZvZnJhbWUgKilmcmFtZSk7Cj4g IAo+ICAJbWVtc2V0KGJ1ZiwgMCwgc2l6ZW9mKGJ1ZikpOwo+ICAKPiBAQCAtODg2LDEwICs4ODYs MTAgQEAgaGRtaV9hdWRpb19jb2RpbmdfdHlwZV9leHRfZ2V0X25hbWUoZW51bSBoZG1pX2F1ZGlv X2NvZGluZ190eXBlX2V4dCBjdHgpCj4gICAqLwo+ICBzdGF0aWMgdm9pZCBoZG1pX2F1ZGlvX2lu Zm9mcmFtZV9sb2coY29uc3QgY2hhciAqbGV2ZWwsCj4gIAkJCQkgICAgIHN0cnVjdCBkZXZpY2Ug KmRldiwKPiAtCQkJCSAgICAgc3RydWN0IGhkbWlfYXVkaW9faW5mb2ZyYW1lICpmcmFtZSkKPiAr CQkJCSAgICAgY29uc3Qgc3RydWN0IGhkbWlfYXVkaW9faW5mb2ZyYW1lICpmcmFtZSkKPiAgewo+ ICAJaGRtaV9pbmZvZnJhbWVfbG9nX2hlYWRlcihsZXZlbCwgZGV2LAo+IC0JCQkJICAoc3RydWN0 IGhkbWlfYW55X2luZm9mcmFtZSAqKWZyYW1lKTsKPiArCQkJCSAgKGNvbnN0IHN0cnVjdCBoZG1p X2FueV9pbmZvZnJhbWUgKilmcmFtZSk7Cj4gIAo+ICAJaWYgKGZyYW1lLT5jaGFubmVscykKPiAg CQloZG1pX2xvZygiICAgIGNoYW5uZWxzOiAldVxuIiwgZnJhbWUtPmNoYW5uZWxzIC0gMSk7Cj4g QEAgLTk0OSwxMiArOTQ5LDEyIEBAIGhkbWlfM2Rfc3RydWN0dXJlX2dldF9uYW1lKGVudW0gaGRt aV8zZF9zdHJ1Y3R1cmUgczNkX3N0cnVjdCkKPiAgc3RhdGljIHZvaWQKPiAgaGRtaV92ZW5kb3Jf YW55X2luZm9mcmFtZV9sb2coY29uc3QgY2hhciAqbGV2ZWwsCj4gIAkJCSAgICAgIHN0cnVjdCBk ZXZpY2UgKmRldiwKPiAtCQkJICAgICAgdW5pb24gaGRtaV92ZW5kb3JfYW55X2luZm9mcmFtZSAq ZnJhbWUpCj4gKwkJCSAgICAgIGNvbnN0IHVuaW9uIGhkbWlfdmVuZG9yX2FueV9pbmZvZnJhbWUg KmZyYW1lKQo+ICB7Cj4gLQlzdHJ1Y3QgaGRtaV92ZW5kb3JfaW5mb2ZyYW1lICpodmYgPSAmZnJh bWUtPmhkbWk7Cj4gKwljb25zdCBzdHJ1Y3QgaGRtaV92ZW5kb3JfaW5mb2ZyYW1lICpodmYgPSAm ZnJhbWUtPmhkbWk7Cj4gIAo+ICAJaGRtaV9pbmZvZnJhbWVfbG9nX2hlYWRlcihsZXZlbCwgZGV2 LAo+IC0JCQkJICAoc3RydWN0IGhkbWlfYW55X2luZm9mcmFtZSAqKWZyYW1lKTsKPiArCQkJCSAg KGNvbnN0IHN0cnVjdCBoZG1pX2FueV9pbmZvZnJhbWUgKilmcmFtZSk7Cj4gIAo+ICAJaWYgKGZy YW1lLT5hbnkub3VpICE9IEhETUlfSUVFRV9PVUkpIHsKPiAgCQloZG1pX2xvZygiICAgIG5vdCBh IEhETUkgdmVuZG9yIGluZm9mcmFtZVxuIik7Cj4gQEAgLTk4NCw3ICs5ODQsNyBAQCBoZG1pX3Zl bmRvcl9hbnlfaW5mb2ZyYW1lX2xvZyhjb25zdCBjaGFyICpsZXZlbCwKPiAgICovCj4gIHZvaWQg aGRtaV9pbmZvZnJhbWVfbG9nKGNvbnN0IGNoYXIgKmxldmVsLAo+ICAJCQlzdHJ1Y3QgZGV2aWNl ICpkZXYsCj4gLQkJCXVuaW9uIGhkbWlfaW5mb2ZyYW1lICpmcmFtZSkKPiArCQkJY29uc3QgdW5p b24gaGRtaV9pbmZvZnJhbWUgKmZyYW1lKQo+ICB7Cj4gIAlzd2l0Y2ggKGZyYW1lLT5hbnkudHlw ZSkgewo+ICAJY2FzZSBIRE1JX0lORk9GUkFNRV9UWVBFX0FWSToKPiBkaWZmIC0tZ2l0IGEvaW5j bHVkZS9saW51eC9oZG1pLmggYi9pbmNsdWRlL2xpbnV4L2hkbWkuaAo+IGluZGV4IGE1NzdkNGFl MjU3MC4uYmNlMWFiYjFmZTU3IDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvbGludXgvaGRtaS5oCj4g KysrIGIvaW5jbHVkZS9saW51eC9oZG1pLmgKPiBAQCAtMzM1LDYgKzMzNSw2IEBAIGhkbWlfaW5m b2ZyYW1lX3BhY2sodW5pb24gaGRtaV9pbmZvZnJhbWUgKmZyYW1lLCB2b2lkICpidWZmZXIsIHNp emVfdCBzaXplKTsKPiAgaW50IGhkbWlfaW5mb2ZyYW1lX3VucGFjayh1bmlvbiBoZG1pX2luZm9m cmFtZSAqZnJhbWUsCj4gIAkJCSAgY29uc3Qgdm9pZCAqYnVmZmVyLCBzaXplX3Qgc2l6ZSk7Cj4g IHZvaWQgaGRtaV9pbmZvZnJhbWVfbG9nKGNvbnN0IGNoYXIgKmxldmVsLCBzdHJ1Y3QgZGV2aWNl ICpkZXYsCj4gLQkJCXVuaW9uIGhkbWlfaW5mb2ZyYW1lICpmcmFtZSk7Cj4gKwkJCWNvbnN0IHVu aW9uIGhkbWlfaW5mb2ZyYW1lICpmcmFtZSk7Cj4gIAo+ICAjZW5kaWYgLyogX0RSTV9IRE1JX0gg Ki8KPiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from aer-iport-3.cisco.com ([173.38.203.53]:16662 "EHLO aer-iport-3.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725898AbeIUNyX (ORCPT ); Fri, 21 Sep 2018 09:54:23 -0400 Subject: Re: [PATCH 03/18] video/hdmi: Constify infoframe passed to the log functions To: Ville Syrjala , dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org, Thierry Reding , Hans Verkuil , linux-media@vger.kernel.org References: <20180920185145.1912-1-ville.syrjala@linux.intel.com> <20180920185145.1912-4-ville.syrjala@linux.intel.com> From: Hans Verkuil Message-ID: <2bb731e1-e42a-2016-cd66-bd1757ae8489@cisco.com> Date: Fri, 21 Sep 2018 10:06:39 +0200 MIME-Version: 1.0 In-Reply-To: <20180920185145.1912-4-ville.syrjala@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org List-ID: On 09/20/18 20:51, Ville Syrjala wrote: > From: Ville Syrjälä > > The log functions don't modify the passed in infoframe so make it const. > > Cc: Thierry Reding > Cc: Hans Verkuil Acked-by: Hans Verkuil Thanks, Hans > Cc: linux-media@vger.kernel.org > Signed-off-by: Ville Syrjälä > --- > drivers/video/hdmi.c | 22 +++++++++++----------- > include/linux/hdmi.h | 2 +- > 2 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c > index b5d491014b0b..53e7ee2c83fc 100644 > --- a/drivers/video/hdmi.c > +++ b/drivers/video/hdmi.c > @@ -471,7 +471,7 @@ static const char *hdmi_infoframe_type_get_name(enum hdmi_infoframe_type type) > > static void hdmi_infoframe_log_header(const char *level, > struct device *dev, > - struct hdmi_any_infoframe *frame) > + const struct hdmi_any_infoframe *frame) > { > hdmi_log("HDMI infoframe: %s, version %u, length %u\n", > hdmi_infoframe_type_get_name(frame->type), > @@ -673,10 +673,10 @@ hdmi_content_type_get_name(enum hdmi_content_type content_type) > */ > static void hdmi_avi_infoframe_log(const char *level, > struct device *dev, > - struct hdmi_avi_infoframe *frame) > + const struct hdmi_avi_infoframe *frame) > { > hdmi_infoframe_log_header(level, dev, > - (struct hdmi_any_infoframe *)frame); > + (const struct hdmi_any_infoframe *)frame); > > hdmi_log(" colorspace: %s\n", > hdmi_colorspace_get_name(frame->colorspace)); > @@ -750,12 +750,12 @@ static const char *hdmi_spd_sdi_get_name(enum hdmi_spd_sdi sdi) > */ > static void hdmi_spd_infoframe_log(const char *level, > struct device *dev, > - struct hdmi_spd_infoframe *frame) > + const struct hdmi_spd_infoframe *frame) > { > u8 buf[17]; > > hdmi_infoframe_log_header(level, dev, > - (struct hdmi_any_infoframe *)frame); > + (const struct hdmi_any_infoframe *)frame); > > memset(buf, 0, sizeof(buf)); > > @@ -886,10 +886,10 @@ hdmi_audio_coding_type_ext_get_name(enum hdmi_audio_coding_type_ext ctx) > */ > static void hdmi_audio_infoframe_log(const char *level, > struct device *dev, > - struct hdmi_audio_infoframe *frame) > + const struct hdmi_audio_infoframe *frame) > { > hdmi_infoframe_log_header(level, dev, > - (struct hdmi_any_infoframe *)frame); > + (const struct hdmi_any_infoframe *)frame); > > if (frame->channels) > hdmi_log(" channels: %u\n", frame->channels - 1); > @@ -949,12 +949,12 @@ hdmi_3d_structure_get_name(enum hdmi_3d_structure s3d_struct) > static void > hdmi_vendor_any_infoframe_log(const char *level, > struct device *dev, > - union hdmi_vendor_any_infoframe *frame) > + const union hdmi_vendor_any_infoframe *frame) > { > - struct hdmi_vendor_infoframe *hvf = &frame->hdmi; > + const struct hdmi_vendor_infoframe *hvf = &frame->hdmi; > > hdmi_infoframe_log_header(level, dev, > - (struct hdmi_any_infoframe *)frame); > + (const struct hdmi_any_infoframe *)frame); > > if (frame->any.oui != HDMI_IEEE_OUI) { > hdmi_log(" not a HDMI vendor infoframe\n"); > @@ -984,7 +984,7 @@ hdmi_vendor_any_infoframe_log(const char *level, > */ > void hdmi_infoframe_log(const char *level, > struct device *dev, > - union hdmi_infoframe *frame) > + const union hdmi_infoframe *frame) > { > switch (frame->any.type) { > case HDMI_INFOFRAME_TYPE_AVI: > diff --git a/include/linux/hdmi.h b/include/linux/hdmi.h > index a577d4ae2570..bce1abb1fe57 100644 > --- a/include/linux/hdmi.h > +++ b/include/linux/hdmi.h > @@ -335,6 +335,6 @@ hdmi_infoframe_pack(union hdmi_infoframe *frame, void *buffer, size_t size); > int hdmi_infoframe_unpack(union hdmi_infoframe *frame, > const void *buffer, size_t size); > void hdmi_infoframe_log(const char *level, struct device *dev, > - union hdmi_infoframe *frame); > + const union hdmi_infoframe *frame); > > #endif /* _DRM_HDMI_H */ >