From: Quentin Monnet <qmo@kernel.org>
To: Eduard Zingerman <eddyz87@gmail.com>,
bpf@vger.kernel.org, ast@kernel.org
Cc: andrii@kernel.org, daniel@iogearbox.net, martin.lau@linux.dev,
kernel-team@fb.com, yonghong.song@linux.dev, iii@linux.ibm.com,
gimm78064@gmail.com
Subject: Re: [PATCH bpf-next v3 1/5] bpf: do not print a newline after disassembly in bpf_verbose_insn()
Date: Mon, 3 Aug 2026 01:22:54 +0100 [thread overview]
Message-ID: <2be0a1ae-79cd-4941-8ffe-6dc70c0deb14@kernel.org> (raw)
In-Reply-To: <20260802-static-zext-v3-1-3456b2604574@gmail.com>
On 02/08/2026 21:24, Eduard Zingerman wrote:
> At the moment there are more callsites that want bpf_verbose_insn() to
> not print a newline after the instruction, than callsites that want a
> newline. Drop '\n' from disasm.c. Non-functional change.
>
> The changes in bpftool are verified by writing a bpf program using a
> variety of instructions and comparing `prog dump xlated` output in the
> following modes: plain, opcodes, visual, visual opcodes.
> The output before and after the changes is identical.
>
> Cc: Quentin Monnet <qmo@kernel.org>
> Signed-off-by: Eduard Zingerman <eddyz87@gmail.com>
Looks good, and looking at the diff, the change makes sense. Thanks!
Reviewed-by: Quentin Monnet <qmo@kernel.org>
next prev parent reply other threads:[~2026-08-03 0:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-02 20:24 [PATCH bpf-next v3 0/5] bpf: infer zext_dst based on static register liveness analysis Eduard Zingerman
2026-08-02 20:24 ` [PATCH bpf-next v3 1/5] bpf: do not print a newline after disassembly in bpf_verbose_insn() Eduard Zingerman
2026-08-03 0:22 ` Quentin Monnet [this message]
2026-08-02 20:24 ` [PATCH bpf-next v3 2/5] bpf: track upper 32-bit register halves' liveness in compute_live_registers() Eduard Zingerman
2026-08-02 20:24 ` [PATCH bpf-next v3 3/5] bpf: infer zext_dst based on static register liveness analysis Eduard Zingerman
2026-08-02 21:07 ` sashiko-bot
2026-08-02 21:14 ` Eduard Zingerman
2026-08-02 20:24 ` [PATCH bpf-next v3 4/5] bpf: simplify the bpf_is_reg64() Eduard Zingerman
2026-08-02 21:26 ` sashiko-bot
2026-08-02 21:40 ` Eduard Zingerman
2026-08-02 20:24 ` [PATCH bpf-next v3 5/5] selftests/bpf: verify zext_dst annotations for various instructions Eduard Zingerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2be0a1ae-79cd-4941-8ffe-6dc70c0deb14@kernel.org \
--to=qmo@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=gimm78064@gmail.com \
--cc=iii@linux.ibm.com \
--cc=kernel-team@fb.com \
--cc=martin.lau@linux.dev \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.