From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Du Date: Thu, 4 Jan 2024 18:22:26 +0800 (GMT+08:00) Subject: [RFC PATCH 0/3] RISC-V: KVM: Guest Debug Support In-Reply-To: <51c6e871.1f32.18c9ee3ae12.Coremail.duchao@eswincomputing.com> References: <20231221095002.7404-1-duchao@eswincomputing.com> <19434eff.1deb.18c90a3a375.Coremail.duchao@eswincomputing.com> <51c6e871.1f32.18c9ee3ae12.Coremail.duchao@eswincomputing.com> Message-ID: <2be7402e.34b.18cd3fee5ab.Coremail.duchao@eswincomputing.com> List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi all, Gentle ping. In my point of view, these patches focus on the software breakpoint of KVM Guest Debug, which are independent of the SBI extensions Anup mentioned. Please correct me if I'm wrong. Thanks, Chao On 2023-12-25 10:52, Chao Du wrote: > > On 2023-12-22 16:28, Chao Du wrote: > > > > On 2023-12-21 21:01, Anup Patel wrote: > > > > > > On Thu, Dec 21, 2023 at 3:21?PM Chao Du wrote: > > > > > > > > This series implements KVM Guest Debug on RISC-V. Currently, we can > > > > debug RISC-V KVM guest from the host side, with software breakpoints. > > > > > > > > A brief test was done on QEMU RISC-V hypervisor emulator. > > > > > > > > A TODO list which will be added later: > > > > 1. HW breakpoints support > > > > 2. Test cases > > > > > > Himanshu has already done the complete HW breakpoint implementation > > > in OpenSBI, Linux RISC-V, and KVM RISC-V. This is based on the upcoming > > > SBI debug trigger extension draft proposal. > > > (Refer, https://lists.riscv.org/g/tech-debug/message/1261) > > > > > > There are also RISE projects to track these efforts: > > > https://wiki.riseproject.dev/pages/viewpage.action?pageId=394541 > > > https://wiki.riseproject.dev/pages/viewpage.action?pageId=394545 > > > > > > Currently, we are in the process of upstreaming the OpenSBI support > > > for SBI debug trigger extension. The Linux RISC-V and KVM RISC-V > > > patches require SBI debug trigger extension and Sdtrig extension to > > > be frozen which will happen next year 2024. > > > > > > Regards, > > > Anup > > > > > > > Hi Anup, > > > > Thank you for the information and your great work on the SBI > > Debug Trigger Extension proposal. > > > > So I think that 'HW breakpoints support' in the above TODO list > > will be taken care of by Himanshu following the extension proposal. > > > > On the other hand, if I understand correctly, the software > > breakpoint part of KVM Guest Debug has no dependency on the new > > extension since it does not use the trigger module. Just an > > ebreak substitution is made. > > > > So may I know your suggestion about this RFC? Both in KVM and QEMU. > > > > Regards, > > Chao > > > > Hi Anup and all, > > I'm still waiting for your comment and suggestion for the next step. > :) > > Thanks > > > > > > > > > This series is based on Linux 6.7-rc6 and is also available at: > > > > https://github.com/Du-Chao/linux/tree/riscv_gd_sw > > > > > > > > The matched QEMU is available at: > > > > https://github.com/Du-Chao/qemu/tree/riscv_gd_sw > > > > > > > > Chao Du (3): > > > > RISC-V: KVM: Enable the KVM_CAP_SET_GUEST_DEBUG capability > > > > RISC-V: KVM: Implement kvm_arch_vcpu_ioctl_set_guest_debug() > > > > RISC-V: KVM: Handle breakpoint exits for VCPU > > > > > > > > arch/riscv/include/uapi/asm/kvm.h | 1 + > > > > arch/riscv/kvm/vcpu.c | 15 +++++++++++++-- > > > > arch/riscv/kvm/vcpu_exit.c | 4 ++++ > > > > arch/riscv/kvm/vm.c | 1 + > > > > 4 files changed, 19 insertions(+), 2 deletions(-) > > > > > > > > -- > > > > 2.17.1 > > > > > > > > > > > > -- > > > > kvm-riscv mailing list > > > > kvm-riscv at lists.infradead.org > > > > http://lists.infradead.org/mailman/listinfo/kvm-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from zg8tndyumtaxlji0oc4xnzya.icoremail.net (zg8tndyumtaxlji0oc4xnzya.icoremail.net [46.101.248.176]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6516E20B16 for ; Thu, 4 Jan 2024 10:24:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=eswincomputing.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=eswincomputing.com Received: from duchao$eswincomputing.com ( [123.139.59.82] ) by ajax-webmail-app2 (Coremail) ; Thu, 4 Jan 2024 18:22:26 +0800 (GMT+08:00) Date: Thu, 4 Jan 2024 18:22:26 +0800 (GMT+08:00) X-CM-HeaderCharset: UTF-8 From: "Chao Du" To: "Anup Patel" Cc: kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, anup@brainfault.org, atishp@atishpatra.org, dbarboza@ventanamicro.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu Subject: Re: [RFC PATCH 0/3] RISC-V: KVM: Guest Debug Support X-Priority: 3 X-Mailer: Coremail Webmail Server Version XT6.0.3 build 20220420(169d3f8c) Copyright (c) 2002-2024 www.mailtech.cn mispb-72143050-eaf5-4703-89e0-86624513b4ce-eswincomputing.com In-Reply-To: <51c6e871.1f32.18c9ee3ae12.Coremail.duchao@eswincomputing.com> References: <20231221095002.7404-1-duchao@eswincomputing.com> <19434eff.1deb.18c90a3a375.Coremail.duchao@eswincomputing.com> <51c6e871.1f32.18c9ee3ae12.Coremail.duchao@eswincomputing.com> Content-Transfer-Encoding: base64 Content-Type: text/plain; charset=UTF-8 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <2be7402e.34b.18cd3fee5ab.Coremail.duchao@eswincomputing.com> X-Coremail-Locale: en_US X-CM-TRANSID:TQJkCgDHVdTihpZlT14EAA--.3989W X-CM-SenderInfo: xgxfxt3r6h245lqf0zpsxwx03jof0z/1tbiAgEGDGWVfiwd9gAAsA X-Coremail-Antispam: 1Ur529EdanIXcx71UUUUU7IcSsGvfJ3iIAIbVAYjsxI4VWxJw CS07vEb4IE77IF4wCS07vE1I0E4x80FVAKz4kxMIAIbVAFxVCaYxvI4VCIwcAKzIAtYxBI daVFxhVjvjDU= SGkgYWxsLAoKR2VudGxlIHBpbmcuCgpJbiBteSBwb2ludCBvZiB2aWV3LCB0aGVzZSBwYXRjaGVz IGZvY3VzIG9uIHRoZSBzb2Z0d2FyZSBicmVha3BvaW50Cm9mIEtWTSBHdWVzdCBEZWJ1Zywgd2hp Y2ggYXJlIGluZGVwZW5kZW50IG9mIHRoZSBTQkkgZXh0ZW5zaW9ucyBBbnVwCm1lbnRpb25lZC4K ClBsZWFzZSBjb3JyZWN0IG1lIGlmIEknbSB3cm9uZy4KClRoYW5rcywKQ2hhbwoKT24gMjAyMy0x Mi0yNSAxMDo1MiwgQ2hhbyBEdSA8ZHVjaGFvQGVzd2luY29tcHV0aW5nLmNvbT4gd3JvdGU6Cj4g Cj4gT24gMjAyMy0xMi0yMiAxNjoyOCwgQ2hhbyBEdSA8ZHVjaGFvQGVzd2luY29tcHV0aW5nLmNv bT4gd3JvdGU6Cj4gPiAKPiA+IE9uIDIwMjMtMTItMjEgMjE6MDEsIEFudXAgUGF0ZWwgPGFwYXRl bEB2ZW50YW5hbWljcm8uY29tPiB3cm90ZToKPiA+ID4gCj4gPiA+IE9uIFRodSwgRGVjIDIxLCAy MDIzIGF0IDM6MjHigK9QTSBDaGFvIER1IDxkdWNoYW9AZXN3aW5jb21wdXRpbmcuY29tPiB3cm90 ZToKPiA+ID4gPgo+ID4gPiA+IFRoaXMgc2VyaWVzIGltcGxlbWVudHMgS1ZNIEd1ZXN0IERlYnVn IG9uIFJJU0MtVi4gQ3VycmVudGx5LCB3ZSBjYW4KPiA+ID4gPiBkZWJ1ZyBSSVNDLVYgS1ZNIGd1 ZXN0IGZyb20gdGhlIGhvc3Qgc2lkZSwgd2l0aCBzb2Z0d2FyZSBicmVha3BvaW50cy4KPiA+ID4g Pgo+ID4gPiA+IEEgYnJpZWYgdGVzdCB3YXMgZG9uZSBvbiBRRU1VIFJJU0MtViBoeXBlcnZpc29y IGVtdWxhdG9yLgo+ID4gPiA+Cj4gPiA+ID4gQSBUT0RPIGxpc3Qgd2hpY2ggd2lsbCBiZSBhZGRl ZCBsYXRlcjoKPiA+ID4gPiAxLiBIVyBicmVha3BvaW50cyBzdXBwb3J0Cj4gPiA+ID4gMi4gVGVz dCBjYXNlcwo+ID4gPiAKPiA+ID4gSGltYW5zaHUgaGFzIGFscmVhZHkgZG9uZSB0aGUgY29tcGxl dGUgSFcgYnJlYWtwb2ludCBpbXBsZW1lbnRhdGlvbgo+ID4gPiBpbiBPcGVuU0JJLCBMaW51eCBS SVNDLVYsIGFuZCBLVk0gUklTQy1WLiBUaGlzIGlzIGJhc2VkIG9uIHRoZSB1cGNvbWluZwo+ID4g PiBTQkkgZGVidWcgdHJpZ2dlciBleHRlbnNpb24gZHJhZnQgcHJvcG9zYWwuCj4gPiA+IChSZWZl ciwgaHR0cHM6Ly9saXN0cy5yaXNjdi5vcmcvZy90ZWNoLWRlYnVnL21lc3NhZ2UvMTI2MSkKPiA+ ID4gCj4gPiA+IFRoZXJlIGFyZSBhbHNvIFJJU0UgcHJvamVjdHMgdG8gdHJhY2sgdGhlc2UgZWZm b3J0czoKPiA+ID4gaHR0cHM6Ly93aWtpLnJpc2Vwcm9qZWN0LmRldi9wYWdlcy92aWV3cGFnZS5h Y3Rpb24/cGFnZUlkPTM5NDU0MQo+ID4gPiBodHRwczovL3dpa2kucmlzZXByb2plY3QuZGV2L3Bh Z2VzL3ZpZXdwYWdlLmFjdGlvbj9wYWdlSWQ9Mzk0NTQ1Cj4gPiA+IAo+ID4gPiBDdXJyZW50bHks IHdlIGFyZSBpbiB0aGUgcHJvY2VzcyBvZiB1cHN0cmVhbWluZyB0aGUgT3BlblNCSSBzdXBwb3J0 Cj4gPiA+IGZvciBTQkkgZGVidWcgdHJpZ2dlciBleHRlbnNpb24uIFRoZSBMaW51eCBSSVNDLVYg YW5kIEtWTSBSSVNDLVYKPiA+ID4gcGF0Y2hlcyByZXF1aXJlIFNCSSBkZWJ1ZyB0cmlnZ2VyIGV4 dGVuc2lvbiBhbmQgU2R0cmlnIGV4dGVuc2lvbiB0bwo+ID4gPiBiZSBmcm96ZW4gd2hpY2ggd2ls bCBoYXBwZW4gbmV4dCB5ZWFyIDIwMjQuCj4gPiA+IAo+ID4gPiBSZWdhcmRzLAo+ID4gPiBBbnVw Cj4gPiA+IAo+ID4gCj4gPiBIaSBBbnVwLAo+ID4gCj4gPiBUaGFuayB5b3UgZm9yIHRoZSBpbmZv cm1hdGlvbiBhbmQgeW91ciBncmVhdCB3b3JrIG9uIHRoZSBTQkkKPiA+IERlYnVnIFRyaWdnZXIg RXh0ZW5zaW9uIHByb3Bvc2FsLgo+ID4gCj4gPiBTbyBJIHRoaW5rIHRoYXQgJ0hXIGJyZWFrcG9p bnRzIHN1cHBvcnQnIGluIHRoZSBhYm92ZSBUT0RPIGxpc3QKPiA+IHdpbGwgYmUgdGFrZW4gY2Fy ZSBvZiBieSBIaW1hbnNodSBmb2xsb3dpbmcgdGhlIGV4dGVuc2lvbiBwcm9wb3NhbC4KPiA+IAo+ ID4gT24gdGhlIG90aGVyIGhhbmQsIGlmIEkgdW5kZXJzdGFuZCBjb3JyZWN0bHksIHRoZSBzb2Z0 d2FyZQo+ID4gYnJlYWtwb2ludCBwYXJ0IG9mIEtWTSBHdWVzdCBEZWJ1ZyBoYXMgbm8gZGVwZW5k ZW5jeSBvbiB0aGUgbmV3Cj4gPiBleHRlbnNpb24gc2luY2UgaXQgZG9lcyBub3QgdXNlIHRoZSB0 cmlnZ2VyIG1vZHVsZS4gSnVzdCBhbgo+ID4gZWJyZWFrIHN1YnN0aXR1dGlvbiBpcyBtYWRlLgo+ ID4gCj4gPiBTbyBtYXkgSSBrbm93IHlvdXIgc3VnZ2VzdGlvbiBhYm91dCB0aGlzIFJGQz8gQm90 aCBpbiBLVk0gYW5kIFFFTVUuCj4gPiAKPiA+IFJlZ2FyZHMsCj4gPiBDaGFvCj4gPiAKPiAKPiBI aSBBbnVwIGFuZCBhbGwsCj4gCj4gSSdtIHN0aWxsIHdhaXRpbmcgZm9yIHlvdXIgY29tbWVudCBh bmQgc3VnZ2VzdGlvbiBmb3IgdGhlIG5leHQgc3RlcC4KPiA6KQo+IAo+IFRoYW5rcwo+IAo+ID4g PiA+Cj4gPiA+ID4gVGhpcyBzZXJpZXMgaXMgYmFzZWQgb24gTGludXggNi43LXJjNiBhbmQgaXMg YWxzbyBhdmFpbGFibGUgYXQ6Cj4gPiA+ID4gaHR0cHM6Ly9naXRodWIuY29tL0R1LUNoYW8vbGlu dXgvdHJlZS9yaXNjdl9nZF9zdwo+ID4gPiA+Cj4gPiA+ID4gVGhlIG1hdGNoZWQgUUVNVSBpcyBh dmFpbGFibGUgYXQ6Cj4gPiA+ID4gaHR0cHM6Ly9naXRodWIuY29tL0R1LUNoYW8vcWVtdS90cmVl L3Jpc2N2X2dkX3N3Cj4gPiA+ID4KPiA+ID4gPiBDaGFvIER1ICgzKToKPiA+ID4gPiAgIFJJU0Mt VjogS1ZNOiBFbmFibGUgdGhlIEtWTV9DQVBfU0VUX0dVRVNUX0RFQlVHIGNhcGFiaWxpdHkKPiA+ ID4gPiAgIFJJU0MtVjogS1ZNOiBJbXBsZW1lbnQga3ZtX2FyY2hfdmNwdV9pb2N0bF9zZXRfZ3Vl c3RfZGVidWcoKQo+ID4gPiA+ICAgUklTQy1WOiBLVk06IEhhbmRsZSBicmVha3BvaW50IGV4aXRz IGZvciBWQ1BVCj4gPiA+ID4KPiA+ID4gPiAgYXJjaC9yaXNjdi9pbmNsdWRlL3VhcGkvYXNtL2t2 bS5oIHwgIDEgKwo+ID4gPiA+ICBhcmNoL3Jpc2N2L2t2bS92Y3B1LmMgICAgICAgICAgICAgfCAx NSArKysrKysrKysrKysrLS0KPiA+ID4gPiAgYXJjaC9yaXNjdi9rdm0vdmNwdV9leGl0LmMgICAg ICAgIHwgIDQgKysrKwo+ID4gPiA+ICBhcmNoL3Jpc2N2L2t2bS92bS5jICAgICAgICAgICAgICAg fCAgMSArCj4gPiA+ID4gIDQgZmlsZXMgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgMiBkZWxl dGlvbnMoLSkKPiA+ID4gPgo+ID4gPiA+IC0tCj4gPiA+ID4gMi4xNy4xCj4gPiA+ID4KPiA+ID4g Pgo+ID4gPiA+IC0tCj4gPiA+ID4ga3ZtLXJpc2N2IG1haWxpbmcgbGlzdAo+ID4gPiA+IGt2bS1y aXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCj4gPiA+ID4gaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9rdm0tcmlzY3YK