Re: [PATCH mptcp-net 4/7] netlink: specs: mptcp: fix if-idx attribute type

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 06/09/2025 16:16, Geliang Tang wrote:
> Hi Matt,
> 
> On Fri, 2025-08-29 at 22:33 +0200, Matthieu Baerts (NGI0) wrote:
>> This attribute is used as a signed number in the code in
>> pm_netlink.c:
>>
>>   nla_put_s32(skb, MPTCP_ATTR_IF_IDX, ssk->sk_bound_dev_if))
>>
>> The specs should then reflect that. Note that other 'if-idx'
>> attributes
>> from the same .yaml file use a signed number as well.
>>
>> Fixes: bc8aeb2045e2 ("Documentation: netlink: add a YAML spec for
>> mptcp")
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> 
> Patches 4-6 LGTM!
> 
> Reviewed-by: Geliang Tang <geliang@kernel.org>
> 
> [mptcp-net,4/7] netlink: specs: mptcp: fix if-idx attribute type
> [mptcp-net,5/7] doc: mptcp: net.mptcp.pm_type is deprecated
> [mptcp-net,6/7] selftests: mptcp: shellcheck: support v0.11.0 
> 
> These three patches are relatively independent and can be removed from
> this series. They should be merged into the export branch first and do
> not need to be included in the v2 iteration. I changed the states of
> them as "Queued".

These patches were ordered by kernel versions these patches should be
backported to. But good idea, I can apply and send them today so it is done.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.