Re: [PATCH i-g-t 06/10] lib/kms: Remove tall tales about 'pipe' in DRM_IOCTL_WAIT_VBLANK

[Jani Nikula <jani.nikula@intel.com>]

On Wed, 10 Dec 2025, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The igt_wait_for_vblank_count() docs are talking nonsense about
> DRM_IOCTL_WAIT_VBLANK taking some kind of 'pipe' parameter.
> What it actually takes is the original (short-sighted)
> DRM_VBLANK_SECONDARY flag, and the later extension in the
> form of DRM_VBLANK_HIGH_CRTC_MASK.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  lib/igt_kms.c | 9 ---------
>  1 file changed, 9 deletions(-)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 951144bae955..3e7543ae1d88 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -5827,15 +5827,6 @@ static int __igt_vblank_wait(int drm_fd, int crtc_offset, int count)
>   * @count: Number of vblanks to wait on
>   *
>   * Waits for a given number of vertical blank intervals
> - *
> - * In DRM, 'Pipe', as understood by DRM_IOCTL_WAIT_VBLANK,
> - * is actually an offset of crtc in drmModeRes.crtcs
> - * and it has nothing to do with a hardware concept of a pipe.
> - * They can match but don't have to in case of DRM lease or
> - * non-contiguous pipes.
> - *
> - * To make thing clear we are calling DRM_IOCTL_WAIT_VBLANK's 'pipe'
> - * a crtc_offset.
>   */
>  void igt_wait_for_vblank_count(int drm_fd, int crtc_offset, int count)
>  {

-- 
Jani Nikula, Intel