From: Petr Pavlu <petr.pavlu@suse.com>
To: petr.pavlu@suse.com
Cc: "Tony Luck" <tony.luck@intel.com>,
"Borislav Petkov" <bp@alien8.de>,
"Thomas Gleixner" <tglx@kernel.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
"Philipp Reisner" <philipp.reisner@linbit.com>,
"Lars Ellenberg" <lars.ellenberg@linbit.com>,
"Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>,
"Jens Axboe" <axboe@kernel.dk>, "Johan Hovold" <johan@kernel.org>,
"Alex Elder" <elder@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Michal Januszewski" <spock@gentoo.org>,
"Helge Deller" <deller@gmx.de>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Christian Brauner" <brauner@kernel.org>,
"Jan Kara" <jack@suse.cz>, "Trond Myklebust" <trondmy@kernel.org>,
"Anna Schumaker" <anna@kernel.org>,
"Chuck Lever" <cel@kernel.org>,
"Jeff Layton" <jlayton@kernel.org>, NeilBrown <neil@brown.name>,
"Olga Kornievskaia" <okorniev@redhat.com>,
"Dai Ngo" <Dai.Ngo@oracle.com>, "Tom Talpey" <tom@talpey.com>,
"Mark Fasheh" <mark@fasheh.com>,
"Joel Becker" <jlbec@evilplan.org>,
"Joseph Qi" <joseph.qi@linux.alibaba.com>,
"Tejun Heo" <tj@kernel.org>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Daniel Gomez" <da.gomez@kernel.org>,
"Sami Tolvanen" <samitolvanen@google.com>,
"Aaron Tomlin" <atomlin@atomlin.com>,
"Pavel Machek" <pavel@kernel.org>, "Len Brown" <lenb@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Danilo Krummrich" <dakr@kernel.org>,
"Nikolay Aleksandrov" <razor@blackwall.org>,
"Ido Schimmel" <idosch@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"David Howells" <dhowells@redhat.com>,
"Jarkko Sakkinen" <jarkko@kernel.org>,
"Paul Moore" <paul@paul-moore.com>,
"James Morris" <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
"Kentaro Takeda" <takedakn@nttdata.co.jp>,
"Tetsuo Handa" <penguin-kernel@I-love.SAKURA.ne.jp>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
drbd-dev@lists.linux.dev, linux-block@vger.kernel.org,
greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org,
linux-acpi@vger.kernel.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-fsdevel@vger.kernel.org,
linux-nfs@vger.kernel.org, ocfs2-devel@lists.linux.dev,
cgroups@vger.kernel.org, linux-modules@vger.kernel.org,
linux-pm@vger.kernel.org, driver-core@lists.linux.dev,
bridge@lists.linux.dev, netdev@vger.kernel.org,
keyrings@vger.kernel.org, linux-security-module@vger.kernel.org
Subject: Re: [PATCH v3 0/3] Bring includes in linux/kmod.h up to date
Date: Tue, 22 Sep 2026 11:58:18 +0200 [thread overview]
Message-ID: <2bf82e0b-a032-4ee7-8d93-c5604222723d@suse.com> (raw)
In-Reply-To: <20260911-module-include-kmod-v3-0-6ebccc3e0731@suse.com>
On 9/11/26 4:46 PM, Petr Pavlu wrote:
> The usermode helper declarations were previously provided by linux/kmod.h
> but commit c1f3fa2a4fde ("kmod: split off umh headers into its own file")
> moved them to linux/umh.h in 2017. Add explicit includes of linux/umh.h to
> files that use usermode helpers and remove linux/kmod.h where it is no
> longer needed.
>
> Also add a missing include of linux/sysctl.h to kernel/time/jiffies.c.
>
> Finally, clean up linux/kmod.h so that it includes only the headers that it
> actually requires, importantly removing the compat linux/umh.h include.
>
> This cleanup is motivated by trying to reduce the preprocessed size of
> linux/module.h, which includes linux/kmod.h. linux/module.h appears in
> roughly 15k #include directives across the kernel. This makes it a "hot"
> header, so it should avoid pulling in unnecessary definitions. Note that
> this series doesn't immediately improve the situation, since most of the
> files included by linux/kmod.h are, for now, also included by
> linux/module.h through other paths.
>
> Apologies for the wide distribution. Acked-bys are appreciated.
I've queued the series on modules-next for 7.4-rc1.
--
Thanks,
Petr
prev parent reply other threads:[~2026-09-22 9:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 14:46 [PATCH v3 0/3] Bring includes in linux/kmod.h up to date Petr Pavlu
2026-09-11 14:46 ` [PATCH v3 1/3] umh, treewide: Explicitly include linux/umh.h where needed Petr Pavlu
2026-09-11 14:52 ` sashiko-bot
2026-09-22 12:39 ` Alex Elder
2026-09-11 14:46 ` [PATCH v3 2/3] time/jiffies: Include linux/sysctl.h for proc_int_u2k_conv_uop(), Petr Pavlu
2026-09-11 14:52 ` sashiko-bot
2026-09-11 14:46 ` [PATCH v3 3/3] module: Bring includes in linux/kmod.h up to date Petr Pavlu
2026-09-11 14:52 ` sashiko-bot
2026-09-22 9:58 ` Petr Pavlu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bf82e0b-a032-4ee7-8d93-c5604222723d@suse.com \
--to=petr.pavlu@suse.com \
--cc=Dai.Ngo@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=anna@kernel.org \
--cc=atomlin@atomlin.com \
--cc=axboe@kernel.dk \
--cc=bp@alien8.de \
--cc=brauner@kernel.org \
--cc=bridge@lists.linux.dev \
--cc=cel@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=christoph.boehmwalder@linbit.com \
--cc=da.gomez@kernel.org \
--cc=dakr@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=dhowells@redhat.com \
--cc=drbd-dev@lists.linux.dev \
--cc=dri-devel@lists.freedesktop.org \
--cc=driver-core@lists.linux.dev \
--cc=edumazet@google.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=hannes@cmpxchg.org \
--cc=horms@kernel.org \
--cc=hpa@zytor.com \
--cc=idosch@nvidia.com \
--cc=jack@suse.cz \
--cc=jarkko@kernel.org \
--cc=jlayton@kernel.org \
--cc=jlbec@evilplan.org \
--cc=jmorris@namei.org \
--cc=johan@kernel.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=keyrings@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=lars.ellenberg@linbit.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark@fasheh.com \
--cc=mcgrof@kernel.org \
--cc=mingo@redhat.com \
--cc=mkoutny@suse.com \
--cc=neil@brown.name \
--cc=netdev@vger.kernel.org \
--cc=ocfs2-devel@lists.linux.dev \
--cc=okorniev@redhat.com \
--cc=pabeni@redhat.com \
--cc=paul@paul-moore.com \
--cc=pavel@kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=philipp.reisner@linbit.com \
--cc=rafael@kernel.org \
--cc=razor@blackwall.org \
--cc=samitolvanen@google.com \
--cc=serge@hallyn.com \
--cc=spock@gentoo.org \
--cc=takedakn@nttdata.co.jp \
--cc=tglx@kernel.org \
--cc=tj@kernel.org \
--cc=tom@talpey.com \
--cc=tony.luck@intel.com \
--cc=trondmy@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.