From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?5ZGo5aSa5piO?= Subject: Re: Re: [PATCH] ax25: Fix memory leaks caused by ax25_cb_del() Date: Fri, 11 Mar 2022 00:01:20 +0800 (GMT+08:00) Message-ID: <2c28edff.f82b5.17f74902e09.Coremail.duoming@zju.edu.cn> References: <20220309150608.112090-1-duoming@zju.edu.cn> <20220310130508.GG3315@kadam> Mime-Version: 1.0 Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20220310130508.GG3315@kadam> List-ID: Content-Type: text/plain; charset="us-ascii" To: Dan Carpenter Cc: linux-hams@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jreuter@yaina.de, kuba@kernel.org, davem@davemloft.net, ralf@linux-mips.org, thomas@osterried.de SGVsbG8sCgpUaGFuayB5b3UgdmVyeSBtdWNoIGZvciBwb2ludGluZyB0aGUgd3JvbmcgcGxhY2Vz IGluIG15IHBhdGNoLgoKPiBUaGlzIGlzIGEgdmVyeSBmcnVzdHJhdGluZyBwYXRjaCBiZWNhdXNl IHlvdSBtYWtlIGEgbG90IG9mIHVubmVjZXNzYXJ5Cj4gd2hpdGUgc3BhY2UgY2hhbmdlcyBhbmQg eW91IGRpZG4ndCBydW4gY2hlY2twYXRjaCBvbiB5b3VyIHBhdGNoLgo+IAo+IFRoZSB3aG9sZSBh cHByb2FjaCBmZWVscyBsaWtlIHRoZSB3cm9uZyB0aGluZy4uLgoKSSB3aWxsIGZpeCBpdC4KCj4g SSBoYXZlIHJlYWQgeW91ciBjb21taXQgbWVzc2FnZSwgYnV0IEkgZG9uJ3QgdW5kZXJzdGFuZCB3 aHkgd2UgY2FuJ3QKPiBqdXN0IHVzZSBub3JtYWwgcmVmY291bnRpbmcuICBJdCBzb3VuZHMgbGlr ZSB0aGVyZSBpcyBhIGxheWVyaW5nCj4gdmlvbGF0aW9uIHNvbWV3aGVyZT8KClRoZSByb290IGNh dXNlIG9mIHJlZmNvdW50IGxlYWsgaXMgc2hvd24gYmVsb3c6CgogICAgIChUaHJlYWQgMSkgICAg ICAgICAgICAgICAgICAgICAgICAgIHwgICAgICAoVGhyZWFkIDIpCmF4MjVfYmluZCgpICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgfAogLi4uICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHwKIGF4MjVfYWRkcl9heDI1ZGV2KCkgICAgICAgICAgICAgICAgICAgICB8IAog IGF4MjVfZGV2X2hvbGQoKSAgIC8vKDEpICAgICAgICAgICAgICAgIHwKIC4uLiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICB8CiBkZXZfaG9sZF90cmFjaygpICAgLy8oMikgICAg ICAgICAgICAgICAgfCAKIC4uLiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8 IGF4MjVfZGVzdHJveV9zb2NrZXQoKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHwgIGF4MjVfY2JfZGVsKCkgICAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB8ICAgLi4uIAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHwgICBzcGluX2xvY2tfYmgoJmF4MjVfbGlzdF9sb2NrKTsKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB8ICAgaGxpc3RfZGVsX2luaXQoJmF4MjUtPmF4MjVfbm9k ZSk7IC8vKDMpIAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICBz cGluX3VubG9ja19iaCgmYXgyNV9saXN0X2xvY2spOwogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAKICAgICAodGhyZWFkIDMpICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgCmF4MjVfa2lsbF9ieV9kZXZpY2UoKSAgICAgICAgICAgICAgICAgICAgfAog c3Bpbl9sb2NrX2JoKCZheDI1X2xpc3RfbG9jayk7ICAgICAgICAgIHwKIGF4MjVfZm9yX2VhY2go cywgJmF4MjVfbGlzdCkgeyAgICAgICAgICB8CiAgaWYgKHMtPmF4MjVfZGV2ID09IGF4MjVfZGV2 KSAgLy8oNCkgICAgfCAgIAogIC4uLiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHwKICAodGhlIGZvbGxvd2luZyBjb2RlIGNvdWxkIG5vdCBleGVjdXRlKSB8CgpGaXJzdGx5LCB3 ZSB1c2UgYXgyNV9iaW5kKCkgdG8gaW5jcmVhc2UgdGhlIHJlZmNvdW50IG9mIGF4MjVfZGV2IGlu IApwb3NpdGlvbiAoMSkgYW5kIGluY3JlYXNlIHRoZSByZWZjb3VudCBvZiBuZXRfZGV2aWNlIGlu IHBvc2l0aW9uICgyKS4KClRoZW4sIHdlIHVzZSBheDI1X2NiX2RlbCgpIGludm9rZWQgYnkgYXgy NV9kZXN0cm95X3NvY2tldCgpCnRvIGRlbGV0ZSBheDI1X2NiIGluIGhsaXN0IGluIHBvc2l0aW9u ICgzKSBiZWZvcmUgY2FsbGluZyBheDI1X2tpbGxfYnlfZGV2aWNlKCkuCiAKRmluYWxseSwgdGhl IGRlY3JlbWVudHMgb2YgcmVmY291bnRzIGluIGF4MjVfa2lsbF9ieV9kZXZpY2UoKSB3aWxsIG5v dCBiZSBleGVjdXRlZCwKYmVjYXVzZSBubyBzLT5heDI1X2RldiBlcXVhbHMgdG8gYXgyNV9kZXYg aW4gcG9zaXRpb24gKDQpLgoKTXkgcGF0Y2ggYWRkcyB0d28gZmxhZ3MgaW4gYXgyNV9kZXYgaW4g b3JkZXIgdG8gcHJldmVudCByZWZlcmVuY2UgY291bnQgbGVha3MuIApJZiB0aGUgYWJvdmUgY29u ZGl0aW9uIGhhcHBlbnMsIHRoZSB0d28gInRlc3RfYml0IiBjaGVja3MgaW4gYXgyNV9raWxsX2J5 X2RldmljZSgpCmNvdWxkIHBhc3MgYW5kIHRoZSByZWZjb3VudHMgY291bGQgYmUgZGVjcmVhc2Vk IHByb3Blcmx5LgoKPiBFdmVuIGlmIHdlIGdvIHdpdGggdGhpcyBhcHByb2FjaCAtPmtpbGxfZmxh ZyBhbmQgLT5iaW5kX2ZsYWcgc2hvdWxkIGJlCj4gYm9vbGVhbnMuICBJdCBtYWtlcyBubyBzZW5z ZSB0byBoYXZlIGEgdW5zaWduZWQgbG9uZyB3aGVyZSBvbmx5IEJJVCgyKQo+IGNhbiBiZSBzZXQu CgpJIHdpbGwgY2hhbmdlIGtpbGxfZmxhZyBhbmQgYmluZF9mbGFnIHRvIGJvb2xlYW5zLgoKQmVz dCB3aXNoZXMsCkR1b21pbmcgWmhvdQo=