All of lore.kernel.org
 help / color / mirror / Atom feed
From: shuah <shuah@kernel.org>
To: Julia Lawall <julia.lawall@lip6.fr>, Suwan Kim <suwan.kim027@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org, valentina.manea.m@gmail.com,
	kbuild test robot <lkp@intel.com>, shuah <shuah@kernel.org>
Subject: Re: [PATCH v2] usbip: Fix free of unallocated memory in vhci tx
Date: Wed, 23 Oct 2019 09:55:15 -0600	[thread overview]
Message-ID: <2c3acd02-9687-80fb-27c9-d64d7932b7ab@kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.21.1910221151180.2637@hadrien>

On 10/22/19 3:51 AM, Julia Lawall wrote:
> 
> 
> On Tue, 22 Oct 2019, Suwan Kim wrote:
> 
>> iso_buffer should be set to NULL after use and free in the while loop.
>> In the case of isochronous URB in the while loop, iso_buffer is
>> allocated and after sending it to server, buffer is deallocated. And
>> then, if the next URB in the while loop is not a isochronous pipe,
>> iso_buffer still holds the previously deallocated buffer address and
>> kfree tries to free wrong buffer address.
>>
>> Fixes: ea44d190764b ("usbip: Implement SG support to vhci-hcd and stub driver")
>> Reported-by: kbuild test robot <lkp@intel.com>
>> Reported-by: Julia Lawall <julia.lawall@lip6.fr>
>> Signed-off-by: Suwan Kim <suwan.kim027@gmail.com>
> 
> Reviewed-by: Julia Lawall <julia.lawall@lip6.fr>
> 
>> ---
>> v1 - v2: Move the setting NULL after kfree() and add the comment
>> ---

Thanks.

Acked-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah

      reply	other threads:[~2019-10-23 15:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-22  9:30 [PATCH v2] usbip: Fix free of unallocated memory in vhci tx Suwan Kim
2019-10-22  9:51 ` Julia Lawall
2019-10-23 15:55   ` shuah [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c3acd02-9687-80fb-27c9-d64d7932b7ab@kernel.org \
    --to=shuah@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=suwan.kim027@gmail.com \
    --cc=valentina.manea.m@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.