From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Bee Subject: Re: [PATCH] linux: arm: vdso: nullpatch vdso_clock_gettime64 for non-virtual timers Date: Fri, 17 Jul 2020 01:25:53 +0200 Message-ID: <2c4484bf-a127-6f07-75f2-e0f0a15fe257@gmail.com> References: <20200716150723.9389-1-knaerzche@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726113AbgGPXZ7 (ORCPT ); Thu, 16 Jul 2020 19:25:59 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 081A2C061755 for ; Thu, 16 Jul 2020 16:25:58 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id f18so9010223wrs.0 for ; Thu, 16 Jul 2020 16:25:58 -0700 (PDT) In-Reply-To: Content-Language: en-US Sender: linux-arch-owner@vger.kernel.org List-ID: To: Robin Murphy , linux-arch@vger.kernel.org Cc: Florian Fainelli , Daniel Jordan , linux-arm-kernel@lists.infradead.org, Russell King , Vincenzo Frascino , Vlastimil Babka Hi Robin, Am 16.07.20 um 20:46 schrieb Robin Murphy: > Hi Alex, > > On 2020-07-16 16:07, Alex Bee wrote: >> Along with commit commit 74d06efb9c2f ("ARM: 8932/1: Add clock_gettime64 >> entry point") clock_gettime64 was added for ARM platform to solve the >> y2k38 problem on 32-bit platforms. glibc from version 2.31 onwards >> started using this vdso-call on ARM platforms. >> However it was (probably) forgotten to "nullpatch" this call, when no >> reliable timer source is available, for example when >> "arm,cpu-registers-not-fw-configured" is defined in devicetree for >> "arm,armv7-timer". >> This results in erratic time jumps whenever "gettimeofday" gets called, >> since the (non-working) vdso-call will be used instead of a syscall. >> >> This patch adds clock_gettime64 to get nullpatched as well. It has been >> verified to work and solve this issue on Rockchip RK322x, RK3288 and >> RPi4 (32-bit kernel build) platforms. > > FYI, a version of this patch was already submitted, and is just > waiting for Russell to apply it: > > https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=8987/1 > > Robin. OK - couldn't find this before. You can drop my patch than. > >> Signed-off-by: Alex Bee >> --- >>   arch/arm/kernel/vdso.c | 1 + >>   1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/kernel/vdso.c b/arch/arm/kernel/vdso.c >> index 6bfdca4769a7..fddd08a6e063 100644 >> --- a/arch/arm/kernel/vdso.c >> +++ b/arch/arm/kernel/vdso.c >> @@ -184,6 +184,7 @@ static void __init patch_vdso(void *ehdr) >>       if (!cntvct_ok) { >>           vdso_nullpatch_one(&einfo, "__vdso_gettimeofday"); >>           vdso_nullpatch_one(&einfo, "__vdso_clock_gettime"); >> +        vdso_nullpatch_one(&einfo, "__vdso_clock_gettime64"); >>       } >>   } >> Regards, Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94F19C433E6 for ; Thu, 16 Jul 2020 23:27:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6105A20760 for ; Thu, 16 Jul 2020 23:27:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iEbPk0w+"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="djx20166" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6105A20760 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5BK08q3NBjSkU/XhMlWeMuc6WwjFeo8sF1YKWH+ah7s=; b=iEbPk0w+aZwHySMWW4p2jfjLn Wr0nlhswwnzU1I/sq8C5j+rFw8lM2MOWnYqreACs9MCjcPV/5ktofvYS/zN/O4y/1fqET50NhDwSy wdrRWjh4E4L/JEcS73wOS0FFaANgt/SQkeWu/KTuHNdTD74VIbcl7NRjDzAeejRExdouSsRRBXpVe mxdfovvnl4CwVv0mPIb1Zp7/gWo7WcsuoiKMGpDHvyv1du2wZF9FKUANamU2wiqHdkhof+5Z947d/ wDjy66lTKcYhjRgZrk+R9aIQFDwuL5q78vvvxzn9fl2RoPaf0j5LQCul+UGBjPHedct4TNAnkWJJS 4JjjuAWJA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwDGM-0006m8-Sk; Thu, 16 Jul 2020 23:26:02 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwDGJ-0006lV-R8 for linux-arm-kernel@lists.infradead.org; Thu, 16 Jul 2020 23:26:01 +0000 Received: by mail-wr1-x444.google.com with SMTP id k6so8994881wrn.3 for ; Thu, 16 Jul 2020 16:25:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=CZCZw6UIqWa4eGCjjDxYWCcfpSKWkLW/z2join0b1/E=; b=djx20166Ifzrkr/PBx+ibbY+7XRIJbbbeYbSp67v/mKoxf4rpIIwsmwY5APU/jOcKk 7TgeIM8PtP788D8YW8dMk7tOM8NaoAyQhP1MGmipdmEia7IyRdD52m852nfGYNbCpCbh jPFvMzGjsHmxm8n2ospOoiPjQJsPPoCO767CCt87u1J4/c639Rq51F7Hy6Pg5bt4VY+U LvG7idYriK9JU7031REZjP606u/s0zKLZaXkZqnYTB+qz9tXbPLB91E7CwhdJtnbThSu J89uYpNrdQarIsHmfeg7+Z5lGlpJg3RZ9YYVSJUincS9JFrR9VIwFTI6euxE9dNF0Ajv o0bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=CZCZw6UIqWa4eGCjjDxYWCcfpSKWkLW/z2join0b1/E=; b=nudH2BuA2AYC+uuq1M2cXwWMROEI5OTiABIS3P/O/ElWU+4kUTip/g/iuCNEaiYHjN cGhnWldvAIGFZ/swBepvham+lfZpQAve90P8KaJ5tsWHD697uxUZeaKKOToOnsUzPUT2 MY8VDRT/2MrVogcUseOXFlUOufsnRZc/mpHmTtpaBFURD5WEgKU2AETEEuzpVQX27klj zkmWtErHNG3uMOhbdGBBSkVsIuxptgWKDX/xpkEWVe+y8f6UHP+bQBFkpPWk3RajVi1q 37IWpPTlKYcw3Rroi15yYc3zapdjtWVEHIeu4LLoaO6W+QHe7ICyjLQDloE4Svc73EGv jGjg== X-Gm-Message-State: AOAM531jqcWapMxkhC0tGzz5t1kKHqUZGpzC55DwcGMNlrmGCS32c8tJ u8UGYQ8yinExsfOCNAwrEQ== X-Google-Smtp-Source: ABdhPJzus8Uaf40w+JktJKlxNdRPX6rleQXh/c9z6onH1BS9Qb6f9cV/vmRw5LKKSzewA2nrJKNWgA== X-Received: by 2002:a5d:6342:: with SMTP id b2mr7238485wrw.262.1594941957497; Thu, 16 Jul 2020 16:25:57 -0700 (PDT) Received: from [192.168.200.34] (ip5b436a54.dynamic.kabel-deutschland.de. [91.67.106.84]) by smtp.gmail.com with ESMTPSA id u186sm10923422wmu.10.2020.07.16.16.25.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jul 2020 16:25:56 -0700 (PDT) Subject: Re: [PATCH] linux: arm: vdso: nullpatch vdso_clock_gettime64 for non-virtual timers To: Robin Murphy , linux-arch@vger.kernel.org References: <20200716150723.9389-1-knaerzche@gmail.com> From: Alex Bee Message-ID: <2c4484bf-a127-6f07-75f2-e0f0a15fe257@gmail.com> Date: Fri, 17 Jul 2020 01:25:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200716_192600_589978_F8F41D3D X-CRM114-Status: GOOD ( 21.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , Russell King , Daniel Jordan , linux-arm-kernel@lists.infradead.org, Vincenzo Frascino , Vlastimil Babka Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUm9iaW4sCgpBbSAxNi4wNy4yMCB1bSAyMDo0NiBzY2hyaWViIFJvYmluIE11cnBoeToKPiBI aSBBbGV4LAo+Cj4gT24gMjAyMC0wNy0xNiAxNjowNywgQWxleCBCZWUgd3JvdGU6Cj4+IEFsb25n IHdpdGggY29tbWl0IGNvbW1pdCA3NGQwNmVmYjljMmYgKCJBUk06IDg5MzIvMTogQWRkIGNsb2Nr X2dldHRpbWU2NAo+PiBlbnRyeSBwb2ludCIpIGNsb2NrX2dldHRpbWU2NCB3YXMgYWRkZWQgZm9y IEFSTSBwbGF0Zm9ybSB0byBzb2x2ZSB0aGUKPj4geTJrMzggcHJvYmxlbSBvbiAzMi1iaXQgcGxh dGZvcm1zLiBnbGliYyBmcm9tIHZlcnNpb24gMi4zMSBvbndhcmRzCj4+IHN0YXJ0ZWQgdXNpbmcg dGhpcyB2ZHNvLWNhbGwgb24gQVJNIHBsYXRmb3Jtcy4KPj4gSG93ZXZlciBpdCB3YXMgKHByb2Jh Ymx5KSBmb3Jnb3R0ZW4gdG8gIm51bGxwYXRjaCIgdGhpcyBjYWxsLCB3aGVuIG5vCj4+IHJlbGlh YmxlIHRpbWVyIHNvdXJjZSBpcyBhdmFpbGFibGUsIGZvciBleGFtcGxlIHdoZW4KPj4gImFybSxj cHUtcmVnaXN0ZXJzLW5vdC1mdy1jb25maWd1cmVkIiBpcyBkZWZpbmVkIGluIGRldmljZXRyZWUg Zm9yCj4+ICJhcm0sYXJtdjctdGltZXIiLgo+PiBUaGlzIHJlc3VsdHMgaW4gZXJyYXRpYyB0aW1l IGp1bXBzIHdoZW5ldmVyICJnZXR0aW1lb2ZkYXkiIGdldHMgY2FsbGVkLAo+PiBzaW5jZSB0aGUg KG5vbi13b3JraW5nKSB2ZHNvLWNhbGwgd2lsbCBiZSB1c2VkIGluc3RlYWQgb2YgYSBzeXNjYWxs Lgo+Pgo+PiBUaGlzIHBhdGNoIGFkZHMgY2xvY2tfZ2V0dGltZTY0IHRvIGdldCBudWxscGF0Y2hl ZCBhcyB3ZWxsLiBJdCBoYXMgYmVlbgo+PiB2ZXJpZmllZCB0byB3b3JrIGFuZCBzb2x2ZSB0aGlz IGlzc3VlIG9uIFJvY2tjaGlwIFJLMzIyeCwgUkszMjg4IGFuZAo+PiBSUGk0ICgzMi1iaXQga2Vy bmVsIGJ1aWxkKSBwbGF0Zm9ybXMuCj4KPiBGWUksIGEgdmVyc2lvbiBvZiB0aGlzIHBhdGNoIHdh cyBhbHJlYWR5IHN1Ym1pdHRlZCwgYW5kIGlzIGp1c3QgCj4gd2FpdGluZyBmb3IgUnVzc2VsbCB0 byBhcHBseSBpdDoKPgo+IGh0dHBzOi8vd3d3LmFybWxpbnV4Lm9yZy51ay9kZXZlbG9wZXIvcGF0 Y2hlcy92aWV3cGF0Y2gucGhwP2lkPTg5ODcvMQo+Cj4gUm9iaW4uCk9LIC0gY291bGRuJ3QgZmlu ZCB0aGlzIGJlZm9yZS4gWW91IGNhbiBkcm9wIG15IHBhdGNoIHRoYW4uCj4KPj4gU2lnbmVkLW9m Zi1ieTogQWxleCBCZWUgPGtuYWVyemNoZUBnbWFpbC5jb20+Cj4+IC0tLQo+PiDCoCBhcmNoL2Fy bS9rZXJuZWwvdmRzby5jIHwgMSArCj4+IMKgIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigr KQo+Pgo+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0va2VybmVsL3Zkc28uYyBiL2FyY2gvYXJtL2tl cm5lbC92ZHNvLmMKPj4gaW5kZXggNmJmZGNhNDc2OWE3Li5mZGRkMDhhNmUwNjMgMTAwNjQ0Cj4+ IC0tLSBhL2FyY2gvYXJtL2tlcm5lbC92ZHNvLmMKPj4gKysrIGIvYXJjaC9hcm0va2VybmVsL3Zk c28uYwo+PiBAQCAtMTg0LDYgKzE4NCw3IEBAIHN0YXRpYyB2b2lkIF9faW5pdCBwYXRjaF92ZHNv KHZvaWQgKmVoZHIpCj4+IMKgwqDCoMKgwqAgaWYgKCFjbnR2Y3Rfb2spIHsKPj4gwqDCoMKgwqDC oMKgwqDCoMKgIHZkc29fbnVsbHBhdGNoX29uZSgmZWluZm8sICJfX3Zkc29fZ2V0dGltZW9mZGF5 Iik7Cj4+IMKgwqDCoMKgwqDCoMKgwqDCoCB2ZHNvX251bGxwYXRjaF9vbmUoJmVpbmZvLCAiX192 ZHNvX2Nsb2NrX2dldHRpbWUiKTsKPj4gK8KgwqDCoMKgwqDCoMKgIHZkc29fbnVsbHBhdGNoX29u ZSgmZWluZm8sICJfX3Zkc29fY2xvY2tfZ2V0dGltZTY0Iik7Cj4+IMKgwqDCoMKgwqAgfQo+PiDC oCB9Cj4+ClJlZ2FyZHMsCgpBbGV4CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=