Re: [PATCH v1 1/4] dt-bindings: media: Add Sony IMX585 CMOS image sensor

[Krzysztof Kozlowski <krzk@kernel.org>]

On 02/07/2025 08:38, Will Whang wrote:
> +
> +description:
> +  IMX585 sensor is a Sony CMOS sensor with 4K and FHD outputs.
> +
> +properties:
> +  compatible:
> +    const: sony,imx585
> +
> +  clocks:
> +    maxItems: 1
> +
> +  clock-names:
> +    const: xclk
> +
> +  clock-frequency:
> +    enum: [ 74250000, 37125000, 72000000, 27000000, 24000000 ]

Drop the property.

> +
> +  reg:

reg always follows compatible.

> +    maxItems: 1
> +    description: I2C Address for IMX585

Drop description, redundant.

> +
> +  VANA-supply:

Lower case.

> +    description: Analog power supply (3.3V)
> +
> +  VDDL-supply:
> +    description: Interface power supply (1.8V)
> +
> +  VDIG-supply:
> +    description: Digital power supply (1.1V)
> +
> +  reset-gpios:
> +    description: Sensor reset (XCLR) GPIO
> +    maxItems: 1
> +
> +  port:
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    additionalProperties: false
> +
> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false
> +
> +        properties:
> +          data-lanes:
> +            anyOf:
> +              - items:
> +                  - const: 1
> +                  - const: 2
> +                  - const: 3
> +                  - const: 4
> +
> +          sync-mode:

Missing vendor prefix

> +            description: |
> +              Select the synchronisation mode of the sensor
> +                0 – internal sync, leader (default)
> +                1 – internal sync, follower
> +                2 – external sync
> +            $ref: /schemas/types.yaml#/definitions/uint8
> +            enum: [ 0, 1, 2 ]

This should be just string enum

Missing default

> +
> +          link-frequencies:
> +            description: Select the MIPI-CSI2 link speed in Mhz
> +            items:
> +              enum: [ 297000000, 360000000, 445500000, 594000000,
> +                      720000000, 891000000, 1039500000 ]
> +
> +        required:
> +          - data-lanes
> +          - link-frequencies
> +
> +    required:
> +      - endpoint
> +
> +required:
> +  - compatible
> +  - reg

And why here is different? BTW, here it is correct.


> +  - clocks
> +  - clock-frequency

Drop

> +  - port
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        imx585@1a {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation


> +            compatible = "sony,imx585";
> +            reg = <0x1a>;
> +            clocks = <&imx585_clk>;
> +            clock-frequency = <24000000>;
> +
> +            VANA-supply = <&camera_vadd_3v3>;
> +            VDDL-supply = <&camera_vdd1_1v8>;
> +            VDIG-supply = <&camera_vdd2_1v1>;
> +
> +            port {
> +                imx585: endpoint {
> +                    remote-endpoint = <&cam>;
> +                    data-lanes = <1 2 3 4>;
> +                    link-frequencies = /bits/ 64 <720000000>;
> +                };
> +            };
> +        };
> +    };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index da34c7227..9cc404790 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -23150,6 +23150,14 @@ T:	git git://linuxtv.org/media.git
>  F:	Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
>  F:	drivers/media/i2c/imx415.c
>  
> +SONY IMX585 SENSOR DRIVER
> +M:	Will Whang <will@willwhang.com>
> +L:	linux-media@vger.kernel.org
> +S:	Maintained
> +T:	git git://linuxtv.org/media.git

Drop, you do not have access there, AFAIK.

> +F:	Documentation/devicetree/bindings/media/i2c/sony,imx585.yaml
> +F:	drivers/media/i2c/imx585.c

There is no such file.

> +
>  SONY MEMORYSTICK SUBSYSTEM
>  M:	Maxim Levitsky <maximlevitsky@gmail.com>
>  M:	Alex Dubov <oakad@yahoo.com>


Best regards,
Krzysztof