Re: [PATCH net v2] net: phy: microchip_t1: fix NULL pointer dereference in lan887x_phy_init()

[Xuanqiang Luo <xuanqiang.luo@linux.dev>]

在 2026/9/3 19:30, huhai 写道:
> From: Henry Hu <huhai@kylinos.cn>
>
> The issue was discovered via smatch static analyzer:
>
>    make CHECK="smatch -p=kernel"  C=2  drivers/net/phy/microchip_t1.o
>      CHECK   scripts/mod/empty.c
>      DESCEND objtool
>      CHECK   drivers/net/phy/microchip_t1.c
>    drivers/net/phy/microchip_t1.c:1295 lan887x_phy_init() warn: 'priv->clock' can also be NULL
>
> mchp_rds_ptp_probe() returns NULL when CONFIG_MICROCHIP_PHY_RDS_PTP or
> CONFIG_PTP_1588_CLOCK is disabled. However, lan887x_phy_init() only checks
> for an error pointer before using the returned clock to configure the
> periodic output pin, which can result in a NULL pointer dereference.
>
> Handle the NULL return as PTP being unavailable and skip the event pin
> configuration in that case. Smatch no longer reports the NULL dereference
> warning after the change.
>
> Fixes: 8541fc12edcd ("net: phy: microchip_t1: Enable pin out specific to lan887x phy for PEROUT signal")
> Cc: stable@vger.kernel.org
> Reviewed-by: Divya Koppera <Divya.Koppera@microchip.com>
> Signed-off-by: Henry Hu <huhai@kylinos.cn>

Reviewed-by: Xuanqiang Luo <luoxuanqiang@kylinos.cn>

Thanks,
Xuanqiang