From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C87BEC41535 for ; Tue, 19 Dec 2023 11:06:06 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.656665.1025001 (Exim 4.92) (envelope-from ) id 1rFXv6-0003I3-TM; Tue, 19 Dec 2023 11:05:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 656665.1025001; Tue, 19 Dec 2023 11:05:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rFXv6-0003Hw-Q5; Tue, 19 Dec 2023 11:05:52 +0000 Received: by outflank-mailman (input) for mailman id 656665; Tue, 19 Dec 2023 11:05:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rFXv5-0003Hq-95 for xen-devel@lists.xenproject.org; Tue, 19 Dec 2023 11:05:51 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 911ef441-9e5e-11ee-98eb-6d05b1d4d9a1; Tue, 19 Dec 2023 12:05:49 +0100 (CET) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 524684EE0738; Tue, 19 Dec 2023 12:05:49 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 911ef441-9e5e-11ee-98eb-6d05b1d4d9a1 MIME-Version: 1.0 Date: Tue, 19 Dec 2023 12:05:49 +0100 From: Nicola Vetrini To: Jan Beulich Cc: consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, Luca Fancellu Subject: Re: [XEN PATCH] xen: add acmacros.h to exclude-list.json In-Reply-To: <2fd03776043811a8ceae9ae41de5f0fa@bugseng.com> References: <664ddc412905546d44d3e311a743ba5217a6243b.1702976486.git.nicola.vetrini@bugseng.com> <055b6cf3-4f29-4f1d-b650-26c6d9be8832@suse.com> <2fd03776043811a8ceae9ae41de5f0fa@bugseng.com> Message-ID: <2c64af71dcb3984f1753ef115868cb7b@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 2023-12-19 11:51, Nicola Vetrini wrote: > On 2023-12-19 11:37, Jan Beulich wrote: >> On 19.12.2023 10:02, Nicola Vetrini wrote: >>> --- a/docs/misra/exclude-list.json >>> +++ b/docs/misra/exclude-list.json >>> @@ -209,6 +209,10 @@ >>> "rel_path": "include/acpi/acglobal.h", >>> "comment": "Imported from Linux, ignore for now" >>> }, >>> + { >>> + "rel_path": "include/acpi/acmacros.h", >>> + "comment": "Imported from Linux, ignore for now" >>> + }, >> >> Together with what's already there (in context), wouldn't it better be >> the entire directory then which is excluded, or at least all >> include/acpi/ac*.h collectively (and perhaps also >> include/acpi/platform/ac*.h)? >> >> Jan > > +Cc Luca Fancellu > > Sure. I wasn't certain which files are imported from ACPI CA and which > aren't. > I'm also not sure whether "include/acpi/ac*.h" would be properly > recognized by other tooling that uses exclude-list.json (only cppcheck > I think). I Cc-ed Luca Fancellu on this. It occurred to me that it's surely ok to use "include/acpi/ac*" and "include/acpi/platform/ac*". -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)