From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Rosen Penev <rosenp@gmail.com>, devicetree@vger.kernel.org
Cc: "Hauke Mehrtens" <hauke@hauke-m.de>,
"Rafał Miłecki" <zajec5@gmail.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"moderated list:BROADCOM BCM5301X ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: BCM5301X: AC68U: set WAN MAC from nvram
Date: Thu, 3 Sep 2026 12:58:29 -0700 [thread overview]
Message-ID: <2c71e79e-af7e-46a8-ba2f-4a89bd68a91f@broadcom.com> (raw)
In-Reply-To: <20260805190156.6942-1-rosenp@gmail.com>
On 8/5/26 12:01, Rosen Penev wrote:
> The WAN MAC is offset by 1. Set in dts to avoid having to handle this in
> userspace.
>
> nvram size found from a random bootlog online.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
You are doing two things here:
- assign the MAC address from NVRAM
- declare the switch ports along with their label
Please split this up in two separate patches, thank you.
Also, enabling port 5 is problematic, see this discussion:
https://lore.kernel.org/all/20260831085217.391-1-strst.gs@gmail.com/
This applies to all of the similar patches you submitted, therefore I
won't repeat this feedback.
--
Florian
prev parent reply other threads:[~2026-09-03 19:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 19:01 [PATCH] ARM: dts: BCM5301X: AC68U: set WAN MAC from nvram Rosen Penev
2026-09-03 19:58 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c71e79e-af7e-46a8-ba2f-4a89bd68a91f@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hauke@hauke-m.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rosenp@gmail.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.