From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CC73C433FE for ; Fri, 11 Dec 2020 21:21:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C843A2409B for ; Fri, 11 Dec 2020 21:21:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392262AbgLKUCT (ORCPT ); Fri, 11 Dec 2020 15:02:19 -0500 Received: from so254-31.mailgun.net ([198.61.254.31]:48132 "EHLO so254-31.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391593AbgLKUB4 (ORCPT ); Fri, 11 Dec 2020 15:01:56 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1607716896; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=2e9HwG9RvYnfRwvySBPG6ZFW70dYlKMeWhTI1QG0Zds=; b=ZmEOoGVawCqMzMjihXVsN41dVr7SvKlZqPfSE7wCn9m3ixwNYU8F0+RgcmVUt6sAD8+cWlav iDGc6Wb2i0ZgehPI1YHraLQxTezqfuDbICcRXc62mGK/2tXOWEOdhwu6IfW+zFTr6YKal49u 1k7srnW43hJR1b4aDwdD17HQTWo= X-Mailgun-Sending-Ip: 198.61.254.31 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 5fd3cfefac06f8705346881d (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 11 Dec 2020 20:00:47 GMT Sender: hemantk=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 9FDC5C43461; Fri, 11 Dec 2020 20:00:46 +0000 (UTC) Received: from [10.46.162.249] (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: hemantk) by smtp.codeaurora.org (Postfix) with ESMTPSA id 87CFAC433CA; Fri, 11 Dec 2020 20:00:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 87CFAC433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=hemantk@codeaurora.org Subject: Re: [PATCH v4 01/10] mhi: Add mhi_controller_initialize helper To: Loic Poulain Cc: bbhatt@codeaurora.org, jhugo@codeaurora.org, linux-arm-msm@vger.kernel.org, manivannan.sadhasivam@linaro.org References: <1607594575-31590-1-git-send-email-loic.poulain@linaro.org> <1607594575-31590-2-git-send-email-loic.poulain@linaro.org> From: Hemant Kumar Message-ID: <2c756db7-563b-2af8-e9b3-324a58770d96@codeaurora.org> Date: Fri, 11 Dec 2020 12:00:36 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Loic, On 12/11/20 11:13 AM, Loic Poulain wrote: > Hi Hemant, > > Le ven. 11 déc. 2020 à 19:57, Hemant Kumar > a écrit : > > > > On 12/10/20 2:02 AM, Loic Poulain wrote: > > This function allows to initialize a mhi_controller structure. > > Today, it only zeroing the structure. > > > > Use this function from mhi_alloc_controller so that any further > > initialization can be factorized in initalize function. > > > > Signed-off-by: Loic Poulain > > > --- > >   drivers/bus/mhi/core/init.c | 7 +++++++ > >   include/linux/mhi.h         | 6 ++++++ > >   2 files changed, 13 insertions(+) > > > > diff --git a/drivers/bus/mhi/core/init.c > b/drivers/bus/mhi/core/init.c > > index 96cde9c..4acad28 100644 > > --- a/drivers/bus/mhi/core/init.c > > +++ b/drivers/bus/mhi/core/init.c > > @@ -1021,11 +1021,18 @@ void mhi_unregister_controller(struct > mhi_controller *mhi_cntrl) > >   } > >   EXPORT_SYMBOL_GPL(mhi_unregister_controller); > > > > +void mhi_initialize_controller(struct mhi_controller *mhi_cntrl) > > +{ > > +     memset(mhi_cntrl, 0, sizeof(*mhi_cntrl)); > > +} > > +EXPORT_SYMBOL_GPL(mhi_initialize_controller); > > + > >   struct mhi_controller *mhi_alloc_controller(void) > >   { > >       struct mhi_controller *mhi_cntrl; > > > >       mhi_cntrl = kzalloc(sizeof(*mhi_cntrl), GFP_KERNEL); > > +     mhi_initialize_controller(mhi_cntrl); > Considering the kzalloc, do we really need to call here as well ? > > > To summary back and forth on that change, the point is that mhi_cntrl > may have some extra initialization in the futur (e.g mutex init...) and > so a helper is needed to correctly initialize the structure, though > today it does nothing except zeroing. I am aware of the discussion and reason for introducing new exported API. Based on my understanding, as of now you are going to call the new exported API in MHI controller driver. I was thinking of adding new API in mhi_alloc_controller only after introducing extra initialization in future, without that it was looking redundant to me at this point of time. > > Regards, > Loïc > > > > > >       return mhi_cntrl; > >   } > > diff --git a/include/linux/mhi.h b/include/linux/mhi.h > > index 04cf7f3..2754742 100644 > > --- a/include/linux/mhi.h > > +++ b/include/linux/mhi.h > > @@ -537,6 +537,12 @@ struct mhi_driver { > >   #define to_mhi_device(dev) container_of(dev, struct mhi_device, > dev) > > > >   /** > > + * mhi_initialize_controller - Initialize MHI Controller structure > > + * @mhi_cntrl: MHI controller structure to initialize > > + */ > > +void mhi_initialize_controller(struct mhi_controller *mhi_cntrl); > > + > > +/** > >    * mhi_alloc_controller - Allocate the MHI Controller structure > >    * Allocate the mhi_controller structure using zero initialized > memory > >    */ > > > > Thanks, > Hemant > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora > Forum, > a Linux Foundation Collaborative Project > Thanks, Hemant -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project